[GitHub] [tomcat] kkolinko commented on issue #154: Don't serialize the whole valve into session, but use a smaller object.

[GitBox <gi...@apache.org>]

kkolinko commented on issue #154: Don't serialize the whole valve into session, but use a smaller object.
URL: https://github.com/apache/tomcat/pull/154#issuecomment-480852735
 
 
   1. Your title is lacking. Your "valve" is CrawlerSessionManagerValve.
   
   2. Behaviour of CrawlerSessionManagerValve versus serialization of sessions is a valid question. At least it needs some comments and documentation improvements. I think this should be filed into Bugzilla and discussed there. (Pull requests come and go, and Bugzilla is what is referenced in changelog).
   
   3. Your pull request does not make any sense to me.
   
   The current implementation of CrawlerSessionManagerValve does not implement java.io.Serializable, so it is not written out. Likewise, your CrawlerHttpSessionBindingListener does not implement Serializable. (*)
   
   The hashmaps of ids owned by CrawlerSessionManagerValve should exist in 1 instance only (in memory). It does not make sense to serialize them with a session.
   
   What am I missing, and what exactly is your problem? (And again, problems would better be filed into Bugzilla).
   
   (*) See javadoc for CrawlerSessionManagerValve => "All implemented interfaces":
   http://tomcat.apache.org/tomcat-9.0-doc/api/org/apache/catalina/valves/CrawlerSessionManagerValve.html
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org