You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/12/16 14:33:07 UTC

[GitHub] [pulsar] eolivelli commented on a change in pull request #8961: Fixes the recovery not respect to the isolation group settings

eolivelli commented on a change in pull request #8961:
URL: https://github.com/apache/pulsar/pull/8961#discussion_r544345073



##########
File path: pulsar-zookeeper-utils/src/main/java/org/apache/pulsar/zookeeper/ZkIsolatedBookieEnsemblePlacementPolicy.java
##########
@@ -142,11 +141,6 @@ private ZooKeeperCache getAndSetZkCache(Configuration conf) {
     public PlacementResult<List<BookieId>> newEnsemble(int ensembleSize, int writeQuorumSize, int ackQuorumSize,
             Map<String, byte[]> customMetadata, Set<BookieId> excludeBookies)
             throws BKNotEnoughBookiesException {
-        // parse the ensemble placement policy from the custom metadata, if it present, we will apply it to

Review comment:
       so this is the fix.
   can you please remove all unnecessary code formatting ?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org