[jira] [Comment Edited] (OAK-4948) Prevent FileStore flush call before it's fully initialized

["Alex Parvulescu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-4948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15585129#comment-15585129 ] 

Alex Parvulescu edited comment on OAK-4948 at 10/18/16 10:34 AM:
-----------------------------------------------------------------

proposed patch.
I see 2 cases:
 * {{bind}} not called yet ({{revisions}} is null
* {{bind}} called but store is still empty


was (Author: alex.parvulescu):
proposed patch

> Prevent FileStore flush call before it's fully initialized
> ----------------------------------------------------------
>
>                 Key: OAK-4948
>                 URL: https://issues.apache.org/jira/browse/OAK-4948
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: segment-tar
>            Reporter: Alex Parvulescu
>             Fix For: Segment Tar 0.0.16
>
>         Attachments: OAK-4948.patch
>
>
> As seen on a local test, it can sometimes happen that the {{flush}} call comes before the {{bind}} call.
> {noformat}
> java.lang.IllegalStateException: Revisions not bound to a store
>         at com.google.common.base.Preconditions.checkState(Preconditions.java:150) ~[guava-15.0.jar:na]
>         at org.apache.jackrabbit.oak.segment.file.TarRevisions.checkBound(TarRevisions.java:183) ~[classes/:na]
>         at org.apache.jackrabbit.oak.segment.file.TarRevisions.flush(TarRevisions.java:198) ~[classes/:na]
>         at org.apache.jackrabbit.oak.segment.file.FileStore.flush(FileStore.java:382) ~[classes/:na]
>         at org.apache.jackrabbit.oak.segment.file.FileStore$3.run(FileStore.java:227) ~[classes/:na]
>         at org.apache.jackrabbit.oak.segment.file.SafeRunnable.run(SafeRunnable.java:67) ~[classes/:na]
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)