[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1572: MINIFICPP-2027 Upgrade Google Cloud library to version 2.10.1

["lordgamez (via GitHub)" <gi...@apache.org>]

lordgamez commented on code in PR #1572:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1572#discussion_r1217643416


##########
extensions/gcp/tests/DeleteGCSObjectTests.cpp:
##########
@@ -86,9 +86,7 @@ TEST_F(DeleteGCSObjectTests, ServerGivesPermaError) {
 }
 
 TEST_F(DeleteGCSObjectTests, ServerGivesTransientErrors) {
-  EXPECT_CALL(*delete_gcs_object_->mock_client_, DeleteObject)
-      .WillOnce(testing::Return(TransientError()))
-      .WillOnce(testing::Return(TransientError()));

Review Comment:
   It is a change in the patch provided by the google cloud library as mentioned in this comment: https://github.com/googleapis/google-cloud-cpp/discussions/11613#discussioncomment-5973949



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org