You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "mymeiyi (via GitHub)" <gi...@apache.org> on 2023/03/10 13:08:07 UTC

[GitHub] [doris] mymeiyi commented on a diff in pull request #17551: [fix](insert) Session varaiables dont work for transaction insert

mymeiyi commented on code in PR #17551:
URL: https://github.com/apache/doris/pull/17551#discussion_r1132351799


##########
fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java:
##########
@@ -1486,7 +1486,9 @@ private void beginTxn(String dbName, String tblName) throws UserException, TExce
             InterruptedException, ExecutionException, TimeoutException {
         TransactionEntry txnEntry = context.getTxnEntry();
         TTxnParams txnConf = txnEntry.getTxnConf();
-        long timeoutSecond = ConnectContext.get().getExecTimeout();
+        SessionVariable sessionVariable = ConnectContext.get().getSessionVariable();
+        int timeoutSecond = sessionVariable.getQueryTimeoutS();

Review Comment:
   timeout should keep the original logic, because getExecTimeout may be query_timeout or insert_timeout



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org