You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/03/28 23:06:11 UTC

Review Request: Replaced use of libprocess specific gtest and gmock features.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10176/
-----------------------------------------------------------

Review request for mesos, Vinod Kone and Ben Mahler.


Description
-------

See summary.


Diffs
-----

  src/Makefile.am 847a54bb374f1961a06691ec41592f0bdbfa95e6 
  src/tests/allocator_tests.cpp e8b835f4fe0fbf1ca15589548d7b8d56c926e708 
  src/tests/allocator_zookeeper_tests.cpp 802a508fc365b4442c74573834e7ea4cfb69f048 
  src/tests/environment.cpp fd618787916a3d88eecf72c51a755b05c79eef59 
  src/tests/exception_tests.cpp b15d5b2d966963e3380dd39520c661672f34349c 
  src/tests/fault_tolerance_tests.cpp 9d3f8b1bfb58d459b1719d2ba1dbb2e93858fc92 
  src/tests/filter.hpp 31b38504151d42c0a78466ee90b4367afc121ab3 
  src/tests/filter.cpp a3b8bd0f19a0ee04e0bc1d6f1d0659426b687b0b 
  src/tests/gc_tests.cpp 67bf957c2ed61daefcd3baf2ee7aa4abaa524eab 
  src/tests/log_tests.cpp 599abe64eb1ed138cd2ff829ea67e42e4a428e4f 
  src/tests/master_tests.cpp f3d9e0a9a421ec8dc3705965c7e0cc6b353ef656 
  src/tests/slave_recovery_tests.cpp 47f9b0f215af2fb9bc300e0c92535b6f91afa5cd 
  src/tests/status_update_manager_tests.cpp 9ce47b5f1cae2468b03f2645d4ee582a3ab43f21 

Diff: https://reviews.apache.org/r/10176/diff/


Testing
-------

make check


Thanks,

Benjamin Hindman


Re: Review Request: Replaced use of libprocess specific gtest and gmock features.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10176/#review18525
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On March 28, 2013, 10:06 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10176/
> -----------------------------------------------------------
> 
> (Updated March 28, 2013, 10:06 p.m.)
> 
> 
> Review request for mesos, Vinod Kone and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 847a54bb374f1961a06691ec41592f0bdbfa95e6 
>   src/tests/allocator_tests.cpp e8b835f4fe0fbf1ca15589548d7b8d56c926e708 
>   src/tests/allocator_zookeeper_tests.cpp 802a508fc365b4442c74573834e7ea4cfb69f048 
>   src/tests/environment.cpp fd618787916a3d88eecf72c51a755b05c79eef59 
>   src/tests/exception_tests.cpp b15d5b2d966963e3380dd39520c661672f34349c 
>   src/tests/fault_tolerance_tests.cpp 9d3f8b1bfb58d459b1719d2ba1dbb2e93858fc92 
>   src/tests/filter.hpp 31b38504151d42c0a78466ee90b4367afc121ab3 
>   src/tests/filter.cpp a3b8bd0f19a0ee04e0bc1d6f1d0659426b687b0b 
>   src/tests/gc_tests.cpp 67bf957c2ed61daefcd3baf2ee7aa4abaa524eab 
>   src/tests/log_tests.cpp 599abe64eb1ed138cd2ff829ea67e42e4a428e4f 
>   src/tests/master_tests.cpp f3d9e0a9a421ec8dc3705965c7e0cc6b353ef656 
>   src/tests/slave_recovery_tests.cpp 47f9b0f215af2fb9bc300e0c92535b6f91afa5cd 
>   src/tests/status_update_manager_tests.cpp 9ce47b5f1cae2468b03f2645d4ee582a3ab43f21 
> 
> Diff: https://reviews.apache.org/r/10176/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Re: Review Request: Replaced use of libprocess specific gtest and gmock features.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10176/#review18486
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On March 28, 2013, 10:06 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10176/
> -----------------------------------------------------------
> 
> (Updated March 28, 2013, 10:06 p.m.)
> 
> 
> Review request for mesos, Vinod Kone and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 847a54bb374f1961a06691ec41592f0bdbfa95e6 
>   src/tests/allocator_tests.cpp e8b835f4fe0fbf1ca15589548d7b8d56c926e708 
>   src/tests/allocator_zookeeper_tests.cpp 802a508fc365b4442c74573834e7ea4cfb69f048 
>   src/tests/environment.cpp fd618787916a3d88eecf72c51a755b05c79eef59 
>   src/tests/exception_tests.cpp b15d5b2d966963e3380dd39520c661672f34349c 
>   src/tests/fault_tolerance_tests.cpp 9d3f8b1bfb58d459b1719d2ba1dbb2e93858fc92 
>   src/tests/filter.hpp 31b38504151d42c0a78466ee90b4367afc121ab3 
>   src/tests/filter.cpp a3b8bd0f19a0ee04e0bc1d6f1d0659426b687b0b 
>   src/tests/gc_tests.cpp 67bf957c2ed61daefcd3baf2ee7aa4abaa524eab 
>   src/tests/log_tests.cpp 599abe64eb1ed138cd2ff829ea67e42e4a428e4f 
>   src/tests/master_tests.cpp f3d9e0a9a421ec8dc3705965c7e0cc6b353ef656 
>   src/tests/slave_recovery_tests.cpp 47f9b0f215af2fb9bc300e0c92535b6f91afa5cd 
>   src/tests/status_update_manager_tests.cpp 9ce47b5f1cae2468b03f2645d4ee582a3ab43f21 
> 
> Diff: https://reviews.apache.org/r/10176/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>