You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/09/13 01:59:12 UTC
[GitHub] ZhennanQin commented on issue #12530: Implement mkldnn convolution
fusion and quantization.
ZhennanQin commented on issue #12530: Implement mkldnn convolution fusion and quantization.
URL: https://github.com/apache/incubator-mxnet/pull/12530#issuecomment-420857295
@zheng-da There's strong dependence between quantization and fusion because they all changed mkldnn_conv.cc, which is the key part of this PR. If I split them into 2 PRs, then this file needs to be reviewed twice, because quantization will change this file a lot(almost rewrite), which eventually increase the burden of code review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services