[jira] [Work logged] (HIVE-24293) Integer overflow in llap collision mask

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-24293?focusedWorklogId=503411&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-503411 ]

ASF GitHub Bot logged work on HIVE-24293:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Oct/20 21:45
            Start Date: 21/Oct/20 21:45
    Worklog Time Spent: 10m 
      Work Description: asinkovits opened a new pull request #1595:
URL: https://github.com/apache/hive/pull/1595


   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
     2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
     3. Ensure you have added or run the appropriate tests for your PR: 
     4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX:  Your PR title ...'.
     5. Be sure to keep the PR description updated to reflect all changes.
     6. Please write your PR title to summarize what this PR proposes.
     7. If possible, provide a concise example to reproduce the issue for a faster review.
   
   -->
   
   
   
   ### What changes were proposed in this pull request?
   bugfix
   
   
   ### Why are the changes needed?
   If multiple threads put the same buffer to the cache, only one succeeds. The other one detects this, and replaces its own buffer. This is marked by a bit mask encoded in a long, where the collided buffers are marked with a 1. By shifting the integer 1, it can happen that due to an overflow some buffers will not be removed after a collision, and the reference count decreases below zero, which is not a valid state.
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   Unit test added


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 503411)
    Remaining Estimate: 0h
            Time Spent: 10m

> Integer overflow in llap collision mask
> ---------------------------------------
>
>                 Key: HIVE-24293
>                 URL: https://issues.apache.org/jira/browse/HIVE-24293
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 4.0.0
>            Reporter: Antal Sinkovits
>            Assignee: Antal Sinkovits
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> If multiple threads put the same buffer to the cache, only one succeeds. The other one detects this, and replaces its own buffer. This is marked by a bit mask encoded in a long, where the collided buffers are marked with a 1.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)