You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@celix.apache.org by "Pepijn Noltes (JIRA)" <ji...@apache.org> on 2012/12/07 14:03:22 UTC
[jira] [Resolved] (CELIX-44) Remote Shell
[ https://issues.apache.org/jira/browse/CELIX-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pepijn Noltes resolved CELIX-44.
--------------------------------
Resolution: Implemented
> Remote Shell
> ------------
>
> Key: CELIX-44
> URL: https://issues.apache.org/jira/browse/CELIX-44
> Project: Celix
> Issue Type: New Feature
> Reporter: Pepijn Noltes
> Assignee: Pepijn Noltes
>
> Add Remote Shell, a telnet front-end for the shell, to Apache Celix.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Resolved] (CELIX-44) Remote Shell
Posted by Pepijn Noltes <pe...@gmail.com>.
On Tue, Dec 11, 2012 at 6:04 PM, Alexander Broekhuis
<a....@gmail.com>wrote:
> >
> >
> > For OSX I am using is 10.8, which comes APR 1.4.5. And this seems to work
> > with remote shell.
> > When building against the APR from MacPorts (version 1.4.6) I get a
> > segfault when connecting with telnet.
> > I checked at work and there I'm using CentOS 5.8 with APR version 1.4.6
> and
> > in this case I don't get segfaults when connecting.
> >
> > When i have some time, I will look try to fix this for OSX.
> >
>
> I upgraded my installation and now it works. 10.6 has version
> 1.3.something.
>
> When I was still on 10.6 I tried MacPorts version as well, but that one
> seems to miss support for the wakeable pollset, even though the code
> compiles fine with it.
>
> In the remote_shell.c the remoteShell_stopConnection doesn't check the
> error code of the apr_pollset_wakeup, but this one returns an error with
> the MacPorts version (APR_EINIT).
>
I corrected this and adjusted the creating of a parentless memory pool for
newly created connections. Apparently this resulted - in my case - in a
segfault. Could you verify if this works for you?
>
> >
> >
> > I think it would be wise to specify a minimum version of APR we support.
> > The current building and running page ([1]) mentioned a dependency to
> APR,
> > but not which version. I also think that we can expect from users to
> > compile/install a suitable APR version and not depend on the APR versions
> > installed in for example OSX. So IMO specifying a minimal APR version of
> > 1.4.x is no problem, or am I missing something ...
> >
>
> Normally I would agree, but upgrading the installed version on MacOSX is a
> problem (it probably breaks the httpd installation etc). So the only option
> is to use the MacPorts version, but even though it compiles, at runtime
> there are still problems.. So either the MacPorts version is missing
> something, or we are missing something ;).
>
> The point is, I'd like to be able to support OSX 10.6, and trying to fix
> this is needed for that one :).
Understandable, but the APR website only has a link to the documentation
for version 0.9 and 1.4 (see [1]). If you enter a url manual you can find
the 1.3 documentation (see [2]), but still I prefer a versions which is
supported from the website.
[1] http://apr.apache.org/
[2] http://apr.apache.org/docs/apr/1.3/
Greetings,
Pepijn
Re: [jira] [Resolved] (CELIX-44) Remote Shell
Posted by Alexander Broekhuis <a....@gmail.com>.
>
>
> For OSX I am using is 10.8, which comes APR 1.4.5. And this seems to work
> with remote shell.
> When building against the APR from MacPorts (version 1.4.6) I get a
> segfault when connecting with telnet.
> I checked at work and there I'm using CentOS 5.8 with APR version 1.4.6 and
> in this case I don't get segfaults when connecting.
>
> When i have some time, I will look try to fix this for OSX.
>
I upgraded my installation and now it works. 10.6 has version
1.3.something.
When I was still on 10.6 I tried MacPorts version as well, but that one
seems to miss support for the wakeable pollset, even though the code
compiles fine with it.
In the remote_shell.c the remoteShell_stopConnection doesn't check the
error code of the apr_pollset_wakeup, but this one returns an error with
the MacPorts version (APR_EINIT).
>
>
> I think it would be wise to specify a minimum version of APR we support.
> The current building and running page ([1]) mentioned a dependency to APR,
> but not which version. I also think that we can expect from users to
> compile/install a suitable APR version and not depend on the APR versions
> installed in for example OSX. So IMO specifying a minimal APR version of
> 1.4.x is no problem, or am I missing something ...
>
Normally I would agree, but upgrading the installed version on MacOSX is a
problem (it probably breaks the httpd installation etc). So the only option
is to use the MacPorts version, but even though it compiles, at runtime
there are still problems.. So either the MacPorts version is missing
something, or we are missing something ;).
The point is, I'd like to be able to support OSX 10.6, and trying to fix
this is needed for that one :).
--
Met vriendelijke groet,
Alexander Broekhuis
Re: [jira] [Resolved] (CELIX-44) Remote Shell
Posted by Pepijn Noltes <pe...@gmail.com>.
On Mon, Dec 10, 2012 at 1:09 PM, Alexander Broekhuis
<a....@gmail.com>wrote:
> Hi,
>
> >
> > Yes I did and for me it works for Linux and Mac OS X. Although i noticed
> so
> > small issues with Mac OS X, I did not run into a segfault.
> >
> > What OSX version do you have? As mentioned, I am still using 10.6 and
> missing some features in APR. Although I can compile against the MacPorts
> version, running it still causes problems related to the wakeable pollset.
> I can update my machine, but I guess 10.6 is still used quit a lot.. So I
> am not sure if this is the right thing to do.
>
For OSX I am using is 10.8, which comes APR 1.4.5. And this seems to work
with remote shell.
When building against the APR from MacPorts (version 1.4.6) I get a
segfault when connecting with telnet.
I checked at work and there I'm using CentOS 5.8 with APR version 1.4.6 and
in this case I don't get segfaults when connecting.
When i have some time, I will look try to fix this for OSX.
>
> > Good point, I will look into this.
> >
>
> See my previous remark, it might be better to look into supporting the
> older APR version..
>
I think it would be wise to specify a minimum version of APR we support.
The current building and running page ([1]) mentioned a dependency to APR,
but not which version. I also think that we can expect from users to
compile/install a suitable APR version and not depend on the APR versions
installed in for example OSX. So IMO specifying a minimal APR version of
1.4.x is no problem, or am I missing something ...
[1] http://incubator.apache.org/celix/documentation/buildingandrunning.html
Greetings,
Pepijn
Re: [jira] [Resolved] (CELIX-44) Remote Shell
Posted by Alexander Broekhuis <a....@gmail.com>.
Hi,
>
> Yes I did and for me it works for Linux and Mac OS X. Although i noticed so
> small issues with Mac OS X, I did not run into a segfault.
>
> What OSX version do you have? As mentioned, I am still using 10.6 and
missing some features in APR. Although I can compile against the MacPorts
version, running it still causes problems related to the wakeable pollset.
I can update my machine, but I guess 10.6 is still used quit a lot.. So I
am not sure if this is the right thing to do.
> Good point, I will look into this.
>
See my previous remark, it might be better to look into supporting the
older APR version..
--
Met vriendelijke groet,
Alexander Broekhuis
Re: [jira] [Resolved] (CELIX-44) Remote Shell
Posted by Pepijn Noltes <pe...@gmail.com>.
On Mon, Dec 10, 2012 at 10:14 AM, Alexander Broekhuis <a.broekhuis@gmail.com
> wrote:
> Hi,
> I've been testing the code, and while it compiles I run into segfaults. I
> still need to check what's going on.
>
> Have you tried everything using the latest commits? Just to be sure I
> didn't make an error somewhere else.
>
Yes I did and for me it works for Linux and Mac OS X. Although i noticed so
small issues with Mac OS X, I did not run into a segfault.
>
> I have several small other fixes, but I'll commit those later on. Most
> notably is the "add_subdirectory" in the toplevel CMake file. As written in
> a comment over there it is important to add sub directories in reversed
> order. Since "remote_shell" depends on "shell" it has to be listed above
> "shell". This has to do with the way CMake resolves dependencies. If
> someone by hand enables "shell" there is no problem.
>
> Also up until now I could always compile everything using the Mac OSX
> (10.6, which is rather old..) APR version, but this code uses some stuff
> that is newer. So I had to change to using the "MacPorts" APR version. I
> don't think this is a problem, but it might be important to list the
> minimum version in the docs.
>
Good point, I will look into this.
>
> Is there anything in this code which would prevent it from being used on
> windows? If not, I'll also try it there.
>
No, there should not be anything to prevent usage on Windows. Although I
have not tested is on Windows.
Thanks for taking a look at the remote shell.
Greetings,
Pepijn
>
> 2012/12/7 Pepijn Noltes (JIRA) <ji...@apache.org>
>
> >
> > [
> >
> https://issues.apache.org/jira/browse/CELIX-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
> >
> > Pepijn Noltes resolved CELIX-44.
> > --------------------------------
> >
> > Resolution: Implemented
> >
> > > Remote Shell
> > > ------------
> > >
> > > Key: CELIX-44
> > > URL: https://issues.apache.org/jira/browse/CELIX-44
> > > Project: Celix
> > > Issue Type: New Feature
> > > Reporter: Pepijn Noltes
> > > Assignee: Pepijn Noltes
> > >
> > > Add Remote Shell, a telnet front-end for the shell, to Apache Celix.
> >
> > --
> > This message is automatically generated by JIRA.
> > If you think it was sent incorrectly, please contact your JIRA
> > administrators
> > For more information on JIRA, see:
> http://www.atlassian.com/software/jira
> >
>
>
>
> --
> Met vriendelijke groet,
>
> Alexander Broekhuis
>
Re: [jira] [Resolved] (CELIX-44) Remote Shell
Posted by Alexander Broekhuis <a....@gmail.com>.
Hi,
I've been testing the code, and while it compiles I run into segfaults. I
still need to check what's going on.
Have you tried everything using the latest commits? Just to be sure I
didn't make an error somewhere else.
I have several small other fixes, but I'll commit those later on. Most
notably is the "add_subdirectory" in the toplevel CMake file. As written in
a comment over there it is important to add sub directories in reversed
order. Since "remote_shell" depends on "shell" it has to be listed above
"shell". This has to do with the way CMake resolves dependencies. If
someone by hand enables "shell" there is no problem.
Also up until now I could always compile everything using the Mac OSX
(10.6, which is rather old..) APR version, but this code uses some stuff
that is newer. So I had to change to using the "MacPorts" APR version. I
don't think this is a problem, but it might be important to list the
minimum version in the docs.
Is there anything in this code which would prevent it from being used on
windows? If not, I'll also try it there.
2012/12/7 Pepijn Noltes (JIRA) <ji...@apache.org>
>
> [
> https://issues.apache.org/jira/browse/CELIX-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> Pepijn Noltes resolved CELIX-44.
> --------------------------------
>
> Resolution: Implemented
>
> > Remote Shell
> > ------------
> >
> > Key: CELIX-44
> > URL: https://issues.apache.org/jira/browse/CELIX-44
> > Project: Celix
> > Issue Type: New Feature
> > Reporter: Pepijn Noltes
> > Assignee: Pepijn Noltes
> >
> > Add Remote Shell, a telnet front-end for the shell, to Apache Celix.
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
--
Met vriendelijke groet,
Alexander Broekhuis