[GitHub] wujimin commented on a change in pull request #769: [SCB-667] fix gracefully shutdown is not work in some case

[GitBox <gi...@apache.org>]

wujimin commented on a change in pull request #769: [SCB-667] fix gracefully shutdown is not work in some case
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/769#discussion_r195315235
 
 

 ##########
 File path: providers/provider-pojo/src/main/java/org/apache/servicecomb/provider/pojo/Invoker.java
 ##########
 @@ -57,7 +58,10 @@ public InvokerMeta(ReferenceConfig referenceConfig,
 
     // initialized and meta not changed
     public boolean isValid() {
-      return swaggerConsumer != null && microserviceMeta == referenceConfig.getMicroserviceMeta();
+      SCBStatus currentStatus = SCBEngine.getInstance().getStatus();
+      return SCBStatus.UP.equals(currentStatus)
 
 Review comment:
   when shutdown, this will cause createInvokerMeta again, not throw exception

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services