[jira] [Work logged] (GOBBLIN-807) TimingEvent to extend GobblinEventBuilder

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GOBBLIN-807?focusedWorklogId=267753&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-267753 ]

ASF GitHub Bot logged work on GOBBLIN-807:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/Jun/19 16:09
            Start Date: 26/Jun/19 16:09
    Worklog Time Spent: 10m 
      Work Description: zxcware commented on pull request #2678: [GOBBLIN-807] TimingEvent is now closeable, extends GobblinEventBuilder
URL: https://github.com/apache/incubator-gobblin/pull/2678#discussion_r297749876
 
 

 ##########
 File path: gobblin-metrics-libs/gobblin-metrics-base/src/main/java/org/apache/gobblin/metrics/event/TimingEvent.java
 ##########
 @@ -109,21 +122,75 @@ public void stop() {
    *
    * @param additionalMetadata a {@link Map} of additional metadata that should be submitted along with this event
    */
+  @Deprecated
 
 Review comment:
   Add alternative way, the same applied to `stop()`
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 267753)
    Time Spent: 1h  (was: 50m)

> TimingEvent to extend GobblinEventBuilder 
> ------------------------------------------
>
>                 Key: GOBBLIN-807
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-807
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Vikram Bohra
>            Priority: Minor
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> GobblinEventBuilder and its subclasses should be used to build GobblinTrackingEvents and EventSubmitter should solely be responsible for submitting events. Depreacate older roles and methods appropriately.TimingEvent should extend the GobblinEventBuilder while maintaining older methods for backward compatability.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)