You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Sid Wagle <sw...@hortonworks.com> on 2014/01/09 00:53:54 UTC
Re: Review Request 16744: Allow unlimited size for request_body of the
RequestSchedule entity
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16744/
-----------------------------------------------------------
(Updated Jan. 8, 2014, 11:53 p.m.)
Review request for Ambari, Mahadev Konar and Sumit Mohanty.
Bugs: AMBARI-4237
https://issues.apache.org/jira/browse/AMBARI-4237
Repository: ambari
Description (updated)
-------
Currently the RequestSchedule entity stores the request body as a varchar with max size of 4000 bytes. This is because of Oracle's restriction on the column size.
Objectives:
Change request_body datatype to blob.
Allow for conversion to String and back
Modify the RequestSchedule ResourceProvider to not send request_body on every get call. (only send for request by id)
Includes additional minor changes for RequestSchedule endpoint.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/RequestScheduleResponse.java a94e972
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestScheduleResourceProvider.java 2d3826e
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestScheduleBatchRequestEntity.java 48a4db9
ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduleManager.java a3199e4
ambari-server/src/main/java/org/apache/ambari/server/state/scheduler/RequestExecution.java 9a7570d
ambari-server/src/main/java/org/apache/ambari/server/state/scheduler/RequestExecutionImpl.java 014e6bd
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 97a17ea
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 071469a
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 047b6ab
ambari-server/src/main/resources/Ambari-DDL-Postgres-REMOTE-CREATE.sql ff251c8
ambari-server/src/main/resources/properties.json 952197b
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestScheduleResourceProviderTest.java e391a3b
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/RequestScheduleDAOTest.java 4c0d656
ambari-server/src/test/java/org/apache/ambari/server/state/RequestExecutionTest.java c2e3243
Diff: https://reviews.apache.org/r/16744/diff/
Testing
-------
Thanks,
Sid Wagle