You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/08/18 20:27:01 UTC
[GitHub] [nifi] jfrazee commented on a diff in pull request #6159: NIFI-8248 Modify PutAzureDataLakeStorage processor to use temp file i…
jfrazee commented on code in PR #6159:
URL: https://github.com/apache/nifi/pull/6159#discussion_r949560824
##########
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/resources/docs/org.apache.nifi.processors.azure.storage.PutAzureDataLakeStorage/additionalDetails.html:
##########
@@ -28,27 +28,29 @@
<h3>File uploading and cleanup process</h3>
-<h4>New file</h4>
+<h4>New file upload</h4>
<ol>
- <li>An empty file is created.</li>
- <li>Content is appended to file.</li>
- <li>In case append failure the file is deleted.</li>
- <li>In case file deletion failure the empty file remains on the server.</li>
+ <li>A temporary file is created with random prefix under the given path in '_$azuretempdirectory$'.</li>
Review Comment:
I think this changed to `_nifitempdirectory` in the final commits.
```suggestion
<li>A temporary file is created with random prefix under the given path in '_$nifitempdirectory$'.</li>
```
##########
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/resources/docs/org.apache.nifi.processors.azure.storage.PutAzureDataLakeStorage/additionalDetails.html:
##########
@@ -28,27 +28,29 @@
<h3>File uploading and cleanup process</h3>
-<h4>New file</h4>
+<h4>New file upload</h4>
<ol>
- <li>An empty file is created.</li>
- <li>Content is appended to file.</li>
- <li>In case append failure the file is deleted.</li>
- <li>In case file deletion failure the empty file remains on the server.</li>
+ <li>A temporary file is created with random prefix under the given path in '_$azuretempdirectory$'.</li>
+ <li>Content is appended to temp file.</li>
+ <li>Temp file is renamed to its original name, the original file is overwritten.</li>
+ <li>In case of appending or renaming failure the temp file is deleted, the original file remains intact.</li>
+ <li>In case of temporary file deletion failure both temp file and original file remain on the server.</li>
</ol>
-<h4>Existing file</h4>
+<h4>Existing file upload</h4>
<ul>
<li>Processors with "fail" conflict resolution strategy will be directed to "Failure" relationship.</li>
- <li>Processors with "ignore" conflict resolution strategy will be directed to "Success" relationship.</li>
+ <li>Processors with "ignore" conflict resolution strategy will be directed to "Success" relationship.</li>
<li>Processors with "replace" conflict resolution strategy:</li>
<ol>
- <li>An empty file overwrites the existing file, the original file is lost.</li>
- <li>Content is appended to file.</li>
- <li>In case append failure the file is deleted.</li>
- <li>In case file deletion failure the empty file remains on the server.</li>
+ <li>A temporary file is created with random prefix under the given path in '_$azuretempdirectory$'.</li>
Review Comment:
```suggestion
<li>A temporary file is created with random prefix under the given path in '_$nifitempdirectory$'.</li>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org