You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jordan Birdsell (Code Review)" <ge...@cloudera.org> on 2016/09/30 21:57:34 UTC

[kudu-CR] Python - Clean up distutils classifiers and package information

Jordan Birdsell has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4579

Change subject: Python - Clean up distutils classifiers and package information
......................................................................

Python - Clean up distutils classifiers and package information

Updated development status to beta (from alpha) and added several
new classifiers. Additionally, updated url to kudu.apache.org.

Change-Id: Ie98313df2a939339f4e8a3cbd1b8580d0760e856
---
M python/setup.py
1 file changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/4579/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie98313df2a939339f4e8a3cbd1b8580d0760e856
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>

[kudu-CR] Python - Clean up distutils classifiers and package information

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.

Change subject: Python - Clean up distutils classifiers and package information
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie98313df2a939339f4e8a3cbd1b8580d0760e856
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] Python - Clean up distutils classifiers and package information

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.

Change subject: Python - Clean up distutils classifiers and package information
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4579/1/python/setup.py
File python/setup.py:

Line 134:     'Topic :: Scientific/Engineering :: Interface Engine/Protocol Translator',
> Its one of the "topics" in the distutils classifiers.  Seemed relevant and 
lgtm


-- 
To view, visit http://gerrit.cloudera.org:8080/4579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie98313df2a939339f4e8a3cbd1b8580d0760e856
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] Python - Clean up distutils classifiers and package information

Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has posted comments on this change.

Change subject: Python - Clean up distutils classifiers and package information
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4579/1/python/setup.py
File python/setup.py:

Line 134:     'Topic :: Scientific/Engineering :: Interface Engine/Protocol Translator',
> I have no idea what this means/comes from, I'm going to trust you do :)
Its one of the "topics" in the distutils classifiers.  Seemed relevant and on par with some other db interfaces.


-- 
To view, visit http://gerrit.cloudera.org:8080/4579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie98313df2a939339f4e8a3cbd1b8580d0760e856
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] Python - Clean up distutils classifiers and package information

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: Python - Clean up distutils classifiers and package information
......................................................................


Python - Clean up distutils classifiers and package information

Updated development status to beta (from alpha) and added several
new classifiers. Additionally, updated url to kudu.apache.org.

Change-Id: Ie98313df2a939339f4e8a3cbd1b8580d0760e856
Reviewed-on: http://gerrit.cloudera.org:8080/4579
Reviewed-by: David Ribeiro Alves <dr...@apache.org>
Tested-by: Kudu Jenkins
---
M python/setup.py
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  David Ribeiro Alves: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie98313df2a939339f4e8a3cbd1b8580d0760e856
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Python - Clean up distutils classifiers and package information

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.

Change subject: Python - Clean up distutils classifiers and package information
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4579/1/python/setup.py
File python/setup.py:

Line 134:     'Topic :: Scientific/Engineering :: Interface Engine/Protocol Translator',
I have no idea what this means/comes from, I'm going to trust you do :)


-- 
To view, visit http://gerrit.cloudera.org:8080/4579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie98313df2a939339f4e8a3cbd1b8580d0760e856
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes