You are viewing a plain text version of this content. The canonical link for it is here.

Posted to users@myfaces.apache.org by Renzo Tomaselli <re...@tecnotp.it> on 2008/01/19 19:40:40 UTC

[Trinidad] js centering bug in tr:panelPopup

Hi, in method TrPanelPopup._centerOnScreen() the window height is 
computed for IE through document.body.clientHeight.
This provides document height instead of window height, in case of IE 6+ 
in strict mode.
The final result is an up-shifted panel, even beyond the top in case of 
panels higher than current document.
Using document.documentElement.clientHeight does the right job, if 
returned value is not 0 (strict). Otherwise we are in quirks mode, thus 
use document.body.clientHeight.

Re: [Trinidad] js centering bug in tr:panelPopup

Posted by Andrew Robinson <an...@gmail.com>.

Please open an issue with a patch

On Jan 19, 2008 11:40 AM, Renzo Tomaselli <re...@tecnotp.it>
wrote:

> Hi, in method TrPanelPopup._centerOnScreen() the window height is
> computed for IE through document.body.clientHeight.
> This provides document height instead of window height, in case of IE 6+
> in strict mode.
> The final result is an up-shifted panel, even beyond the top in case of
> panels higher than current document.
> Using document.documentElement.clientHeight does the right job, if
> returned value is not 0 (strict). Otherwise we are in quirks mode, thus
> use document.body.clientHeight.
>
>
>
>