[GitHub] [spark] cloud-fan commented on a change in pull request #35416: [SPARK-38126][SQL][TESTS] Check the whole message of error classes

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #35416:
URL: https://github.com/apache/spark/pull/35416#discussion_r800726038



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/errors/QueryCompilationErrorsSuite.scala
##########
@@ -72,9 +72,8 @@ class QueryCompilationErrorsSuite extends QueryTest with SharedSparkSession {
 
       Dataset.ofRows(spark, plan)
     }.message
-    assert(msg.contains("The feature is not supported: " +
+    assert(msg.matches("The feature is not supported: " +

Review comment:
       is this a user-facing error? The test constructs logical plan directly which is not user-facing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org