You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2020/01/06 15:42:02 UTC
[GitHub] [storm] Ethanlm commented on a change in pull request #3184:
STORM-3555 add meter to track errors killing workers
Ethanlm commented on a change in pull request #3184: STORM-3555 add meter to track errors killing workers
URL: https://github.com/apache/storm/pull/3184#discussion_r363348174
##########
File path: storm-server/src/main/java/org/apache/storm/daemon/supervisor/Supervisor.java
##########
@@ -528,6 +532,9 @@ void killWorkers(Collection<String> workerIds, ContainerLauncher launcher) throw
long start = Time.currentTimeMillis();
while (!k.areAllProcessesDead()) {
if ((Time.currentTimeMillis() - start) > 10_000) {
+ if (killErrorMeter != null) {
+ killErrorMeter.mark();
+ }
Review comment:
If this happens, the supervisor will exit. What's the value of this meter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services