[GitHub] [hudi] dongkelun commented on a change in pull request #3882: [HUDI-2642] Add support ignoring case in update sql operation

[GitBox <gi...@apache.org>]

dongkelun commented on a change in pull request #3882:
URL: https://github.com/apache/hudi/pull/3882#discussion_r757842535



##########
File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/UpdateHoodieTableCommand.scala
##########
@@ -51,7 +51,10 @@ case class UpdateHoodieTableCommand(updateTable: UpdateTable) extends RunnableCo
     }.toMap
 
     val updateExpressions = table.output
-      .map(attr => name2UpdateValue.getOrElse(attr.name, attr))
+      .map(attr => {
+        val UpdateValueOption = name2UpdateValue.find(f => sparkSession.sessionState.conf.resolver(f._1, attr.name))

Review comment:
       Because its value will be used later. If use `name2UpdateValue.exists`,  it will be obtained again later, resulting in duplicate searches




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org