You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/06/07 14:53:25 UTC
[GitHub] [incubator-dolphinscheduler] codecov-commenter commented on pull request #2918: fix oom when no master is active in dev-1.3.0
codecov-commenter commented on pull request #2918:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2918#issuecomment-640230886
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2918?src=pr&el=h1) Report
> Merging [#2918](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2918?src=pr&el=desc) into [dev-1.3.0](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/b5d29a6d3de62f3d8f40dd546b45326990cc66e8&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `9.41%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2918?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev-1.3.0 #2918 +/- ##
============================================
Coverage 37.47% 37.47%
+ Complexity 2585 2581 -4
============================================
Files 436 436
Lines 20127 20192 +65
Branches 2455 2466 +11
============================================
+ Hits 7542 7567 +25
- Misses 11912 11947 +35
- Partials 673 678 +5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2918?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...scheduler/api/controller/DataSourceController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2918/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvRGF0YVNvdXJjZUNvbnRyb2xsZXIuamF2YQ==) | `3.63% <0.00%> (ø)` | `2.00 <0.00> (ø)` | |
| [...inscheduler/common/task/datax/DataxParameters.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2918/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svZGF0YXgvRGF0YXhQYXJhbWV0ZXJzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../dolphinscheduler/common/utils/ParameterUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2918/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1BhcmFtZXRlclV0aWxzLmphdmE=) | `38.94% <0.00%> (-1.06%)` | `13.00 <3.00> (ø)` | |
| [...he/dolphinscheduler/common/utils/ScriptRunner.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2918/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1NjcmlwdFJ1bm5lci5qYXZh) | `58.57% <ø> (ø)` | `15.00 <0.00> (ø)` | |
| [...phinscheduler/dao/datasource/OracleDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2918/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2RhdGFzb3VyY2UvT3JhY2xlRGF0YVNvdXJjZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...scheduler/dao/upgrade/DolphinSchedulerManager.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2918/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3VwZ3JhZGUvRG9scGhpblNjaGVkdWxlck1hbmFnZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...pache/dolphinscheduler/dao/upgrade/UpgradeDao.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2918/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3VwZ3JhZGUvVXBncmFkZURhby5qYXZh) | `8.37% <0.00%> (-0.04%)` | `5.00 <0.00> (ø)` | |
| [...e/dolphinscheduler/remote/NettyRemotingClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2918/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `51.07% <0.00%> (ø)` | `9.00 <0.00> (ø)` | |
| [...r/master/dispatch/host/LowerWeightHostManager.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2918/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9kaXNwYXRjaC9ob3N0L0xvd2VyV2VpZ2h0SG9zdE1hbmFnZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ler/server/worker/processor/TaskKillProcessor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2918/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9wcm9jZXNzb3IvVGFza0tpbGxQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [25 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2918/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2918?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2918?src=pr&el=footer). Last update [422fe51...7bb322d](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2918?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org