[GitHub] ccollins476ad commented on a change in pull request #1363: sensor_shell: Use sensor_data_func for sensor_read() instead of the listener

[GitBox <gi...@apache.org>]

ccollins476ad commented on a change in pull request #1363: sensor_shell: Use sensor_data_func for sensor_read() instead of the listener
URL: https://github.com/apache/mynewt-core/pull/1363#discussion_r213871732
 
 

 ##########
 File path: hw/sensor/src/sensor_shell.c
 ##########
 @@ -591,7 +572,7 @@ sensor_cmd_read(char *name, sensor_type_t type, struct sensor_poll_data *spd)
 err:
     os_sem_release(&g_sensor_shell_sem);
 
 Review comment:
   I don't think this call to `os_sem_release()` is necessary (I know this was here before your change).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services