[jira] [Work logged] (BEAM-13857) Add expansion service startup to Go integration test flags.

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-13857?focusedWorklogId=736292&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-736292 ]

ASF GitHub Bot logged work on BEAM-13857:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Mar/22 20:21
            Start Date: 03/Mar/22 20:21
    Worklog Time Spent: 10m 
      Work Description: youngoli commented on a change in pull request #16908:
URL: https://github.com/apache/beam/pull/16908#discussion_r819033562



##########
File path: sdks/go/test/integration/expansions.go
##########
@@ -0,0 +1,116 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//    http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package integration
+
+import (
+	"fmt"
+	"strconv"
+	"time"
+
+	"github.com/apache/beam/sdks/v2/go/test/integration/internal/jars"
+	"github.com/apache/beam/sdks/v2/go/test/integration/internal/ports"
+)
+
+// ExpansionServices is a struct used for getting addresses and starting expansion services, based
+// on the --expansion_jar and --expansion_addr flags in this package. The main reason to use this
+// instead of accessing the flags directly is to let it handle jar startup and shutdown.
+//
+// Usage
+//
+// Create an ExpansionServices object in TestMain with NewExpansionServices. Then use GetAddr for
+// every expansion service needed for the test. Call Shutdown on it before finishing TestMain (or
+// simply defer a call to it).
+//
+// ExpansionServices is not concurrency safe, and so a single instance should not be used within
+// multiple individual tests, due to the possibility of those tests being run concurrently. It is
+// recommended to only use ExpansionServices in TestMain to avoid this.
+//
+// Example:
+//   var retCode int
+//   defer func() { os.Exit(retCode) }()  // Defer os.Exit so it happens after other defers.
+//   services := integration.NewExpansionServices()
+//   defer func() { services.Shutdown() }()
+//   addr, err := services.GetAddr("example")
+//   if err != nil {
+//     panic(err)
+//   }

Review comment:
       Done.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 736292)
    Time Spent: 1h 10m  (was: 1h)

> Add expansion service startup to Go integration test flags.
> -----------------------------------------------------------
>
>                 Key: BEAM-13857
>                 URL: https://issues.apache.org/jira/browse/BEAM-13857
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-go
>            Reporter: Ritesh Ghorse
>            Assignee: Daniel Oliveira
>            Priority: P2
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Currently a separate debezium io expansion address flag needs to be passed to the runner when running cross-language debezium IO pipelines from Go SDK. Find a way to do this in a better way so that we could have it started along with java io expansion service while spinning up the test without bulking :sdks:java:io:expansion-service.
> In particular, needing to add a flag per expansion service jar to our integration tests will eventually become quite cluttered, so we may wish to settle on some kind of KV map flag approach instead to reduce copypasta code overhead.
> Edit: Decided on going with the KV map flag approach within the Go SDK instead of in a bash script, and moving expansion service startup into the codebase as well.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)