You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@calcite.apache.org by Julian Hyde <jh...@apache.org> on 2015/02/01 05:54:51 UTC

[VOTE] Release apache-calcite-1.0.0-incubating (release candidate 3)

Hi all,

I have created a build for Apache Calcite 1.0.0-incubating, release candidate 3.

Thanks to everyone who has contributed to this release.

This is Calcite's first major release. The release adds:
* SQL support for GROUPING SETS, EXTEND, UPSERT and sequences;
* a remote JDBC driver;
* improvements to the planner engine and built-in planner rules;
* improvements to the algorithms that implement the relational
algebra, including an interpreter that can evaluate queries without
compilation;
* about 35 bug fixes.

Since the previous release we have re-organized the code into the
org.apache.calcite namespace; the release notes describe how to
migrate code that used the old APIs.

Since RC2 we have fixed issue CALCITE-582.

You can read the release notes here:
https://github.com/apache/incubator-calcite/blob/branch-1.0/doc/HISTORY.md

The commit to be voted upon:
http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/2dd83f21784c4366df84a3aaa62a8b7b0e36d443

Its hash is 2dd83f21784c4366df84a3aaa62a8b7b0e36d443.

The artifacts to be voted on are located here:
http://people.apache.org/~jhyde/apache-calcite-1.0.0-incubating-rc3/

The hashes of the artifacts are as follows:
src.tar.gz.md5 cf64a9421c38959fec9b1802ae39dc66
src.tar.gz.sha1 e1c06d30622e9c16f738d09f1339d60d0388fc62
src.zip.md5 dd389c4c377647fd204a9a3ad83f199a
src.zip.sha1 5ff3b828cb4ea419afa393b7a9f11a294c682a49

A staged Maven repository is available for review at:
https://repository.apache.org/content/repositories/orgapachecalcite-1004

Release artifacts are signed with the following key:
https://people.apache.org/keys/committer/jhyde.asc

Please vote on releasing this package as Apache Calcite 1.0.0-incubating.

The vote is open for the next 72 hours and passes if a majority of
at least three +1 PPMC votes are cast.

[ ] +1 Release this package as Apache Calcite 1.0.0-incubating
[ ]  0 I don't feel strongly about it, but I'm okay with the release
[ ] -1 Do not release this package because...


Here is my vote:

+1 (binding)

Julian

Re: [VOTE] Release apache-calcite-1.0.0-incubating (release candidate 3)

Posted by Jacques Nadeau <ja...@apache.org>.
Success on Linux.

+1 on the release.

On Tue, Feb 3, 2015 at 3:45 PM, Julian Hyde <ju...@hydromatic.net> wrote:

> I just tried "mvn clean && mvn install" using 1.7.0_04 and it worked OK --
> so maybe it's not your JDK. In any case, if you can get it to work by
> setting MAVEN_OPTS I wouldn't consider it a show-stopper.
>
> > On Feb 3, 2015, at 2:50 PM, Jacques Nadeau <ja...@apache.org> wrote:
> >
> > Hmm.. Still getting it even with clean and install run separately.  Maybe
> > because I use an old Java on my verification machine (on purpose :)
> >
> > #java -version
> > java version "1.7.0_09"
> > Java(TM) SE Runtime Environment (build 1.7.0_09-b05)
> > Java HotSpot(TM) 64-Bit Server VM (build 23.5-b02, mixed mode)
> >
> > Let me try something more recent.
> >
> > On Tue, Feb 3, 2015 at 12:33 PM, Julian Hyde <jh...@apache.org> wrote:
> >
> >> I've not seen that. And I'm running on a MacBook Air with a mere 4GB
> >> memory, and I have not set MAVEN_OPTS.
> >>
> >> However, the recommended build command is "mvn clean && mvn install".
> >> See https://issues.apache.org/jira/browse/CALCITE-553 for details.
> >>
> >> Julian
> >>
> >> On Tue, Feb 3, 2015 at 12:27 PM, Jacques Nadeau <ja...@apache.org>
> >> wrote:
> >>> Running mvn clean install on this release artifact, I got out of memory
> >>> exception.  Running again to see if transient.  Any others seeing this?
> >>>
> >>> On Tue, Feb 3, 2015 at 11:10 AM, James Taylor <ja...@apache.org>
> >>> wrote:
> >>>
> >>>> +1. Ran the same tests as before and everything worked well.
> >>>>
> >>>> Thanks,
> >>>> James
> >>>>
> >>>> On Mon, Feb 2, 2015 at 11:05 AM, Julian Hyde <ju...@gmail.com>
> >> wrote:
> >>>>> Yes, CALCITE-582 is fixed. It says so in the commit log, the release
> >>>> notes and the RC3 vote email.
> >>>>>
> >>>>> Re Jacques’ comments: I have not marked it fixed because I have not
> >>>> merged it to master yet. When incorporating Vladimir’s patch I had to
> >> make
> >>>> some other changes to make ScannableTableTest.testSimple pass.
> >>>>>
> >>>>> I have not had chance to look at CALCITE-580 yet. I do not think it
> is
> >>>> fixed, and I do not consider it a show-stopper for the release.
> >>>>>
> >>>>> Julian
> >>>>>
> >>>>> Chin Wei Low is running into a different issue, probably
> >>>>> On Feb 1, 2015, at 7:05 PM, Jacques Nadeau <ja...@apache.org>
> >> wrote:
> >>>>>
> >>>>>> I'm actually a bit confused on this.  The branch-1.0 shows that
> >>>> CALCITE-582
> >>>>>> was merged but I don't see it marked resolved nor a +1.  It also
> >> looks
> >>>> like
> >>>>>> Vladimir was the author but he doesn't like the fix.
> >>>>>>
> >>>>>> On Sun, Feb 1, 2015 at 5:33 PM, Chin Wei Low <lo...@gmail.com>
> >>>> wrote:
> >>>>>>
> >>>>>>> Hi,
> >>>>>>>
> >>>>>>> Did issue 582 fixed?
> >>>>>>>
> >>>>>>> Testing with query like this: select a from abc
> >>>>>>> But, it throw the exception.
> >>>>>>> Exception in thread "main" java.lang.ClassCastException:
> >>>>>>> [Ljava.lang.Object; incompatible with java.lang.Integer
> >>>>>>> at
> >>>>>>>
> >>>>>>>
> >>>>
> >>
> org.apache.calcite.avatica.util.AbstractCursor$IntAccessor.getInt(AbstractCursor.java:460)
> >>>>>>> at
> >>>>>>>
> >>>>>>>
> >>>>
> >>
> org.apache.calcite.avatica.AvaticaResultSet.getInt(AvaticaResultSet.java:311)
> >>>>>>>
> >>>>>>> On Mon, Feb 2, 2015 at 12:37 AM, Vladimir Sitnikov <
> >>>>>>> sitnikov.vladimir@gmail.com> wrote:
> >>>>>>>
> >>>>>>>>> I needed to fix the bug and get a release out with the minimum
> >>>>>>>> of disruption
> >>>>>>>>
> >>>>>>>> I see, however I raised the question since this area clearly is
> >>>>>>>> related to public API.
> >>>>>>>> I do not like "just fix the bug" approach without agreed APIs.
> >>>>>>>>
> >>>>>>>>> CALCITE-558. Please get involved
> >>>>>>>>
> >>>>>>>> Well, I try to block/prevent one more non-required convention to
> >>>> appear.
> >>>>>>>>
> >>>>>>>> Vladimir
> >>>>>>>>
> >>>>>>>
> >>>>>
> >>>>
> >>
>
>

Re: [VOTE] Release apache-calcite-1.0.0-incubating (release candidate 3)

Posted by Julian Hyde <ju...@hydromatic.net>.
I just tried "mvn clean && mvn install" using 1.7.0_04 and it worked OK -- so maybe it's not your JDK. In any case, if you can get it to work by setting MAVEN_OPTS I wouldn't consider it a show-stopper.

> On Feb 3, 2015, at 2:50 PM, Jacques Nadeau <ja...@apache.org> wrote:
> 
> Hmm.. Still getting it even with clean and install run separately.  Maybe
> because I use an old Java on my verification machine (on purpose :)
> 
> #java -version
> java version "1.7.0_09"
> Java(TM) SE Runtime Environment (build 1.7.0_09-b05)
> Java HotSpot(TM) 64-Bit Server VM (build 23.5-b02, mixed mode)
> 
> Let me try something more recent.
> 
> On Tue, Feb 3, 2015 at 12:33 PM, Julian Hyde <jh...@apache.org> wrote:
> 
>> I've not seen that. And I'm running on a MacBook Air with a mere 4GB
>> memory, and I have not set MAVEN_OPTS.
>> 
>> However, the recommended build command is "mvn clean && mvn install".
>> See https://issues.apache.org/jira/browse/CALCITE-553 for details.
>> 
>> Julian
>> 
>> On Tue, Feb 3, 2015 at 12:27 PM, Jacques Nadeau <ja...@apache.org>
>> wrote:
>>> Running mvn clean install on this release artifact, I got out of memory
>>> exception.  Running again to see if transient.  Any others seeing this?
>>> 
>>> On Tue, Feb 3, 2015 at 11:10 AM, James Taylor <ja...@apache.org>
>>> wrote:
>>> 
>>>> +1. Ran the same tests as before and everything worked well.
>>>> 
>>>> Thanks,
>>>> James
>>>> 
>>>> On Mon, Feb 2, 2015 at 11:05 AM, Julian Hyde <ju...@gmail.com>
>> wrote:
>>>>> Yes, CALCITE-582 is fixed. It says so in the commit log, the release
>>>> notes and the RC3 vote email.
>>>>> 
>>>>> Re Jacques’ comments: I have not marked it fixed because I have not
>>>> merged it to master yet. When incorporating Vladimir’s patch I had to
>> make
>>>> some other changes to make ScannableTableTest.testSimple pass.
>>>>> 
>>>>> I have not had chance to look at CALCITE-580 yet. I do not think it is
>>>> fixed, and I do not consider it a show-stopper for the release.
>>>>> 
>>>>> Julian
>>>>> 
>>>>> Chin Wei Low is running into a different issue, probably
>>>>> On Feb 1, 2015, at 7:05 PM, Jacques Nadeau <ja...@apache.org>
>> wrote:
>>>>> 
>>>>>> I'm actually a bit confused on this.  The branch-1.0 shows that
>>>> CALCITE-582
>>>>>> was merged but I don't see it marked resolved nor a +1.  It also
>> looks
>>>> like
>>>>>> Vladimir was the author but he doesn't like the fix.
>>>>>> 
>>>>>> On Sun, Feb 1, 2015 at 5:33 PM, Chin Wei Low <lo...@gmail.com>
>>>> wrote:
>>>>>> 
>>>>>>> Hi,
>>>>>>> 
>>>>>>> Did issue 582 fixed?
>>>>>>> 
>>>>>>> Testing with query like this: select a from abc
>>>>>>> But, it throw the exception.
>>>>>>> Exception in thread "main" java.lang.ClassCastException:
>>>>>>> [Ljava.lang.Object; incompatible with java.lang.Integer
>>>>>>> at
>>>>>>> 
>>>>>>> 
>>>> 
>> org.apache.calcite.avatica.util.AbstractCursor$IntAccessor.getInt(AbstractCursor.java:460)
>>>>>>> at
>>>>>>> 
>>>>>>> 
>>>> 
>> org.apache.calcite.avatica.AvaticaResultSet.getInt(AvaticaResultSet.java:311)
>>>>>>> 
>>>>>>> On Mon, Feb 2, 2015 at 12:37 AM, Vladimir Sitnikov <
>>>>>>> sitnikov.vladimir@gmail.com> wrote:
>>>>>>> 
>>>>>>>>> I needed to fix the bug and get a release out with the minimum
>>>>>>>> of disruption
>>>>>>>> 
>>>>>>>> I see, however I raised the question since this area clearly is
>>>>>>>> related to public API.
>>>>>>>> I do not like "just fix the bug" approach without agreed APIs.
>>>>>>>> 
>>>>>>>>> CALCITE-558. Please get involved
>>>>>>>> 
>>>>>>>> Well, I try to block/prevent one more non-required convention to
>>>> appear.
>>>>>>>> 
>>>>>>>> Vladimir
>>>>>>>> 
>>>>>>> 
>>>>> 
>>>> 
>>

Re: [VOTE] Release apache-calcite-1.0.0-incubating (release candidate 3)

Posted by Jacques Nadeau <ja...@apache.org>.
Hmm.. Still getting it even with clean and install run separately.  Maybe
because I use an old Java on my verification machine (on purpose :)

#java -version
java version "1.7.0_09"
Java(TM) SE Runtime Environment (build 1.7.0_09-b05)
Java HotSpot(TM) 64-Bit Server VM (build 23.5-b02, mixed mode)

Let me try something more recent.

On Tue, Feb 3, 2015 at 12:33 PM, Julian Hyde <jh...@apache.org> wrote:

> I've not seen that. And I'm running on a MacBook Air with a mere 4GB
> memory, and I have not set MAVEN_OPTS.
>
> However, the recommended build command is "mvn clean && mvn install".
> See https://issues.apache.org/jira/browse/CALCITE-553 for details.
>
> Julian
>
> On Tue, Feb 3, 2015 at 12:27 PM, Jacques Nadeau <ja...@apache.org>
> wrote:
> > Running mvn clean install on this release artifact, I got out of memory
> > exception.  Running again to see if transient.  Any others seeing this?
> >
> > On Tue, Feb 3, 2015 at 11:10 AM, James Taylor <ja...@apache.org>
> > wrote:
> >
> >> +1. Ran the same tests as before and everything worked well.
> >>
> >> Thanks,
> >> James
> >>
> >> On Mon, Feb 2, 2015 at 11:05 AM, Julian Hyde <ju...@gmail.com>
> wrote:
> >> > Yes, CALCITE-582 is fixed. It says so in the commit log, the release
> >> notes and the RC3 vote email.
> >> >
> >> > Re Jacques’ comments: I have not marked it fixed because I have not
> >> merged it to master yet. When incorporating Vladimir’s patch I had to
> make
> >> some other changes to make ScannableTableTest.testSimple pass.
> >> >
> >> > I have not had chance to look at CALCITE-580 yet. I do not think it is
> >> fixed, and I do not consider it a show-stopper for the release.
> >> >
> >> > Julian
> >> >
> >> > Chin Wei Low is running into a different issue, probably
> >> > On Feb 1, 2015, at 7:05 PM, Jacques Nadeau <ja...@apache.org>
> wrote:
> >> >
> >> >> I'm actually a bit confused on this.  The branch-1.0 shows that
> >> CALCITE-582
> >> >> was merged but I don't see it marked resolved nor a +1.  It also
> looks
> >> like
> >> >> Vladimir was the author but he doesn't like the fix.
> >> >>
> >> >> On Sun, Feb 1, 2015 at 5:33 PM, Chin Wei Low <lo...@gmail.com>
> >> wrote:
> >> >>
> >> >>> Hi,
> >> >>>
> >> >>> Did issue 582 fixed?
> >> >>>
> >> >>> Testing with query like this: select a from abc
> >> >>> But, it throw the exception.
> >> >>> Exception in thread "main" java.lang.ClassCastException:
> >> >>> [Ljava.lang.Object; incompatible with java.lang.Integer
> >> >>> at
> >> >>>
> >> >>>
> >>
> org.apache.calcite.avatica.util.AbstractCursor$IntAccessor.getInt(AbstractCursor.java:460)
> >> >>> at
> >> >>>
> >> >>>
> >>
> org.apache.calcite.avatica.AvaticaResultSet.getInt(AvaticaResultSet.java:311)
> >> >>>
> >> >>> On Mon, Feb 2, 2015 at 12:37 AM, Vladimir Sitnikov <
> >> >>> sitnikov.vladimir@gmail.com> wrote:
> >> >>>
> >> >>>>> I needed to fix the bug and get a release out with the minimum
> >> >>>> of disruption
> >> >>>>
> >> >>>> I see, however I raised the question since this area clearly is
> >> >>>> related to public API.
> >> >>>> I do not like "just fix the bug" approach without agreed APIs.
> >> >>>>
> >> >>>>> CALCITE-558. Please get involved
> >> >>>>
> >> >>>> Well, I try to block/prevent one more non-required convention to
> >> appear.
> >> >>>>
> >> >>>> Vladimir
> >> >>>>
> >> >>>
> >> >
> >>
>

Re: [VOTE] Release apache-calcite-1.0.0-incubating (release candidate 3)

Posted by Julian Hyde <jh...@apache.org>.
I've not seen that. And I'm running on a MacBook Air with a mere 4GB
memory, and I have not set MAVEN_OPTS.

However, the recommended build command is "mvn clean && mvn install".
See https://issues.apache.org/jira/browse/CALCITE-553 for details.

Julian

On Tue, Feb 3, 2015 at 12:27 PM, Jacques Nadeau <ja...@apache.org> wrote:
> Running mvn clean install on this release artifact, I got out of memory
> exception.  Running again to see if transient.  Any others seeing this?
>
> On Tue, Feb 3, 2015 at 11:10 AM, James Taylor <ja...@apache.org>
> wrote:
>
>> +1. Ran the same tests as before and everything worked well.
>>
>> Thanks,
>> James
>>
>> On Mon, Feb 2, 2015 at 11:05 AM, Julian Hyde <ju...@gmail.com> wrote:
>> > Yes, CALCITE-582 is fixed. It says so in the commit log, the release
>> notes and the RC3 vote email.
>> >
>> > Re Jacques’ comments: I have not marked it fixed because I have not
>> merged it to master yet. When incorporating Vladimir’s patch I had to make
>> some other changes to make ScannableTableTest.testSimple pass.
>> >
>> > I have not had chance to look at CALCITE-580 yet. I do not think it is
>> fixed, and I do not consider it a show-stopper for the release.
>> >
>> > Julian
>> >
>> > Chin Wei Low is running into a different issue, probably
>> > On Feb 1, 2015, at 7:05 PM, Jacques Nadeau <ja...@apache.org> wrote:
>> >
>> >> I'm actually a bit confused on this.  The branch-1.0 shows that
>> CALCITE-582
>> >> was merged but I don't see it marked resolved nor a +1.  It also looks
>> like
>> >> Vladimir was the author but he doesn't like the fix.
>> >>
>> >> On Sun, Feb 1, 2015 at 5:33 PM, Chin Wei Low <lo...@gmail.com>
>> wrote:
>> >>
>> >>> Hi,
>> >>>
>> >>> Did issue 582 fixed?
>> >>>
>> >>> Testing with query like this: select a from abc
>> >>> But, it throw the exception.
>> >>> Exception in thread "main" java.lang.ClassCastException:
>> >>> [Ljava.lang.Object; incompatible with java.lang.Integer
>> >>> at
>> >>>
>> >>>
>> org.apache.calcite.avatica.util.AbstractCursor$IntAccessor.getInt(AbstractCursor.java:460)
>> >>> at
>> >>>
>> >>>
>> org.apache.calcite.avatica.AvaticaResultSet.getInt(AvaticaResultSet.java:311)
>> >>>
>> >>> On Mon, Feb 2, 2015 at 12:37 AM, Vladimir Sitnikov <
>> >>> sitnikov.vladimir@gmail.com> wrote:
>> >>>
>> >>>>> I needed to fix the bug and get a release out with the minimum
>> >>>> of disruption
>> >>>>
>> >>>> I see, however I raised the question since this area clearly is
>> >>>> related to public API.
>> >>>> I do not like "just fix the bug" approach without agreed APIs.
>> >>>>
>> >>>>> CALCITE-558. Please get involved
>> >>>>
>> >>>> Well, I try to block/prevent one more non-required convention to
>> appear.
>> >>>>
>> >>>> Vladimir
>> >>>>
>> >>>
>> >
>>

Re: [VOTE] Release apache-calcite-1.0.0-incubating (release candidate 3)

Posted by Jacques Nadeau <ja...@apache.org>.
Running mvn clean install on this release artifact, I got out of memory
exception.  Running again to see if transient.  Any others seeing this?

On Tue, Feb 3, 2015 at 11:10 AM, James Taylor <ja...@apache.org>
wrote:

> +1. Ran the same tests as before and everything worked well.
>
> Thanks,
> James
>
> On Mon, Feb 2, 2015 at 11:05 AM, Julian Hyde <ju...@gmail.com> wrote:
> > Yes, CALCITE-582 is fixed. It says so in the commit log, the release
> notes and the RC3 vote email.
> >
> > Re Jacques’ comments: I have not marked it fixed because I have not
> merged it to master yet. When incorporating Vladimir’s patch I had to make
> some other changes to make ScannableTableTest.testSimple pass.
> >
> > I have not had chance to look at CALCITE-580 yet. I do not think it is
> fixed, and I do not consider it a show-stopper for the release.
> >
> > Julian
> >
> > Chin Wei Low is running into a different issue, probably
> > On Feb 1, 2015, at 7:05 PM, Jacques Nadeau <ja...@apache.org> wrote:
> >
> >> I'm actually a bit confused on this.  The branch-1.0 shows that
> CALCITE-582
> >> was merged but I don't see it marked resolved nor a +1.  It also looks
> like
> >> Vladimir was the author but he doesn't like the fix.
> >>
> >> On Sun, Feb 1, 2015 at 5:33 PM, Chin Wei Low <lo...@gmail.com>
> wrote:
> >>
> >>> Hi,
> >>>
> >>> Did issue 582 fixed?
> >>>
> >>> Testing with query like this: select a from abc
> >>> But, it throw the exception.
> >>> Exception in thread "main" java.lang.ClassCastException:
> >>> [Ljava.lang.Object; incompatible with java.lang.Integer
> >>> at
> >>>
> >>>
> org.apache.calcite.avatica.util.AbstractCursor$IntAccessor.getInt(AbstractCursor.java:460)
> >>> at
> >>>
> >>>
> org.apache.calcite.avatica.AvaticaResultSet.getInt(AvaticaResultSet.java:311)
> >>>
> >>> On Mon, Feb 2, 2015 at 12:37 AM, Vladimir Sitnikov <
> >>> sitnikov.vladimir@gmail.com> wrote:
> >>>
> >>>>> I needed to fix the bug and get a release out with the minimum
> >>>> of disruption
> >>>>
> >>>> I see, however I raised the question since this area clearly is
> >>>> related to public API.
> >>>> I do not like "just fix the bug" approach without agreed APIs.
> >>>>
> >>>>> CALCITE-558. Please get involved
> >>>>
> >>>> Well, I try to block/prevent one more non-required convention to
> appear.
> >>>>
> >>>> Vladimir
> >>>>
> >>>
> >
>

Re: [VOTE] Release apache-calcite-1.0.0-incubating (release candidate 3)

Posted by James Taylor <ja...@apache.org>.
+1. Ran the same tests as before and everything worked well.

Thanks,
James

On Mon, Feb 2, 2015 at 11:05 AM, Julian Hyde <ju...@gmail.com> wrote:
> Yes, CALCITE-582 is fixed. It says so in the commit log, the release notes and the RC3 vote email.
>
> Re Jacques’ comments: I have not marked it fixed because I have not merged it to master yet. When incorporating Vladimir’s patch I had to make some other changes to make ScannableTableTest.testSimple pass.
>
> I have not had chance to look at CALCITE-580 yet. I do not think it is fixed, and I do not consider it a show-stopper for the release.
>
> Julian
>
> Chin Wei Low is running into a different issue, probably
> On Feb 1, 2015, at 7:05 PM, Jacques Nadeau <ja...@apache.org> wrote:
>
>> I'm actually a bit confused on this.  The branch-1.0 shows that CALCITE-582
>> was merged but I don't see it marked resolved nor a +1.  It also looks like
>> Vladimir was the author but he doesn't like the fix.
>>
>> On Sun, Feb 1, 2015 at 5:33 PM, Chin Wei Low <lo...@gmail.com> wrote:
>>
>>> Hi,
>>>
>>> Did issue 582 fixed?
>>>
>>> Testing with query like this: select a from abc
>>> But, it throw the exception.
>>> Exception in thread "main" java.lang.ClassCastException:
>>> [Ljava.lang.Object; incompatible with java.lang.Integer
>>> at
>>>
>>> org.apache.calcite.avatica.util.AbstractCursor$IntAccessor.getInt(AbstractCursor.java:460)
>>> at
>>>
>>> org.apache.calcite.avatica.AvaticaResultSet.getInt(AvaticaResultSet.java:311)
>>>
>>> On Mon, Feb 2, 2015 at 12:37 AM, Vladimir Sitnikov <
>>> sitnikov.vladimir@gmail.com> wrote:
>>>
>>>>> I needed to fix the bug and get a release out with the minimum
>>>> of disruption
>>>>
>>>> I see, however I raised the question since this area clearly is
>>>> related to public API.
>>>> I do not like "just fix the bug" approach without agreed APIs.
>>>>
>>>>> CALCITE-558. Please get involved
>>>>
>>>> Well, I try to block/prevent one more non-required convention to appear.
>>>>
>>>> Vladimir
>>>>
>>>
>

Re: [VOTE] Release apache-calcite-1.0.0-incubating (release candidate 3)

Posted by Julian Hyde <ju...@gmail.com>.
Yes, CALCITE-582 is fixed. It says so in the commit log, the release notes and the RC3 vote email.

Re Jacques’ comments: I have not marked it fixed because I have not merged it to master yet. When incorporating Vladimir’s patch I had to make some other changes to make ScannableTableTest.testSimple pass.

I have not had chance to look at CALCITE-580 yet. I do not think it is fixed, and I do not consider it a show-stopper for the release.

Julian

Chin Wei Low is running into a different issue, probably 
On Feb 1, 2015, at 7:05 PM, Jacques Nadeau <ja...@apache.org> wrote:

> I'm actually a bit confused on this.  The branch-1.0 shows that CALCITE-582
> was merged but I don't see it marked resolved nor a +1.  It also looks like
> Vladimir was the author but he doesn't like the fix.
> 
> On Sun, Feb 1, 2015 at 5:33 PM, Chin Wei Low <lo...@gmail.com> wrote:
> 
>> Hi,
>> 
>> Did issue 582 fixed?
>> 
>> Testing with query like this: select a from abc
>> But, it throw the exception.
>> Exception in thread "main" java.lang.ClassCastException:
>> [Ljava.lang.Object; incompatible with java.lang.Integer
>> at
>> 
>> org.apache.calcite.avatica.util.AbstractCursor$IntAccessor.getInt(AbstractCursor.java:460)
>> at
>> 
>> org.apache.calcite.avatica.AvaticaResultSet.getInt(AvaticaResultSet.java:311)
>> 
>> On Mon, Feb 2, 2015 at 12:37 AM, Vladimir Sitnikov <
>> sitnikov.vladimir@gmail.com> wrote:
>> 
>>>> I needed to fix the bug and get a release out with the minimum
>>> of disruption
>>> 
>>> I see, however I raised the question since this area clearly is
>>> related to public API.
>>> I do not like "just fix the bug" approach without agreed APIs.
>>> 
>>>> CALCITE-558. Please get involved
>>> 
>>> Well, I try to block/prevent one more non-required convention to appear.
>>> 
>>> Vladimir
>>> 
>>

Re: [VOTE] Release apache-calcite-1.0.0-incubating (release candidate 3)

Posted by Jacques Nadeau <ja...@apache.org>.
I'm actually a bit confused on this.  The branch-1.0 shows that CALCITE-582
was merged but I don't see it marked resolved nor a +1.  It also looks like
Vladimir was the author but he doesn't like the fix.

On Sun, Feb 1, 2015 at 5:33 PM, Chin Wei Low <lo...@gmail.com> wrote:

> Hi,
>
> Did issue 582 fixed?
>
> Testing with query like this: select a from abc
> But, it throw the exception.
> Exception in thread "main" java.lang.ClassCastException:
> [Ljava.lang.Object; incompatible with java.lang.Integer
> at
>
> org.apache.calcite.avatica.util.AbstractCursor$IntAccessor.getInt(AbstractCursor.java:460)
> at
>
> org.apache.calcite.avatica.AvaticaResultSet.getInt(AvaticaResultSet.java:311)
>
> On Mon, Feb 2, 2015 at 12:37 AM, Vladimir Sitnikov <
> sitnikov.vladimir@gmail.com> wrote:
>
> > > I needed to fix the bug and get a release out with the minimum
> > of disruption
> >
> > I see, however I raised the question since this area clearly is
> > related to public API.
> > I do not like "just fix the bug" approach without agreed APIs.
> >
> > >CALCITE-558. Please get involved
> >
> > Well, I try to block/prevent one more non-required convention to appear.
> >
> > Vladimir
> >
>

Re: [VOTE] Release apache-calcite-1.0.0-incubating (release candidate 3)

Posted by Vladimir Sitnikov <si...@gmail.com>.
> single column -> return Object
> more than 1 column -> return Object[]

This is the intended behavior for 'queryable' table.
For Scannable/Projectable it is always Object[].

I would like to have more clear API for that, however I think it can wait
for 1.1.0 or so.

Vladimir

Re: [VOTE] Release apache-calcite-1.0.0-incubating (release candidate 3)

Posted by Chin Wei Low <lo...@gmail.com>.
I think I know why, my enumerator need to return an object, i.e. Integer
for single column result instead of array of Object. So,
single column -> return Object
more than 1 column -> return Object[]

Is this the intended behaviour?

On Mon, Feb 2, 2015 at 4:52 PM, Vladimir Sitnikov <
sitnikov.vladimir@gmail.com> wrote:

> > Exception in thread "main" java.lang.ClassCastException:
> > [Ljava.lang.Object; incompatible with java.lang.Integer
>
> Can you reproduce in Calcite test data or show your table's code?
>
> Vladimir
>

Re: [VOTE] Release apache-calcite-1.0.0-incubating (release candidate 3)

Posted by Vladimir Sitnikov <si...@gmail.com>.
> Exception in thread "main" java.lang.ClassCastException:
> [Ljava.lang.Object; incompatible with java.lang.Integer

Can you reproduce in Calcite test data or show your table's code?

Vladimir

Re: [VOTE] Release apache-calcite-1.0.0-incubating (release candidate 3)

Posted by Chin Wei Low <lo...@gmail.com>.
Hi,

Did issue 582 fixed?

Testing with query like this: select a from abc
But, it throw the exception.
Exception in thread "main" java.lang.ClassCastException:
[Ljava.lang.Object; incompatible with java.lang.Integer
at
org.apache.calcite.avatica.util.AbstractCursor$IntAccessor.getInt(AbstractCursor.java:460)
at
org.apache.calcite.avatica.AvaticaResultSet.getInt(AvaticaResultSet.java:311)

On Mon, Feb 2, 2015 at 12:37 AM, Vladimir Sitnikov <
sitnikov.vladimir@gmail.com> wrote:

> > I needed to fix the bug and get a release out with the minimum
> of disruption
>
> I see, however I raised the question since this area clearly is
> related to public API.
> I do not like "just fix the bug" approach without agreed APIs.
>
> >CALCITE-558. Please get involved
>
> Well, I try to block/prevent one more non-required convention to appear.
>
> Vladimir
>

Re: [VOTE] Release apache-calcite-1.0.0-incubating (release candidate 3)

Posted by Vladimir Sitnikov <si...@gmail.com>.
> I needed to fix the bug and get a release out with the minimum
of disruption

I see, however I raised the question since this area clearly is
related to public API.
I do not like "just fix the bug" approach without agreed APIs.

>CALCITE-558. Please get involved

Well, I try to block/prevent one more non-required convention to appear.

Vladimir

Re: [VOTE] Release apache-calcite-1.0.0-incubating (release candidate 3)

Posted by Julian Hyde <ju...@gmail.com>.
Agreed. I needed to fix the bug and get a release out with the minimum
of disruption. There is an opportunity to do better as part of
https://issues.apache.org/jira/browse/CALCITE-558. Please get involved
in that.

Julian

On Sun, Feb 1, 2015 at 5:00 AM, Vladimir Sitnikov
<si...@gmail.com> wrote:
> +1. It compiles, and works for me.
>
> Julian,
>
> While your fix for 582 works, I do not like how it is implemented.
>
> If you suggest that *ableTable should always return Object[], then you
> should express that in email/ticket or at least in
> org.apache.calcite.adapter.enumerable.EnumerableTableScan#format.
>
> return ---> table.unwrap(QueryableTable.class) != null <--- &&
> fieldCount == 1 ? JavaRowFormat.SCALAR : JavaRowFormat.ARRAY;
>
> Vladimir

Re: [VOTE] Release apache-calcite-1.0.0-incubating (release candidate 3)

Posted by Vladimir Sitnikov <si...@gmail.com>.
+1. It compiles, and works for me.

Julian,

While your fix for 582 works, I do not like how it is implemented.

If you suggest that *ableTable should always return Object[], then you
should express that in email/ticket or at least in
org.apache.calcite.adapter.enumerable.EnumerableTableScan#format.

return ---> table.unwrap(QueryableTable.class) != null <--- &&
fieldCount == 1 ? JavaRowFormat.SCALAR : JavaRowFormat.ARRAY;

Vladimir

Re: [VOTE] Release apache-calcite-1.0.0-incubating (release candidate 3)

Posted by Brock Noland <br...@cloudera.com>.
I tested the patch with Hive with HIVE-9454 applied and it fixed the
failures we were seeing.

+1 (non-binding)

On Sat, Jan 31, 2015 at 8:54 PM, Julian Hyde <jh...@apache.org> wrote:

> Hi all,
>
> I have created a build for Apache Calcite 1.0.0-incubating, release
> candidate 3.
>
> Thanks to everyone who has contributed to this release.
>
> This is Calcite's first major release. The release adds:
> * SQL support for GROUPING SETS, EXTEND, UPSERT and sequences;
> * a remote JDBC driver;
> * improvements to the planner engine and built-in planner rules;
> * improvements to the algorithms that implement the relational
> algebra, including an interpreter that can evaluate queries without
> compilation;
> * about 35 bug fixes.
>
> Since the previous release we have re-organized the code into the
> org.apache.calcite namespace; the release notes describe how to
> migrate code that used the old APIs.
>
> Since RC2 we have fixed issue CALCITE-582.
>
> You can read the release notes here:
> https://github.com/apache/incubator-calcite/blob/branch-1.0/doc/HISTORY.md
>
> The commit to be voted upon:
>
> http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/2dd83f21784c4366df84a3aaa62a8b7b0e36d443
>
> Its hash is 2dd83f21784c4366df84a3aaa62a8b7b0e36d443.
>
> The artifacts to be voted on are located here:
> http://people.apache.org/~jhyde/apache-calcite-1.0.0-incubating-rc3/
>
> The hashes of the artifacts are as follows:
> src.tar.gz.md5 cf64a9421c38959fec9b1802ae39dc66
> src.tar.gz.sha1 e1c06d30622e9c16f738d09f1339d60d0388fc62
> src.zip.md5 dd389c4c377647fd204a9a3ad83f199a
> src.zip.sha1 5ff3b828cb4ea419afa393b7a9f11a294c682a49
>
> A staged Maven repository is available for review at:
> https://repository.apache.org/content/repositories/orgapachecalcite-1004
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/jhyde.asc
>
> Please vote on releasing this package as Apache Calcite 1.0.0-incubating.
>
> The vote is open for the next 72 hours and passes if a majority of
> at least three +1 PPMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.0.0-incubating
> [ ]  0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
>
> Here is my vote:
>
> +1 (binding)
>
> Julian
>