You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/07 07:29:14 UTC

[GitHub] [airflow] tooptoop4 commented on a change in pull request #6342: [AIRFLOW-5662] fix incorrect naming for scheduler used slot metric

tooptoop4 commented on a change in pull request #6342: [AIRFLOW-5662] fix incorrect naming for scheduler used slot metric
URL: https://github.com/apache/airflow/pull/6342#discussion_r363619884
 
 

 ##########
 File path: airflow/jobs/scheduler_job.py
 ##########
 @@ -1568,15 +1567,18 @@ def _execute_helper(self):
                 self.heartbeat()
                 last_self_heartbeat_time = timezone.utcnow()
 
+            self._collect_metrics()
+
             loop_end_time = time.time()
             loop_duration = loop_end_time - loop_start_time
             self.log.debug(
                 "Ran scheduling loop in %.2f seconds",
                 loop_duration)
 
+            is_unit_test = conf.getboolean('core', 'unit_test_mode')
 
 Review comment:
   don't add this line, its already defined earlier

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services