You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Sahil Takiar (Code Review)" <ge...@cloudera.org> on 2019/08/06 21:52:24 UTC
[Impala-ASF-CR] IMPALA-8781: Fix TestResultSpooling::test multi batches
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14022
Change subject: IMPALA-8781: Fix TestResultSpooling::test_multi_batches
......................................................................
IMPALA-8781: Fix TestResultSpooling::test_multi_batches
Prefix the query in TestResultSpooling::test_multi_batches with the
database name. This was causing the Dockerized tests to fail. I double
checked what other tests do and all the ones I saw either switch to the
appropriate database or prefix the table name using the database name.
The latter seemed more straightforward.
I was not able to re-produce this locally, and its odd that this only
affected the Dockerized tests (even more odd is that it seems to either
be intermittent, or only affecting Dockerized tests triggered by
gerrit-verify-dryrun-external). Regardless, it is a straightforward fix
that makes the TestResultSpooling::test_multi_batches consistent with
the rest of the tests.
Testing:
* Ran test_result_spooling.py locally using both bin/impala-py.test
and tests/run-tests.py.
Change-Id: I939eedba37003f5c720cea96e5c3532e2cc6312c
---
M tests/query_test/test_result_spooling.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/14022/1
--
To view, visit http://gerrit.cloudera.org:8080/14022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I939eedba37003f5c720cea96e5c3532e2cc6312c
Gerrit-Change-Number: 14022
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
[Impala-ASF-CR] IMPALA-8781: Fix TestResultSpooling::test multi batches
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14022 )
Change subject: IMPALA-8781: Fix TestResultSpooling::test_multi_batches
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I939eedba37003f5c720cea96e5c3532e2cc6312c
Gerrit-Change-Number: 14022
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Aug 2019 04:06:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8781: Fix TestResultSpooling::test multi batches
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14022 )
Change subject: IMPALA-8781: Fix TestResultSpooling::test_multi_batches
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I939eedba37003f5c720cea96e5c3532e2cc6312c
Gerrit-Change-Number: 14022
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Aug 2019 23:57:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8781: Fix TestResultSpooling::test multi batches
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14022 )
Change subject: IMPALA-8781: Fix TestResultSpooling::test_multi_batches
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4163/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I939eedba37003f5c720cea96e5c3532e2cc6312c
Gerrit-Change-Number: 14022
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Aug 2019 22:13:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8781: Fix TestResultSpooling::test multi batches
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14022 )
Change subject: IMPALA-8781: Fix TestResultSpooling::test_multi_batches
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4746/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I939eedba37003f5c720cea96e5c3532e2cc6312c
Gerrit-Change-Number: 14022
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Aug 2019 23:57:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8781: Fix TestResultSpooling::test multi batches
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14022 )
Change subject: IMPALA-8781: Fix TestResultSpooling::test_multi_batches
......................................................................
IMPALA-8781: Fix TestResultSpooling::test_multi_batches
Prefix the query in TestResultSpooling::test_multi_batches with the
database name. This was causing the Dockerized tests to fail. I double
checked what other tests do and all the ones I saw either switch to the
appropriate database or prefix the table name using the database name.
The latter seemed more straightforward.
I was not able to re-produce this locally, and its odd that this only
affected the Dockerized tests (even more odd is that it seems to either
be intermittent, or only affecting Dockerized tests triggered by
gerrit-verify-dryrun-external). Regardless, it is a straightforward fix
that makes the TestResultSpooling::test_multi_batches consistent with
the rest of the tests.
Testing:
* Ran test_result_spooling.py locally using both bin/impala-py.test
and tests/run-tests.py.
Change-Id: I939eedba37003f5c720cea96e5c3532e2cc6312c
Reviewed-on: http://gerrit.cloudera.org:8080/14022
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/query_test/test_result_spooling.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I939eedba37003f5c720cea96e5c3532e2cc6312c
Gerrit-Change-Number: 14022
Gerrit-PatchSet: 3
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8781: Fix TestResultSpooling::test multi batches
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14022 )
Change subject: IMPALA-8781: Fix TestResultSpooling::test_multi_batches
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I939eedba37003f5c720cea96e5c3532e2cc6312c
Gerrit-Change-Number: 14022
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Aug 2019 21:56:28 +0000
Gerrit-HasComments: No