You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Apoorv Naik <na...@gmail.com> on 2017/07/17 21:37:14 UTC

Review Request 60922: ATLAS-1925: Misc bugfixes for ATLAS-1880

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60922/
-----------------------------------------------------------

Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.


Bugs: ATLAS-1925
    https://issues.apache.org/jira/browse/ATLAS-1925


Repository: atlas


Description
-------

Resolves ATLAS-1917, 1922, 1926


Diffs
-----

  repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java a4538bda 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 1a2d997b 


Diff: https://reviews.apache.org/r/60922/diff/1/


Testing
-------

mvn clean package executes successfully


Thanks,

Apoorv Naik


Re: Review Request 60922: ATLAS-1925: Misc bugfixes for ATLAS-1880

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60922/#review180763
-----------------------------------------------------------


Fix it, then Ship it!




Ship It!


repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
Lines 479 (patched)
<https://reviews.apache.org/r/60922/#comment255987>

    keep this inside a finally {} block, to ensure that search-context gets removed when search method exits.


- Madhan Neethiraj


On July 17, 2017, 9:37 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60922/
> -----------------------------------------------------------
> 
> (Updated July 17, 2017, 9:37 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-1925
>     https://issues.apache.org/jira/browse/ATLAS-1925
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Resolves ATLAS-1917, 1922, 1926
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java a4538bda 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 1a2d997b 
> 
> 
> Diff: https://reviews.apache.org/r/60922/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean package executes successfully
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>