You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by "Philippe M. Chiasson" <go...@ectoplasm.org> on 2004/09/16 22:11:42 UTC
[Patch mp2] Suggest renaming Apache::Module $module->version
Stas Bekman wrote:
> Geoffrey Young wrote:
>
>>>>what about just api_version()? I think that sets it apart enough from
>>>>perlish ideas about require() and provides a means to explain the
>>>>exactness
>>>>of the required match.
>>>
>>>
>>>+1 for the exactness, but it's still ambiguous of what api_ it's talking
>>>about. apr API, mod_perl API, perl API, apache API?
>>
>>
>>ok, apache_api_version() then? I'd hate to see it any longer than that.
>
>
> +1
Patch attached.
--
--------------------------------------------------------------------------------
Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5
http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5
Re: [Patch mp2] Suggest renaming Apache::Module $module->version
Posted by Stas Bekman <st...@stason.org>.
Philippe M. Chiasson wrote:
>
>
> Stas Bekman wrote:
>
>> Geoffrey Young wrote:
>>
>>>>> what about just api_version()? I think that sets it apart enough from
>>>>> perlish ideas about require() and provides a means to explain the
>>>>> exactness
>>>>> of the required match.
>>>>
>>>>
>>>>
>>>> +1 for the exactness, but it's still ambiguous of what api_ it's
>>>> talking
>>>> about. apr API, mod_perl API, perl API, apache API?
>>>
>>>
>>>
>>> ok, apache_api_version() then? I'd hate to see it any longer than that.
>>
>>
>>
>> +1
>
>
> Patch attached.
>
>
> ------------------------------------------------------------------------
>
> Index: Changes
> ===================================================================
> RCS file: /home/cvs/modperl-2.0/Changes,v
> retrieving revision 1.485
> diff -u -I$Id -r1.485 Changes
> --- Changes 16 Sep 2004 16:36:28 -0000 1.485
> +++ Changes 16 Sep 2004 20:10:49 -0000
> @@ -12,6 +12,9 @@
>
> =item 1.99_17-dev
>
> +Apache::Module $mod->version() renamed $mod->apache_api_version()
> +for clarity [Gozer]
> +
> Apache::Log changes: [Stas]
> - moved to compat: Apache::warn, Apache->warn, Apache::Server->warn,
> Apache::Server::warn
> Index: t/response/TestAPI/module.pm
> ===================================================================
> RCS file: /home/cvs/modperl-2.0/t/response/TestAPI/module.pm,v
> retrieving revision 1.22
> diff -u -I$Id -r1.22 module.pm
> --- t/response/TestAPI/module.pm 13 Sep 2004 22:36:18 -0000 1.22
> +++ t/response/TestAPI/module.pm 16 Sep 2004 20:10:49 -0000
> @@ -84,7 +84,7 @@
> my $name = $modp->name;
> ok $name;
> t_debug("Testing module: " . $modp->name);
> - ok $modp->version == $mmn_major;
> + ok $modp->apache_api_version == $mmn_major;
> ok $modp->minor_version <= $mmn_minor;
> ok $modp->module_index >= 0;
> my $cmds = $modp->cmds;
while you are at it, change those to use t_cmp to make those tests more
debuggable.
Otherwise looks good
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org