You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/21 19:00:28 UTC

[GitHub] [airflow] DrFaust92 opened a new pull request #21024: OpenApiSpec - DAGRun - make dag_id in body not required

DrFaust92 opened a new pull request #21024:
URL: https://github.com/apache/airflow/pull/21024

<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.

Feel free to ping committers for the review!

In case of existing issue, reference it using one of the following:

related: [#ISSUE](https://github.com/apache/airflow-client-go/issues/9)

How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->

When generating a golang client for the spec and trying to create a DAGRun. it requires the dag_id property in the body which the server refuses. see above linked issue.

Opening for visibility while still testing.
---
**^ Add meaningful description above**

Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #21024: OpenApiSpec - DAGRun - make dag_id in body not required

Posted by GitBox <gi...@apache.org>.

potiuk merged pull request #21024:
URL: https://github.com/apache/airflow/pull/21024


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #21024: OpenApiSpec - DAGRun - make dag_id in body not required

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on pull request #21024:
URL: https://github.com/apache/airflow/pull/21024#issuecomment-1019550987


   The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] DrFaust92 commented on pull request #21024: OpenApiSpec - DAGRun - make dag_id in body not required

Posted by GitBox <gi...@apache.org>.

DrFaust92 commented on pull request #21024:
URL: https://github.com/apache/airflow/pull/21024#issuecomment-1019173161


   @ephraimbuddy, Thanks for the quick response. While I understand this may be an issue with an upstream tool. This makes it impossible to use golang generated client for managing DAG Runs at the moment.
   
   My real question is, does my change break anything and is fundamentally wrong? my feeling (for my current understanding) is that its worth it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #21024: OpenApiSpec - DAGRun - make dag_id in body not required

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #21024:
URL: https://github.com/apache/airflow/pull/21024#issuecomment-1018778804

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ephraimbuddy commented on pull request #21024: OpenApiSpec - DAGRun - make dag_id in body not required

Posted by GitBox <gi...@apache.org>.

ephraimbuddy commented on pull request #21024:
URL: https://github.com/apache/airflow/pull/21024#issuecomment-1019550819


   > @ephraimbuddy, Thanks for the quick response. While I understand this may be an issue with an upstream tool. This makes it impossible to use golang generated client for managing DAG Runs at the moment.
   > 
   > My real question is, does my change break anything and is fundamentally wrong? my feeling (for my current understanding) is that its worth it.
   
   I get your point now. Your code is actually fine. I think there's no harm.
   @mik-laj WDYT


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #21024: OpenApiSpec - DAGRun - make dag_id in body not required

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #21024:
URL: https://github.com/apache/airflow/pull/21024#issuecomment-1019551627


   Awesome work, congrats on your first merged pull request!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org