You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "singhpk234 (via GitHub)" <gi...@apache.org> on 2023/03/20 00:07:10 UTC
[GitHub] [iceberg] singhpk234 commented on a diff in pull request #4479: Spark 3.3: support rate limit in Spark Streaming
singhpk234 commented on code in PR #4479:
URL: https://github.com/apache/iceberg/pull/4479#discussion_r1141507426
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkMicroBatchStream.java:
##########
@@ -200,25 +210,43 @@ private List<FileScanTask> planFiles(StreamingOffset startOffset, StreamingOffse
StreamingOffset currentOffset = null;
+ // [(startOffset : startFileIndex), (endOffset : endFileIndex) )
Review Comment:
added `)` in place of `]` to show the range endOffset is not inclusive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org