[jira] [Comment Edited] (MESOS-6415) Create an unit test for OOM in Mesos containerizer's mem isolator

["Zhitao Li (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-6415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15587117#comment-15587117 ] 

Zhitao Li edited comment on MESOS-6415 at 10/19/16 12:10 AM:
-------------------------------------------------------------

[~jieyu] and I chatted on the containerizer slack, and I exactly want to pursue this as a separate test. 

Slack history:
{quote}
It seems like we don't have any integration test practicing the case of exceeding container memory limit. @jieyu @gilbert ?

Jie Yu [4:43 PM]  
we do have a balloon framework

Zhitao Li [4:44 PM]  
Is it exercised through a test?

Jie Yu [4:44 PM]  
yeah

Gilbert Song [4:44 PM]  
yes,

[4:44]  
through a script in a unit test

Jie Yu [4:44 PM]  
in retrospect, we can simply use a command task

[4:45]  
at the time balloon framework was written, command task does not exist yet

Zhitao Li [4:45 PM]  
I'd volunteer me or someone from our team to write a smaller test, if you want to shepherd (edited)

Jie Yu [4:45 PM]  
yup, i’d be happy to shepherd

[4:45]  
you should add one to cgroups_isolator_tests.cpp

Zhitao Li [4:46 PM]  
Will file an issue and claim it under my umbrella for now. Thanks

Jie Yu [4:46 PM]  
oh

[4:46]  
hold on

[4:46]  
we do have MemoryPressureMesosTest

[4:48]  
but I guess we don’t have a oom test

[4:48]  
memory pressure is mainly for the stats

[4:49]  
yeah, @zhitao, we should add a OOM test
{quote}


was (Author: zhitao):
[~jieyu] and I chatted on the containerizer slack, and I exactly want to pursue this as a separate test. 

Slack history:
```

It seems like we don't have any integration test practicing the case of exceeding container memory limit. @jieyu @gilbert ?

Jie Yu [4:43 PM]  
we do have a balloon framework

Zhitao Li [4:44 PM]  
Is it exercised through a test?

Jie Yu [4:44 PM]  
yeah

Gilbert Song [4:44 PM]  
yes,

[4:44]  
through a script in a unit test

Jie Yu [4:44 PM]  
in retrospect, we can simply use a command task

[4:45]  
at the time balloon framework was written, command task does not exist yet

Zhitao Li [4:45 PM]  
I'd volunteer me or someone from our team to write a smaller test, if you want to shepherd (edited)

Jie Yu [4:45 PM]  
yup, i’d be happy to shepherd

[4:45]  
you should add one to cgroups_isolator_tests.cpp

Zhitao Li [4:46 PM]  
Will file an issue and claim it under my umbrella for now. Thanks

Jie Yu [4:46 PM]  
oh

[4:46]  
hold on

[4:46]  
we do have MemoryPressureMesosTest

[4:48]  
but I guess we don’t have a oom test

[4:48]  
memory pressure is mainly for the stats

[4:49]  
yeah, @zhitao, we should add a OOM test
```

> Create an unit test for OOM in Mesos containerizer's mem isolator
> -----------------------------------------------------------------
>
>                 Key: MESOS-6415
>                 URL: https://issues.apache.org/jira/browse/MESOS-6415
>             Project: Mesos
>          Issue Type: Improvement
>          Components: testing
>            Reporter: Zhitao Li
>            Assignee: Zhitao Li
>            Priority: Minor
>
> It seems like we don't have any integration test practicing the case of exceeding container memory limit.
> We could add one to cgroups_isolator_tests.cpp.
> Good starting task for anyone interested in this area, including myself.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)