You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Xi Wang <xw...@hortonworks.com> on 2014/11/08 02:05:51 UTC

Review Request 27763: Alerts UI: Create Manage Alerts Group dialog

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27763/
-----------------------------------------------------------

Review request for Ambari, Aleksandr Kovalenko and Srimanth Gunturi.


Bugs: AMBARI-8221
    https://issues.apache.org/jira/browse/AMBARI-8221


Repository: ambari


Description
-------

We want a dialog to manage alert groups per service. 
Users should be able to see the list of alert groups, and view the alert definitions configured in them. 
User should be able to add/remove alert definitions, and pick notification for that alert group.


Diffs
-----

  ambari-web/app/assets/data/alerts/alertGroup.json PRE-CREATION 
  ambari-web/app/assets/data/alerts/alertGroups.json PRE-CREATION 
  ambari-web/app/controllers.js 3e4e0da 
  ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js e6a5c33 
  ambari-web/app/controllers/main/alerts/manage_alert_groups_controller.js PRE-CREATION 
  ambari-web/app/messages.js 3b8bbcd 
  ambari-web/app/models.js 5aa3bd6 
  ambari-web/app/models/alert_group.js PRE-CREATION 
  ambari-web/app/templates/main/alerts/add_definition_to_group_popup.hbs PRE-CREATION 
  ambari-web/app/templates/main/alerts/manage_alert_groups_popup.hbs PRE-CREATION 
  ambari-web/app/utils/ajax/ajax.js 5929152 
  ambari-web/app/views.js bfc3708 
  ambari-web/app/views/main/alerts/manage_alert_groups_view.js PRE-CREATION 

Diff: https://reviews.apache.org/r/27763/diff/


Testing
-------


Thanks,

Xi Wang

Re: Review Request 27763: Alerts UI: Create Manage Alerts Group dialog

Posted by Xi Wang <xw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27763/
-----------------------------------------------------------

(Updated Nov. 13, 2014, 3:45 p.m.)


Review request for Ambari, Aleksandr Kovalenko and Srimanth Gunturi.


Changes
-------

AlertGroupMapper included. Background will poll and populate every serveral seconds


Bugs: AMBARI-8221
    https://issues.apache.org/jira/browse/AMBARI-8221


Repository: ambari


Description
-------

We want a dialog to manage alert groups per service. 
Users should be able to see the list of alert groups, and view the alert definitions configured in them. 
User should be able to add/remove alert definitions, and pick notification for that alert group.


Diffs (updated)
-----

  ambari-web/app/assets/data/alerts/alertGroup.json PRE-CREATION 
  ambari-web/app/assets/data/alerts/alertGroups.json PRE-CREATION 
  ambari-web/app/config.js 27ab995 
  ambari-web/app/controllers.js 1b8a96c 
  ambari-web/app/controllers/global/cluster_controller.js 319ee95 
  ambari-web/app/controllers/global/update_controller.js 1f1609f 
  ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js e6a5c33 
  ambari-web/app/controllers/main/alerts/manage_alert_groups_controller.js PRE-CREATION 
  ambari-web/app/mappers.js 9aec70f 
  ambari-web/app/mappers/alert_groups_mapper.js PRE-CREATION 
  ambari-web/app/messages.js e8b97d0 
  ambari-web/app/models.js 1b9e9be 
  ambari-web/app/models/alert_group.js PRE-CREATION 
  ambari-web/app/templates/main/alerts/add_definition_to_group_popup.hbs PRE-CREATION 
  ambari-web/app/templates/main/alerts/create_new_alert_group.hbs PRE-CREATION 
  ambari-web/app/templates/main/alerts/manage_alert_groups_popup.hbs PRE-CREATION 
  ambari-web/app/utils/ajax/ajax.js bcaecd3 
  ambari-web/app/utils/validator.js fb51d4b 
  ambari-web/app/views.js 0009cfa 
  ambari-web/app/views/main/alerts/manage_alert_groups_view.js PRE-CREATION 

Diff: https://reviews.apache.org/r/27763/diff/


Testing
-------

Tested end to end. Unit tests passed.


Thanks,

Xi Wang

Re: Review Request 27763: Alerts UI: Create Manage Alerts Group dialog

Posted by Xi Wang <xw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27763/
-----------------------------------------------------------

(Updated Nov. 11, 2014, 2:25 p.m.)


Review request for Ambari, Aleksandr Kovalenko and Srimanth Gunturi.


Bugs: AMBARI-8221
    https://issues.apache.org/jira/browse/AMBARI-8221


Repository: ambari


Description
-------

We want a dialog to manage alert groups per service. 
Users should be able to see the list of alert groups, and view the alert definitions configured in them. 
User should be able to add/remove alert definitions, and pick notification for that alert group.


Diffs
-----

  ambari-web/app/assets/data/alerts/alertGroup.json PRE-CREATION 
  ambari-web/app/assets/data/alerts/alertGroups.json PRE-CREATION 
  ambari-web/app/controllers.js 146840f 
  ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js e6a5c33 
  ambari-web/app/controllers/main/alerts/manage_alert_groups_controller.js PRE-CREATION 
  ambari-web/app/messages.js 4464534 
  ambari-web/app/models.js df19e28 
  ambari-web/app/models/alert_group.js PRE-CREATION 
  ambari-web/app/templates/main/alerts/add_definition_to_group_popup.hbs PRE-CREATION 
  ambari-web/app/templates/main/alerts/create_new_alert_group.hbs PRE-CREATION 
  ambari-web/app/templates/main/alerts/manage_alert_groups_popup.hbs PRE-CREATION 
  ambari-web/app/utils/ajax/ajax.js ef26ba8 
  ambari-web/app/utils/validator.js fb51d4b 
  ambari-web/app/views.js ff40a9f 
  ambari-web/app/views/main/alerts/manage_alert_groups_view.js PRE-CREATION 

Diff: https://reviews.apache.org/r/27763/diff/


Testing (updated)
-------

Tested end to end. Unit tests passed.


Thanks,

Xi Wang

Re: Review Request 27763: Alerts UI: Create Manage Alerts Group dialog

Posted by Xi Wang <xw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27763/
-----------------------------------------------------------

(Updated Nov. 11, 2014, 2:22 p.m.)


Review request for Ambari, Aleksandr Kovalenko and Srimanth Gunturi.


Changes
-------

Patch updated. With full functions of this dialog including add/remove/rename/duplicate Alert Group, and add/remove definitions of a group.


Bugs: AMBARI-8221
    https://issues.apache.org/jira/browse/AMBARI-8221


Repository: ambari


Description
-------

We want a dialog to manage alert groups per service. 
Users should be able to see the list of alert groups, and view the alert definitions configured in them. 
User should be able to add/remove alert definitions, and pick notification for that alert group.


Diffs (updated)
-----

  ambari-web/app/assets/data/alerts/alertGroup.json PRE-CREATION 
  ambari-web/app/assets/data/alerts/alertGroups.json PRE-CREATION 
  ambari-web/app/controllers.js 146840f 
  ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js e6a5c33 
  ambari-web/app/controllers/main/alerts/manage_alert_groups_controller.js PRE-CREATION 
  ambari-web/app/messages.js 4464534 
  ambari-web/app/models.js df19e28 
  ambari-web/app/models/alert_group.js PRE-CREATION 
  ambari-web/app/templates/main/alerts/add_definition_to_group_popup.hbs PRE-CREATION 
  ambari-web/app/templates/main/alerts/create_new_alert_group.hbs PRE-CREATION 
  ambari-web/app/templates/main/alerts/manage_alert_groups_popup.hbs PRE-CREATION 
  ambari-web/app/utils/ajax/ajax.js ef26ba8 
  ambari-web/app/utils/validator.js fb51d4b 
  ambari-web/app/views.js ff40a9f 
  ambari-web/app/views/main/alerts/manage_alert_groups_view.js PRE-CREATION 

Diff: https://reviews.apache.org/r/27763/diff/


Testing
-------


Thanks,

Xi Wang