You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/16 08:33:48 UTC

[GitHub] [incubator-doris] pengxiangyu opened a new issue, #10189: [Feature] Fix duplicate code for PropertyAnalyzer.analyzeDataProperty()

pengxiangyu opened a new issue, #10189:
URL: https://github.com/apache/incubator-doris/issues/10189

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Description
   
   PropertyAnalyzer.analyzeDataProperty(Map<String, String> properties, final DataProperty oldDataProperty) has something not suitable.
   Parameter oldDataProperty is the old DataProperty, properties should be used to replace some of its members.
   If properties has no some members, old ones need to be left, but not be set to default value.
   Function modifyPartitionsProperty() uses analyzeDataProperty(), but create a new DataProperty again, it is duplicate.
   
   ### Use case
   
   Remove duplicate code from modifyPartitionsProperty() and realize them in analyzeDataProperty().
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] morningman closed issue #10189: [Feature] Fix duplicate code for PropertyAnalyzer.analyzeDataProperty()

Posted by GitBox <gi...@apache.org>.
morningman closed issue #10189: [Feature] Fix duplicate code for PropertyAnalyzer.analyzeDataProperty()
URL: https://github.com/apache/doris/issues/10189


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org