You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/07/20 08:40:18 UTC
[GitHub] [incubator-yunikorn-release] kingamarton opened a new pull request #18: Update index.yaml
kingamarton opened a new pull request #18:
URL: https://github.com/apache/incubator-yunikorn-release/pull/18
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [incubator-yunikorn-release] kingamarton commented on a change in pull request #18: Update index.yaml
Posted by GitBox <gi...@apache.org>.
kingamarton commented on a change in pull request #18:
URL: https://github.com/apache/incubator-yunikorn-release/pull/18#discussion_r457874908
##########
File path: index.yaml
##########
@@ -39,10 +39,10 @@ entries:
- https://github.com/apache/incubator-yunikorn-release/releases/download/v0.8.0/yunikorn-0.8.0.tgz
version: 0.8.0
- apiVersion: v1
- appVersion: 0.9.0
- created: "2020-06-24T14:12:46.578917+02:00"
+ appVersion: latest
+ created: "2020-07-17T12:19:19.969474+02:00""
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [incubator-yunikorn-release] yangwwei commented on a change in pull request #18: Update index.yaml
Posted by GitBox <gi...@apache.org>.
yangwwei commented on a change in pull request #18:
URL: https://github.com/apache/incubator-yunikorn-release/pull/18#discussion_r457864851
##########
File path: index.yaml
##########
@@ -39,10 +39,10 @@ entries:
- https://github.com/apache/incubator-yunikorn-release/releases/download/v0.8.0/yunikorn-0.8.0.tgz
version: 0.8.0
- apiVersion: v1
- appVersion: 0.9.0
- created: "2020-06-24T14:12:46.578917+02:00"
+ appVersion: latest
Review comment:
is it OK to set appVersion to latest instead of a numeric version?
##########
File path: index.yaml
##########
@@ -39,10 +39,10 @@ entries:
- https://github.com/apache/incubator-yunikorn-release/releases/download/v0.8.0/yunikorn-0.8.0.tgz
version: 0.8.0
- apiVersion: v1
- appVersion: 0.9.0
- created: "2020-06-24T14:12:46.578917+02:00"
+ appVersion: latest
+ created: "2020-07-17T12:19:19.969474+02:00""
Review comment:
there is an extra quote, pls remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [incubator-yunikorn-release] kingamarton commented on a change in pull request #18: Update index.yaml
Posted by GitBox <gi...@apache.org>.
kingamarton commented on a change in pull request #18:
URL: https://github.com/apache/incubator-yunikorn-release/pull/18#discussion_r457874357
##########
File path: index.yaml
##########
@@ -39,10 +39,10 @@ entries:
- https://github.com/apache/incubator-yunikorn-release/releases/download/v0.8.0/yunikorn-0.8.0.tgz
version: 0.8.0
- apiVersion: v1
- appVersion: 0.9.0
- created: "2020-06-24T14:12:46.578917+02:00"
+ appVersion: latest
Review comment:
The app version is an optional field and it is the version of the application the chart contains, in our case the YK version
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [incubator-yunikorn-release] yangwwei merged pull request #18: Update index.yaml
Posted by GitBox <gi...@apache.org>.
yangwwei merged pull request #18:
URL: https://github.com/apache/incubator-yunikorn-release/pull/18
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org