You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2014/02/05 20:20:31 UTC
Review Request 17751: Add custom action to ignore alerts for PASSIVE
host_components
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17751/
-----------------------------------------------------------
Review request for Ambari, Mahadev Konar, Sumit Mohanty, and Sid Wagle.
Bugs: AMBARI-4528
https://issues.apache.org/jira/browse/AMBARI-4528
Repository: ambari
Description
-------
Change description:
* Added a custom action to create a "suppression list" on the Nagios server when marking PASSIVE.
* Added a Nagios wrapper script to check return results against the suppression list
* Return the actual return value for any script that is wrapped, using the Nagios long_plugin_output format
* Change the nagios addon to support returning long_plugin_output
* In the alert structure, supply the actual_result for use in the UI
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java c06c92c
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 2e1c3cd
ambari-server/src/main/java/org/apache/ambari/server/controller/PassiveAlertHelper.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 1eb9a8a
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 1145b1b
ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosAlert.java d456f78
ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 0b05422
ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml ee07900
ambari-server/src/main/resources/custom_actions/nagios_update_ignore.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_aggregate.php f4063fb
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_wrapper.sh PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/scripts/nagios.py 36f6622
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/scripts/nagios_server_config.py 9f6c884
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-commands.cfg.j2 99870d0
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-services.cfg.j2 793732e
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_aggregate.php f4063fb
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_wrapper.sh PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/nagios.py 36f6622
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/nagios_server_config.py 9f6c884
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-commands.cfg.j2 99870d0
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 b9f0892
ambari-server/src/test/java/org/apache/ambari/server/controller/PassiveAlertHelperTest.java PRE-CREATION
contrib/addons/src/addOns/nagios/scripts/nagios_alerts.php 8ebf16c
Diff: https://reviews.apache.org/r/17751/diff/
Testing
-------
New test:
Running org.apache.ambari.server.controller.PassiveAlertHelperTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.239 sec
Server tests:
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 12:28.154s
[INFO] Finished at: Wed Feb 05 10:43:05 PST 2014
[INFO] Final Memory: 19M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 17751: Add custom action to ignore alerts for PASSIVE
host_components
Posted by Nate Cole <nc...@hortonworks.com>.
> On Feb. 10, 2014, 2:16 a.m., Sumit Mohanty wrote:
> > Do we need the capability to have Nagios restart get the latest wrt. passive state? Hypothetically, agent is down on Nagios server and missed some modification custom actions. Should we always send the passive state summary upon registration?
> >
> > "List<ServiceComponentHost> ok = new ArrayList<ServiceComponentHost>();" - why the variable is named ok?
> >
> >
* Since both you and Mahadev brought up the same point about a restart, will modify the patch to send that (much like we do with the rest of the cluster).
* It's called "ok" because those are the HC that are "ok to send the command" :)
* Tests: I have the server side of that test already, and will work on the Python side.
Thanks guys!
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17751/#review34057
-----------------------------------------------------------
On Feb. 8, 2014, 9:32 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17751/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2014, 9:32 a.m.)
>
>
> Review request for Ambari, Mahadev Konar, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-4528
> https://issues.apache.org/jira/browse/AMBARI-4528
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Change description:
> * Added a custom action to create a "suppression list" on the Nagios server when marking PASSIVE.
> * Added a Nagios wrapper script to check return results against the suppression list
> * Return the actual return value for any script that is wrapped, using the Nagios long_plugin_output format
> * Change the nagios addon to support returning long_plugin_output
> * In the alert structure, supply the actual_result for use in the UI
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java c06c92c
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 0efc935
> ambari-server/src/main/java/org/apache/ambari/server/controller/PassiveAlertHelper.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 1eb9a8a
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 1145b1b
> ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosAlert.java d456f78
> ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 0b05422
> ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml ee07900
> ambari-server/src/main/resources/custom_actions/nagios_update_ignore.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_aggregate.php f4063fb
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_wrapper.sh PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/scripts/nagios.py 36f6622
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/scripts/nagios_server_config.py 9f6c884
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-commands.cfg.j2 99870d0
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-services.cfg.j2 793732e
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_aggregate.php f4063fb
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_wrapper.sh PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/nagios.py 36f6622
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/nagios_server_config.py 9f6c884
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-commands.cfg.j2 99870d0
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 b9f0892
> ambari-server/src/test/java/org/apache/ambari/server/controller/PassiveAlertHelperTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java 0b8e6cc
> ambari-server/src/test/resources/nagios_alerts.txt 196a2fd
> contrib/addons/src/addOns/nagios/scripts/nagios_alerts.php 8ebf16c
>
> Diff: https://reviews.apache.org/r/17751/diff/
>
>
> Testing
> -------
>
> New test:
> Running org.apache.ambari.server.controller.PassiveAlertHelperTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.239 sec
>
> Server tests:
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 12:28.154s
> [INFO] Finished at: Wed Feb 05 10:43:05 PST 2014
> [INFO] Final Memory: 19M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 17751: Add custom action to ignore alerts for PASSIVE
host_components
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17751/#review34057
-----------------------------------------------------------
Do we need the capability to have Nagios restart get the latest wrt. passive state? Hypothetically, agent is down on Nagios server and missed some modification custom actions. Should we always send the passive state summary upon registration?
"List<ServiceComponentHost> ok = new ArrayList<ServiceComponentHost>();" - why the variable is named ok?
- Sumit Mohanty
On Feb. 8, 2014, 2:32 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17751/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2014, 2:32 p.m.)
>
>
> Review request for Ambari, Mahadev Konar, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-4528
> https://issues.apache.org/jira/browse/AMBARI-4528
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Change description:
> * Added a custom action to create a "suppression list" on the Nagios server when marking PASSIVE.
> * Added a Nagios wrapper script to check return results against the suppression list
> * Return the actual return value for any script that is wrapped, using the Nagios long_plugin_output format
> * Change the nagios addon to support returning long_plugin_output
> * In the alert structure, supply the actual_result for use in the UI
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java c06c92c
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 0efc935
> ambari-server/src/main/java/org/apache/ambari/server/controller/PassiveAlertHelper.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 1eb9a8a
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 1145b1b
> ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosAlert.java d456f78
> ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 0b05422
> ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml ee07900
> ambari-server/src/main/resources/custom_actions/nagios_update_ignore.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_aggregate.php f4063fb
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_wrapper.sh PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/scripts/nagios.py 36f6622
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/scripts/nagios_server_config.py 9f6c884
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-commands.cfg.j2 99870d0
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-services.cfg.j2 793732e
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_aggregate.php f4063fb
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_wrapper.sh PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/nagios.py 36f6622
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/nagios_server_config.py 9f6c884
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-commands.cfg.j2 99870d0
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 b9f0892
> ambari-server/src/test/java/org/apache/ambari/server/controller/PassiveAlertHelperTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java 0b8e6cc
> ambari-server/src/test/resources/nagios_alerts.txt 196a2fd
> contrib/addons/src/addOns/nagios/scripts/nagios_alerts.php 8ebf16c
>
> Diff: https://reviews.apache.org/r/17751/diff/
>
>
> Testing
> -------
>
> New test:
> Running org.apache.ambari.server.controller.PassiveAlertHelperTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.239 sec
>
> Server tests:
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 12:28.154s
> [INFO] Finished at: Wed Feb 05 10:43:05 PST 2014
> [INFO] Final Memory: 19M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 17751: Add custom action to ignore alerts for PASSIVE
host_components
Posted by Mahadev Konar <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17751/#review34333
-----------------------------------------------------------
Ship it!
Ship It!
- Mahadev Konar
On Feb. 11, 2014, 8:51 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17751/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2014, 8:51 p.m.)
>
>
> Review request for Ambari, Mahadev Konar, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-4528
> https://issues.apache.org/jira/browse/AMBARI-4528
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Change description:
> * Added a custom action to create a "suppression list" on the Nagios server when marking PASSIVE.
> * Added a Nagios wrapper script to check return results against the suppression list
> * Return the actual return value for any script that is wrapped, using the Nagios long_plugin_output format
> * Change the nagios addon to support returning long_plugin_output
> * In the alert structure, supply the actual_result for use in the UI
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 3ce7da2
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java c06c92c
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java 70f9e58
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 49985fd
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java af7663b
> ambari-server/src/main/java/org/apache/ambari/server/controller/PassiveStateHelper.java a6b56cc
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 1eb9a8a
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java cc94baa
> ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosAlert.java d456f78
> ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 0b05422
> ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml ee07900
> ambari-server/src/main/resources/custom_actions/nagios_update_ignore.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_aggregate.php f4063fb
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_wrapper.sh PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/scripts/nagios.py 36f6622
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/scripts/nagios_server.py 02685c7
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/scripts/nagios_server_config.py 275c9c4
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-commands.cfg.j2 99870d0
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-services.cfg.j2 793732e
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_aggregate.php f4063fb
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_wrapper.sh PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/nagios.py 36f6622
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/nagios_server.py 02685c7
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/nagios_server_config.py 275c9c4
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-commands.cfg.j2 99870d0
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 b9f0892
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 6c78218
> ambari-server/src/test/java/org/apache/ambari/server/controller/PassiveStateHelperTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java 0b8e6cc
> ambari-server/src/test/python/stacks/1.3.2/NAGIOS/test_nagios_server.py 3010778
> ambari-server/src/test/python/stacks/2.0.6/NAGIOS/test_nagios_server.py 5a9cc2f
> ambari-server/src/test/resources/nagios_alerts.txt 196a2fd
> contrib/addons/src/addOns/nagios/scripts/nagios_alerts.php 8ebf16c
>
> Diff: https://reviews.apache.org/r/17751/diff/
>
>
> Testing
> -------
>
> New test:
> Running org.apache.ambari.server.controller.PassiveAlertHelperTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.239 sec
>
> Server tests:
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 12:28.154s
> [INFO] Finished at: Wed Feb 05 10:43:05 PST 2014
> [INFO] Final Memory: 19M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 17751: Add custom action to ignore alerts for PASSIVE
host_components
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17751/
-----------------------------------------------------------
(Updated Feb. 11, 2014, 3:51 p.m.)
Review request for Ambari, Mahadev Konar, Sumit Mohanty, and Sid Wagle.
Changes
-------
Updated ExecutionCommand to send passive info. That way a restart of Nagios will correctly create the suppression list. Also modified code to send ALL passive info whenever any one of them changes. This significantly reduces complexity (you guys rock!). Fixed all test cases, including python, to run successfully.
Bugs: AMBARI-4528
https://issues.apache.org/jira/browse/AMBARI-4528
Repository: ambari
Description
-------
Change description:
* Added a custom action to create a "suppression list" on the Nagios server when marking PASSIVE.
* Added a Nagios wrapper script to check return results against the suppression list
* Return the actual return value for any script that is wrapped, using the Nagios long_plugin_output format
* Change the nagios addon to support returning long_plugin_output
* In the alert structure, supply the actual_result for use in the UI
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 3ce7da2
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java c06c92c
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java 70f9e58
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 49985fd
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java af7663b
ambari-server/src/main/java/org/apache/ambari/server/controller/PassiveStateHelper.java a6b56cc
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 1eb9a8a
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java cc94baa
ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosAlert.java d456f78
ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 0b05422
ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml ee07900
ambari-server/src/main/resources/custom_actions/nagios_update_ignore.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_aggregate.php f4063fb
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_wrapper.sh PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/scripts/nagios.py 36f6622
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/scripts/nagios_server.py 02685c7
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/scripts/nagios_server_config.py 275c9c4
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-commands.cfg.j2 99870d0
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-services.cfg.j2 793732e
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_aggregate.php f4063fb
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_wrapper.sh PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/nagios.py 36f6622
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/nagios_server.py 02685c7
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/nagios_server_config.py 275c9c4
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-commands.cfg.j2 99870d0
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 b9f0892
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 6c78218
ambari-server/src/test/java/org/apache/ambari/server/controller/PassiveStateHelperTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java 0b8e6cc
ambari-server/src/test/python/stacks/1.3.2/NAGIOS/test_nagios_server.py 3010778
ambari-server/src/test/python/stacks/2.0.6/NAGIOS/test_nagios_server.py 5a9cc2f
ambari-server/src/test/resources/nagios_alerts.txt 196a2fd
contrib/addons/src/addOns/nagios/scripts/nagios_alerts.php 8ebf16c
Diff: https://reviews.apache.org/r/17751/diff/
Testing
-------
New test:
Running org.apache.ambari.server.controller.PassiveAlertHelperTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.239 sec
Server tests:
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 12:28.154s
[INFO] Finished at: Wed Feb 05 10:43:05 PST 2014
[INFO] Final Memory: 19M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 17751: Add custom action to ignore alerts for PASSIVE
host_components
Posted by Sumit Mohanty <sm...@hortonworks.com>.
> On Feb. 9, 2014, 4:35 a.m., Mahadev Konar wrote:
> > ambari-server/src/main/resources/custom_actions/nagios_update_ignore.py, line 10
> > <https://reviews.apache.org/r/17751/diff/2/?file=481028#file481028line10>
> >
> > Can we add unit tests for this file? A separate jira is fine as well.
>
> Nate Cole wrote:
> Will add a separate JIRA, as will need to consult with Sumit on how we test custom actions.
The tests have to be written in two parts (not unlike another commands):
* Server side can test that a request is created with proper parameters. In this case, you can add the check to test that set PASSIVE state to check that an additional HostRoleCommand is created.
* A python unit test similar to tests in ambari-server/src/test/python/ to test the custom action script
- Sumit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17751/#review34027
-----------------------------------------------------------
On Feb. 8, 2014, 2:32 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17751/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2014, 2:32 p.m.)
>
>
> Review request for Ambari, Mahadev Konar, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-4528
> https://issues.apache.org/jira/browse/AMBARI-4528
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Change description:
> * Added a custom action to create a "suppression list" on the Nagios server when marking PASSIVE.
> * Added a Nagios wrapper script to check return results against the suppression list
> * Return the actual return value for any script that is wrapped, using the Nagios long_plugin_output format
> * Change the nagios addon to support returning long_plugin_output
> * In the alert structure, supply the actual_result for use in the UI
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java c06c92c
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 0efc935
> ambari-server/src/main/java/org/apache/ambari/server/controller/PassiveAlertHelper.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 1eb9a8a
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 1145b1b
> ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosAlert.java d456f78
> ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 0b05422
> ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml ee07900
> ambari-server/src/main/resources/custom_actions/nagios_update_ignore.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_aggregate.php f4063fb
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_wrapper.sh PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/scripts/nagios.py 36f6622
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/scripts/nagios_server_config.py 9f6c884
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-commands.cfg.j2 99870d0
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-services.cfg.j2 793732e
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_aggregate.php f4063fb
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_wrapper.sh PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/nagios.py 36f6622
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/nagios_server_config.py 9f6c884
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-commands.cfg.j2 99870d0
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 b9f0892
> ambari-server/src/test/java/org/apache/ambari/server/controller/PassiveAlertHelperTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java 0b8e6cc
> ambari-server/src/test/resources/nagios_alerts.txt 196a2fd
> contrib/addons/src/addOns/nagios/scripts/nagios_alerts.php 8ebf16c
>
> Diff: https://reviews.apache.org/r/17751/diff/
>
>
> Testing
> -------
>
> New test:
> Running org.apache.ambari.server.controller.PassiveAlertHelperTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.239 sec
>
> Server tests:
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 12:28.154s
> [INFO] Finished at: Wed Feb 05 10:43:05 PST 2014
> [INFO] Final Memory: 19M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 17751: Add custom action to ignore alerts for PASSIVE
host_components
Posted by Nate Cole <nc...@hortonworks.com>.
> On Feb. 8, 2014, 11:35 p.m., Mahadev Konar wrote:
> > ambari-server/src/main/resources/custom_actions/nagios_update_ignore.py, line 10
> > <https://reviews.apache.org/r/17751/diff/2/?file=481028#file481028line10>
> >
> > Can we add unit tests for this file? A separate jira is fine as well.
Will add a separate JIRA, as will need to consult with Sumit on how we test custom actions.
> On Feb. 8, 2014, 11:35 p.m., Mahadev Konar wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java, line 564
> > <https://reviews.apache.org/r/17751/diff/2/?file=481024#file481024line564>
> >
> > What happens if a request creation fails? How do we deal with something like:
> >
> > 1. The passive state is set but the request to nagios fails?
> >
> > How do we reset nagios in that case? Would a restart of nagios fix that?
A reset of PASSIVE on the Service/Host/HostComponent will re-send the action.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17751/#review34027
-----------------------------------------------------------
On Feb. 8, 2014, 9:32 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17751/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2014, 9:32 a.m.)
>
>
> Review request for Ambari, Mahadev Konar, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-4528
> https://issues.apache.org/jira/browse/AMBARI-4528
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Change description:
> * Added a custom action to create a "suppression list" on the Nagios server when marking PASSIVE.
> * Added a Nagios wrapper script to check return results against the suppression list
> * Return the actual return value for any script that is wrapped, using the Nagios long_plugin_output format
> * Change the nagios addon to support returning long_plugin_output
> * In the alert structure, supply the actual_result for use in the UI
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java c06c92c
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 0efc935
> ambari-server/src/main/java/org/apache/ambari/server/controller/PassiveAlertHelper.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 1eb9a8a
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 1145b1b
> ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosAlert.java d456f78
> ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 0b05422
> ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml ee07900
> ambari-server/src/main/resources/custom_actions/nagios_update_ignore.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_aggregate.php f4063fb
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_wrapper.sh PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/scripts/nagios.py 36f6622
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/scripts/nagios_server_config.py 9f6c884
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-commands.cfg.j2 99870d0
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-services.cfg.j2 793732e
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_aggregate.php f4063fb
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_wrapper.sh PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/nagios.py 36f6622
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/nagios_server_config.py 9f6c884
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-commands.cfg.j2 99870d0
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 b9f0892
> ambari-server/src/test/java/org/apache/ambari/server/controller/PassiveAlertHelperTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java 0b8e6cc
> ambari-server/src/test/resources/nagios_alerts.txt 196a2fd
> contrib/addons/src/addOns/nagios/scripts/nagios_alerts.php 8ebf16c
>
> Diff: https://reviews.apache.org/r/17751/diff/
>
>
> Testing
> -------
>
> New test:
> Running org.apache.ambari.server.controller.PassiveAlertHelperTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.239 sec
>
> Server tests:
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 12:28.154s
> [INFO] Finished at: Wed Feb 05 10:43:05 PST 2014
> [INFO] Final Memory: 19M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 17751: Add custom action to ignore alerts for PASSIVE
host_components
Posted by Mahadev Konar <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17751/#review34027
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
<https://reviews.apache.org/r/17751/#comment63978>
What happens if a request creation fails? How do we deal with something like:
1. The passive state is set but the request to nagios fails?
How do we reset nagios in that case? Would a restart of nagios fix that?
ambari-server/src/main/resources/custom_actions/nagios_update_ignore.py
<https://reviews.apache.org/r/17751/#comment63979>
Can we add unit tests for this file? A separate jira is fine as well.
- Mahadev Konar
On Feb. 8, 2014, 2:32 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17751/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2014, 2:32 p.m.)
>
>
> Review request for Ambari, Mahadev Konar, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-4528
> https://issues.apache.org/jira/browse/AMBARI-4528
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Change description:
> * Added a custom action to create a "suppression list" on the Nagios server when marking PASSIVE.
> * Added a Nagios wrapper script to check return results against the suppression list
> * Return the actual return value for any script that is wrapped, using the Nagios long_plugin_output format
> * Change the nagios addon to support returning long_plugin_output
> * In the alert structure, supply the actual_result for use in the UI
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java c06c92c
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 0efc935
> ambari-server/src/main/java/org/apache/ambari/server/controller/PassiveAlertHelper.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 1eb9a8a
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 1145b1b
> ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosAlert.java d456f78
> ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 0b05422
> ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml ee07900
> ambari-server/src/main/resources/custom_actions/nagios_update_ignore.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_aggregate.php f4063fb
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_wrapper.sh PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/scripts/nagios.py 36f6622
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/scripts/nagios_server_config.py 9f6c884
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-commands.cfg.j2 99870d0
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-services.cfg.j2 793732e
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_aggregate.php f4063fb
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_wrapper.sh PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/nagios.py 36f6622
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/nagios_server_config.py 9f6c884
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-commands.cfg.j2 99870d0
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 b9f0892
> ambari-server/src/test/java/org/apache/ambari/server/controller/PassiveAlertHelperTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java 0b8e6cc
> ambari-server/src/test/resources/nagios_alerts.txt 196a2fd
> contrib/addons/src/addOns/nagios/scripts/nagios_alerts.php 8ebf16c
>
> Diff: https://reviews.apache.org/r/17751/diff/
>
>
> Testing
> -------
>
> New test:
> Running org.apache.ambari.server.controller.PassiveAlertHelperTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.239 sec
>
> Server tests:
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 12:28.154s
> [INFO] Finished at: Wed Feb 05 10:43:05 PST 2014
> [INFO] Final Memory: 19M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 17751: Add custom action to ignore alerts for PASSIVE
host_components
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17751/
-----------------------------------------------------------
(Updated Feb. 8, 2014, 9:32 a.m.)
Review request for Ambari, Mahadev Konar, Sumit Mohanty, and Sid Wagle.
Changes
-------
Uploaded new patch with additional test case and returning PASSIVE for status in the Ambari alert JSON.
Bugs: AMBARI-4528
https://issues.apache.org/jira/browse/AMBARI-4528
Repository: ambari
Description
-------
Change description:
* Added a custom action to create a "suppression list" on the Nagios server when marking PASSIVE.
* Added a Nagios wrapper script to check return results against the suppression list
* Return the actual return value for any script that is wrapped, using the Nagios long_plugin_output format
* Change the nagios addon to support returning long_plugin_output
* In the alert structure, supply the actual_result for use in the UI
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java c06c92c
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 0efc935
ambari-server/src/main/java/org/apache/ambari/server/controller/PassiveAlertHelper.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 1eb9a8a
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 1145b1b
ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosAlert.java d456f78
ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 0b05422
ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml ee07900
ambari-server/src/main/resources/custom_actions/nagios_update_ignore.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_aggregate.php f4063fb
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_wrapper.sh PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/scripts/nagios.py 36f6622
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/scripts/nagios_server_config.py 9f6c884
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-commands.cfg.j2 99870d0
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-services.cfg.j2 793732e
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_aggregate.php f4063fb
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_wrapper.sh PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/nagios.py 36f6622
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/nagios_server_config.py 9f6c884
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-commands.cfg.j2 99870d0
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 b9f0892
ambari-server/src/test/java/org/apache/ambari/server/controller/PassiveAlertHelperTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java 0b8e6cc
ambari-server/src/test/resources/nagios_alerts.txt 196a2fd
contrib/addons/src/addOns/nagios/scripts/nagios_alerts.php 8ebf16c
Diff: https://reviews.apache.org/r/17751/diff/
Testing
-------
New test:
Running org.apache.ambari.server.controller.PassiveAlertHelperTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.239 sec
Server tests:
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 12:28.154s
[INFO] Finished at: Wed Feb 05 10:43:05 PST 2014
[INFO] Final Memory: 19M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 17751: Add custom action to ignore alerts for PASSIVE
host_components
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17751/#review33944
-----------------------------------------------------------
Result of discussion with Sumit/Mahadev: Instead of return a fake status of OK in the JSON, return a different status such as MAINTENANCE or PASSIVE for the state. The actual return status will be available in actual_status.
- Nate Cole
On Feb. 5, 2014, 2:20 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17751/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2014, 2:20 p.m.)
>
>
> Review request for Ambari, Mahadev Konar, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-4528
> https://issues.apache.org/jira/browse/AMBARI-4528
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Change description:
> * Added a custom action to create a "suppression list" on the Nagios server when marking PASSIVE.
> * Added a Nagios wrapper script to check return results against the suppression list
> * Return the actual return value for any script that is wrapped, using the Nagios long_plugin_output format
> * Change the nagios addon to support returning long_plugin_output
> * In the alert structure, supply the actual_result for use in the UI
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java c06c92c
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 2e1c3cd
> ambari-server/src/main/java/org/apache/ambari/server/controller/PassiveAlertHelper.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 1eb9a8a
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 1145b1b
> ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosAlert.java d456f78
> ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 0b05422
> ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml ee07900
> ambari-server/src/main/resources/custom_actions/nagios_update_ignore.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_aggregate.php f4063fb
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_wrapper.sh PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/scripts/nagios.py 36f6622
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/scripts/nagios_server_config.py 9f6c884
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-commands.cfg.j2 99870d0
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-services.cfg.j2 793732e
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_aggregate.php f4063fb
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_wrapper.sh PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/nagios.py 36f6622
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/nagios_server_config.py 9f6c884
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-commands.cfg.j2 99870d0
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 b9f0892
> ambari-server/src/test/java/org/apache/ambari/server/controller/PassiveAlertHelperTest.java PRE-CREATION
> contrib/addons/src/addOns/nagios/scripts/nagios_alerts.php 8ebf16c
>
> Diff: https://reviews.apache.org/r/17751/diff/
>
>
> Testing
> -------
>
> New test:
> Running org.apache.ambari.server.controller.PassiveAlertHelperTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.239 sec
>
> Server tests:
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 12:28.154s
> [INFO] Finished at: Wed Feb 05 10:43:05 PST 2014
> [INFO] Final Memory: 19M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>