You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Aleksey Gorshkov (JIRA)" <ji...@apache.org> on 2012/11/26 13:34:58 UTC
[jira] [Created] (HADOOP-9092) Coverage fixing for
org.apache.hadoop.mapreduce.jobhistory
Aleksey Gorshkov created HADOOP-9092:
----------------------------------------
Summary: Coverage fixing for org.apache.hadoop.mapreduce.jobhistory
Key: HADOOP-9092
URL: https://issues.apache.org/jira/browse/HADOOP-9092
Project: Hadoop Common
Issue Type: Test
Components: tools
Reporter: Aleksey Gorshkov
Coverage fixing for package org.apache.hadoop.mapreduce.jobhistory
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9092) Coverage fixing for
org.apache.hadoop.mapreduce.jobhistory
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505274#comment-13505274 ]
Hadoop QA commented on HADOOP-9092:
-----------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12555123/HADOOP-9092-trunk-a.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1833//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1833//console
This message is automatically generated.
> Coverage fixing for org.apache.hadoop.mapreduce.jobhistory
> -----------------------------------------------------------
>
> Key: HADOOP-9092
> URL: https://issues.apache.org/jira/browse/HADOOP-9092
> Project: Hadoop Common
> Issue Type: Test
> Components: tools
> Reporter: Aleksey Gorshkov
> Attachments: HADOOP-9092-branch-0.23-a.patch, HADOOP-9092-branch-0.23.patch, HADOOP-9092-branch-2-a.patch, HADOOP-9092-branch-2.patch, HADOOP-9092-trunk-a.patch, HADOOP-9092-trunk.patch
>
>
> Coverage fixing for package org.apache.hadoop.mapreduce.jobhistory
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9092) Coverage fixing for
org.apache.hadoop.mapreduce.jobhistory
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504694#comment-13504694 ]
Robert Joseph Evans commented on HADOOP-9092:
---------------------------------------------
The change looks good. I have one minor comment still.
in TestJobHistoryEventHandler there is a line where you are using ...+"" to convert something to a string. This works, but I would prefer to see something more like Stirng.valueOf(...) instead. Other then that I am +1 for the patch.
> Coverage fixing for org.apache.hadoop.mapreduce.jobhistory
> -----------------------------------------------------------
>
> Key: HADOOP-9092
> URL: https://issues.apache.org/jira/browse/HADOOP-9092
> Project: Hadoop Common
> Issue Type: Test
> Components: tools
> Reporter: Aleksey Gorshkov
> Attachments: HADOOP-9092-branch-0.23.patch, HADOOP-9092-branch-2.patch, HADOOP-9092-trunk.patch
>
>
> Coverage fixing for package org.apache.hadoop.mapreduce.jobhistory
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9092) Coverage fixing for
org.apache.hadoop.mapreduce.jobhistory
Posted by "Aleksey Gorshkov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aleksey Gorshkov updated HADOOP-9092:
-------------------------------------
Status: Patch Available (was: Open)
> Coverage fixing for org.apache.hadoop.mapreduce.jobhistory
> -----------------------------------------------------------
>
> Key: HADOOP-9092
> URL: https://issues.apache.org/jira/browse/HADOOP-9092
> Project: Hadoop Common
> Issue Type: Test
> Components: tools
> Reporter: Aleksey Gorshkov
> Attachments: HADOOP-9092-branch-0.23.patch, HADOOP-9092-branch-2.patch, HADOOP-9092-trunk.patch
>
>
> Coverage fixing for package org.apache.hadoop.mapreduce.jobhistory
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9092) Coverage fixing for
org.apache.hadoop.mapreduce.jobhistory
Posted by "Aleksey Gorshkov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503762#comment-13503762 ]
Aleksey Gorshkov commented on HADOOP-9092:
------------------------------------------
YARN-188-branch-0.23.patch patch for branch-0.23
YARN-188-branch-2.patch patch for branch-2
YARN-188-trunk.patch patch for trunk
> Coverage fixing for org.apache.hadoop.mapreduce.jobhistory
> -----------------------------------------------------------
>
> Key: HADOOP-9092
> URL: https://issues.apache.org/jira/browse/HADOOP-9092
> Project: Hadoop Common
> Issue Type: Test
> Components: tools
> Reporter: Aleksey Gorshkov
> Attachments: HADOOP-9092-branch-0.23.patch, HADOOP-9092-branch-2.patch, HADOOP-9092-trunk.patch
>
>
> Coverage fixing for package org.apache.hadoop.mapreduce.jobhistory
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9092) Coverage fixing for
org.apache.hadoop.mapreduce.jobhistory
Posted by "Aleksey Gorshkov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aleksey Gorshkov updated HADOOP-9092:
-------------------------------------
Attachment: HADOOP-9092-trunk.patch
HADOOP-9092-branch-2.patch
HADOOP-9092-branch-0.23.patch
> Coverage fixing for org.apache.hadoop.mapreduce.jobhistory
> -----------------------------------------------------------
>
> Key: HADOOP-9092
> URL: https://issues.apache.org/jira/browse/HADOOP-9092
> Project: Hadoop Common
> Issue Type: Test
> Components: tools
> Reporter: Aleksey Gorshkov
> Attachments: HADOOP-9092-branch-0.23.patch, HADOOP-9092-branch-2.patch, HADOOP-9092-trunk.patch
>
>
> Coverage fixing for package org.apache.hadoop.mapreduce.jobhistory
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9092) Coverage fixing for
org.apache.hadoop.mapreduce.jobhistory
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503770#comment-13503770 ]
Hadoop QA commented on HADOOP-9092:
-----------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12554843/HADOOP-9092-trunk.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1822//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1822//console
This message is automatically generated.
> Coverage fixing for org.apache.hadoop.mapreduce.jobhistory
> -----------------------------------------------------------
>
> Key: HADOOP-9092
> URL: https://issues.apache.org/jira/browse/HADOOP-9092
> Project: Hadoop Common
> Issue Type: Test
> Components: tools
> Reporter: Aleksey Gorshkov
> Attachments: HADOOP-9092-branch-0.23.patch, HADOOP-9092-branch-2.patch, HADOOP-9092-trunk.patch
>
>
> Coverage fixing for package org.apache.hadoop.mapreduce.jobhistory
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9092) Coverage fixing for
org.apache.hadoop.mapreduce.jobhistory
Posted by "Aleksey Gorshkov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aleksey Gorshkov updated HADOOP-9092:
-------------------------------------
Attachment: HADOOP-9092-trunk-a.patch
HADOOP-9092-branch-2-a.patch
HADOOP-9092-branch-0.23-a.patch
> Coverage fixing for org.apache.hadoop.mapreduce.jobhistory
> -----------------------------------------------------------
>
> Key: HADOOP-9092
> URL: https://issues.apache.org/jira/browse/HADOOP-9092
> Project: Hadoop Common
> Issue Type: Test
> Components: tools
> Reporter: Aleksey Gorshkov
> Attachments: HADOOP-9092-branch-0.23-a.patch, HADOOP-9092-branch-0.23.patch, HADOOP-9092-branch-2-a.patch, HADOOP-9092-branch-2.patch, HADOOP-9092-trunk-a.patch, HADOOP-9092-trunk.patch
>
>
> Coverage fixing for package org.apache.hadoop.mapreduce.jobhistory
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9092) Coverage fixing for
org.apache.hadoop.mapreduce.jobhistory
Posted by "Aleksey Gorshkov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505262#comment-13505262 ]
Aleksey Gorshkov commented on HADOOP-9092:
------------------------------------------
I've corrected code
> Coverage fixing for org.apache.hadoop.mapreduce.jobhistory
> -----------------------------------------------------------
>
> Key: HADOOP-9092
> URL: https://issues.apache.org/jira/browse/HADOOP-9092
> Project: Hadoop Common
> Issue Type: Test
> Components: tools
> Reporter: Aleksey Gorshkov
> Attachments: HADOOP-9092-branch-0.23-a.patch, HADOOP-9092-branch-0.23.patch, HADOOP-9092-branch-2-a.patch, HADOOP-9092-branch-2.patch, HADOOP-9092-trunk-a.patch, HADOOP-9092-trunk.patch
>
>
> Coverage fixing for package org.apache.hadoop.mapreduce.jobhistory
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira