You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nutch.apache.org by "Julien Nioche (JIRA)" <ji...@apache.org> on 2010/08/02 14:27:19 UTC

[jira] Created: (NUTCH-870) Injector should add the metadata before calling injectedScore

Injector should add the metadata before calling injectedScore
-------------------------------------------------------------

                 Key: NUTCH-870
                 URL: https://issues.apache.org/jira/browse/NUTCH-870
             Project: Nutch
          Issue Type: Bug
          Components: injector
    Affects Versions: 1.2, nutchbase
            Reporter: Julien Nioche
            Assignee: Julien Nioche
             Fix For: 1.2, 2.0


The injector should add the metadata to the CrawlDatum *before* calling _scfilters.injectedScore(value, datum)_ as the metadata could be used by the ScoringFilters in this method.

The method _scfilters.injectedScore()_ should also be called regardless of whether the score is the one specified in the seed list or the one set by default but we should then modify the scoringOPICFilter so that it does not override it. 

Any thoughts? 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (NUTCH-870) Injector should add the metadata before calling injectedScore

Posted by "Chris A. Mattmann (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/NUTCH-870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris A. Mattmann resolved NUTCH-870.
-------------------------------------

    Fix Version/s: nutchbase
       Resolution: Fixed

- fixed in Nutch trunk (branch-1.3) r983278, Nutch 1.2 RC branch r983311 and in Nutchbase in r983315. Thanks for the patch, Julien. I didn't see any objections from anyone on this and it looked fine to me, so I applied it per my earlier email. This wraps up the dev for 1.2 I think so I will cut the RC later today.

> Injector should add the metadata before calling injectedScore
> -------------------------------------------------------------
>
>                 Key: NUTCH-870
>                 URL: https://issues.apache.org/jira/browse/NUTCH-870
>             Project: Nutch
>          Issue Type: Bug
>          Components: injector
>    Affects Versions: 1.2, nutchbase
>            Reporter: Julien Nioche
>            Assignee: Chris A. Mattmann
>             Fix For: 1.2, 2.0, nutchbase
>
>         Attachments: NUTCH-870.patch
>
>
> The injector should add the metadata to the CrawlDatum *before* calling _scfilters.injectedScore(value, datum)_ as the metadata could be used by the ScoringFilters in this method.
> The method _scfilters.injectedScore()_ should also be called regardless of whether the score is the one specified in the seed list or the one set by default but we should then modify the scoringOPICFilter so that it does not override it. 
> Any thoughts? 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Work started: (NUTCH-870) Injector should add the metadata before calling injectedScore

Posted by "Chris A. Mattmann (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/NUTCH-870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on NUTCH-870 started by Chris A. Mattmann.

> Injector should add the metadata before calling injectedScore
> -------------------------------------------------------------
>
>                 Key: NUTCH-870
>                 URL: https://issues.apache.org/jira/browse/NUTCH-870
>             Project: Nutch
>          Issue Type: Bug
>          Components: injector
>    Affects Versions: 1.2, nutchbase
>            Reporter: Julien Nioche
>            Assignee: Chris A. Mattmann
>             Fix For: 1.2, 2.0
>
>         Attachments: NUTCH-870.patch
>
>
> The injector should add the metadata to the CrawlDatum *before* calling _scfilters.injectedScore(value, datum)_ as the metadata could be used by the ScoringFilters in this method.
> The method _scfilters.injectedScore()_ should also be called regardless of whether the score is the one specified in the seed list or the one set by default but we should then modify the scoringOPICFilter so that it does not override it. 
> Any thoughts? 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (NUTCH-870) Injector should add the metadata before calling injectedScore

Posted by "Julien Nioche (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/NUTCH-870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julien Nioche updated NUTCH-870:
--------------------------------

    Attachment: NUTCH-870.patch

> Injector should add the metadata before calling injectedScore
> -------------------------------------------------------------
>
>                 Key: NUTCH-870
>                 URL: https://issues.apache.org/jira/browse/NUTCH-870
>             Project: Nutch
>          Issue Type: Bug
>          Components: injector
>    Affects Versions: 1.2, nutchbase
>            Reporter: Julien Nioche
>            Assignee: Julien Nioche
>             Fix For: 1.2, 2.0
>
>         Attachments: NUTCH-870.patch
>
>
> The injector should add the metadata to the CrawlDatum *before* calling _scfilters.injectedScore(value, datum)_ as the metadata could be used by the ScoringFilters in this method.
> The method _scfilters.injectedScore()_ should also be called regardless of whether the score is the one specified in the seed list or the one set by default but we should then modify the scoringOPICFilter so that it does not override it. 
> Any thoughts? 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (NUTCH-870) Injector should add the metadata before calling injectedScore

Posted by "Chris A. Mattmann (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/NUTCH-870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris A. Mattmann reassigned NUTCH-870:
---------------------------------------

    Assignee: Chris A. Mattmann  (was: Julien Nioche)

> Injector should add the metadata before calling injectedScore
> -------------------------------------------------------------
>
>                 Key: NUTCH-870
>                 URL: https://issues.apache.org/jira/browse/NUTCH-870
>             Project: Nutch
>          Issue Type: Bug
>          Components: injector
>    Affects Versions: 1.2, nutchbase
>            Reporter: Julien Nioche
>            Assignee: Chris A. Mattmann
>             Fix For: 1.2, 2.0
>
>         Attachments: NUTCH-870.patch
>
>
> The injector should add the metadata to the CrawlDatum *before* calling _scfilters.injectedScore(value, datum)_ as the metadata could be used by the ScoringFilters in this method.
> The method _scfilters.injectedScore()_ should also be called regardless of whether the score is the one specified in the seed list or the one set by default but we should then modify the scoringOPICFilter so that it does not override it. 
> Any thoughts? 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (NUTCH-870) Injector should add the metadata before calling injectedScore

Posted by "Chris A. Mattmann (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/NUTCH-870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895127#action_12895127 ] 

Chris A. Mattmann commented on NUTCH-870:
-----------------------------------------

+1, this looks good to me. This and NUTCH-858 are the only remaining issues prior to a 1.2 point release, so my +1 to commit this back to 1.2

> Injector should add the metadata before calling injectedScore
> -------------------------------------------------------------
>
>                 Key: NUTCH-870
>                 URL: https://issues.apache.org/jira/browse/NUTCH-870
>             Project: Nutch
>          Issue Type: Bug
>          Components: injector
>    Affects Versions: 1.2, nutchbase
>            Reporter: Julien Nioche
>            Assignee: Julien Nioche
>             Fix For: 1.2, 2.0
>
>         Attachments: NUTCH-870.patch
>
>
> The injector should add the metadata to the CrawlDatum *before* calling _scfilters.injectedScore(value, datum)_ as the metadata could be used by the ScoringFilters in this method.
> The method _scfilters.injectedScore()_ should also be called regardless of whether the score is the one specified in the seed list or the one set by default but we should then modify the scoringOPICFilter so that it does not override it. 
> Any thoughts? 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (NUTCH-870) Injector should add the metadata before calling injectedScore

Posted by "Julien Nioche (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/NUTCH-870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julien Nioche closed NUTCH-870.
-------------------------------

    Resolution: Fixed

Opened an new issue re- scoring filters

> Injector should add the metadata before calling injectedScore
> -------------------------------------------------------------
>
>                 Key: NUTCH-870
>                 URL: https://issues.apache.org/jira/browse/NUTCH-870
>             Project: Nutch
>          Issue Type: Bug
>          Components: injector
>    Affects Versions: nutchbase, 1.2
>            Reporter: Julien Nioche
>            Assignee: Chris A. Mattmann
>             Fix For: 1.2, 2.0, nutchbase
>
>         Attachments: NUTCH-870.patch
>
>
> The injector should add the metadata to the CrawlDatum *before* calling _scfilters.injectedScore(value, datum)_ as the metadata could be used by the ScoringFilters in this method.
> The method _scfilters.injectedScore()_ should also be called regardless of whether the score is the one specified in the seed list or the one set by default but we should then modify the scoringOPICFilter so that it does not override it. 
> Any thoughts? 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (NUTCH-870) Injector should add the metadata before calling injectedScore

Posted by "Julien Nioche (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/NUTCH-870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julien Nioche reopened NUTCH-870:
---------------------------------


the method injectedScore in OPICScoringFilter (and also LinkAnalysisScoringFilter) should be modified in order not to override the score specified in the seed list metadata

> Injector should add the metadata before calling injectedScore
> -------------------------------------------------------------
>
>                 Key: NUTCH-870
>                 URL: https://issues.apache.org/jira/browse/NUTCH-870
>             Project: Nutch
>          Issue Type: Bug
>          Components: injector
>    Affects Versions: nutchbase, 1.2
>            Reporter: Julien Nioche
>            Assignee: Chris A. Mattmann
>             Fix For: nutchbase, 1.2, 2.0
>
>         Attachments: NUTCH-870.patch
>
>
> The injector should add the metadata to the CrawlDatum *before* calling _scfilters.injectedScore(value, datum)_ as the metadata could be used by the ScoringFilters in this method.
> The method _scfilters.injectedScore()_ should also be called regardless of whether the score is the one specified in the seed list or the one set by default but we should then modify the scoringOPICFilter so that it does not override it. 
> Any thoughts? 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.