You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Alok Lal <al...@hortonworks.com> on 2015/12/04 09:41:50 UTC

Review Request 40959: Kafka plugin: new operation types supported by kafaka plugin code should be added to service definition.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40959/
-----------------------------------------------------------

Review request for ranger, Don Bosco Durai and Madhan Neethiraj.


Bugs: RANGER-764
    https://issues.apache.org/jira/browse/RANGER-764


Repository: ranger


Description
-------

1. Added 2 new access types to service def that had previously been added in code via RANGER-737.  Both the new types are also added to the implied list of the kafka_admin access type since that is the all encompassing access type meant for broker-user.
2. Added some logging.


Diffs
-----

  agents-common/src/main/resources/service-defs/ranger-servicedef-kafka.json bf7a4df 
  plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java 7ca12ce 
  ranger-kafka-plugin-shim/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java 90b1ab0 

Diff: https://reviews.apache.org/r/40959/diff/


Testing
-------

1. Userd REST API to update the service-def of kafka.
2. Tested kafka on a secure and non-secure cluster against regression of functionality.
3. Validated new logging information.


Thanks,

Alok Lal


Re: Review Request 40959: Kafka plugin: new operation types supported by kafaka plugin code should be added to service definition.

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40959/#review108952
-----------------------------------------------------------

Ship it!


Ship It!

- Madhan Neethiraj


On Dec. 4, 2015, 8:41 a.m., Alok Lal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40959/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2015, 8:41 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai and Madhan Neethiraj.
> 
> 
> Bugs: RANGER-764
>     https://issues.apache.org/jira/browse/RANGER-764
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> 1. Added 2 new access types to service def that had previously been added in code via RANGER-737.  Both the new types are also added to the implied list of the kafka_admin access type since that is the all encompassing access type meant for broker-user.
> 2. Added some logging.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-kafka.json bf7a4df 
>   plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java 7ca12ce 
>   ranger-kafka-plugin-shim/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java 90b1ab0 
> 
> Diff: https://reviews.apache.org/r/40959/diff/
> 
> 
> Testing
> -------
> 
> 1. Userd REST API to update the service-def of kafka.
> 2. Tested kafka on a secure and non-secure cluster against regression of functionality.
> 3. Validated new logging information.
> 
> 
> Thanks,
> 
> Alok Lal
> 
>