[GitHub] [unomi] fpapon commented on a change in pull request #92: Fix for Jira UNOMI-238

[GitBox <gi...@apache.org>]

fpapon commented on a change in pull request #92: Fix for Jira UNOMI-238
URL: https://github.com/apache/unomi/pull/92#discussion_r302909901
 
 

 ##########
 File path: services/src/main/java/org/apache/unomi/services/services/ProfileServiceImpl.java
 ##########
 @@ -997,6 +997,9 @@ public void bundleChanged(BundleEvent event) {
     private boolean merge(Map<String, Object> target, Map<String, Object> object) {
         boolean changed = false;
         for (Map.Entry<String, Object> newEntry : object.entrySet()) {
+
+            String packageName = newEntry.getValue().getClass().getPackage().getName();
 
 Review comment:
   @micheleriva if `newEntry.getValue()` is null, it will throw a NPE.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services