You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "David Bernhard (JIRA)" <ji...@codehaus.org> on 2008/04/24 09:36:04 UTC
[jira] Created: (MNG-3545) Option -P-profile overridden if profile
is activebyDefault
Option -P-profile overridden if profile is activebyDefault
----------------------------------------------------------
Key: MNG-3545
URL: http://jira.codehaus.org/browse/MNG-3545
Project: Maven 2
Issue Type: Bug
Components: Profiles
Affects Versions: 2.0.9
Reporter: David Bernhard
Priority: Minor
Attachments: maven-profile-bug.zip
In maven 2.0.9, deactivating a profile "foo" that is declared and marked activeByDefault in the local POM does not work, as in DefaultProfileManager.java:227 all activeByDefault profiles are added if no profile is explicitly given ("-Pbar").
In the attached zip, run
mvn -P-foo help:active-profiles
and note that foo *is* active.
The patch fixes these issues by checking all default-activated profiles against the exclusions list when they are added "by default".
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-3545) Option -P-profile overridden if
profile is activebyDefault
Posted by "David Bernhard (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=132450#action_132450 ]
David Bernhard commented on MNG-3545:
-------------------------------------
While making the patch for trunk : Is it intentional that the roles of + and - are swapped, i.e. *+foo* _deactivates_ foo yet -foo *activates* it?
> Option -P-profile overridden if profile is activebyDefault
> ----------------------------------------------------------
>
> Key: MNG-3545
> URL: http://jira.codehaus.org/browse/MNG-3545
> Project: Maven 2
> Issue Type: Bug
> Components: Profiles
> Affects Versions: 2.0.9
> Reporter: David Bernhard
> Priority: Minor
> Attachments: maven-profile-bug.zip
>
>
> In maven 2.0.9, deactivating a profile "foo" that is declared and marked activeByDefault in the local POM does not work, as in DefaultProfileManager.java:227 all activeByDefault profiles are added if no profile is explicitly given ("-Pbar").
> In the attached zip, run
> mvn -P-foo help:active-profiles
> and note that foo *is* active.
> The patch fixes these issues by checking all default-activated profiles against the exclusions list when they are added "by default".
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-3545) Option -P-profile overridden if
profile is activebyDefault
Posted by "Paul Gier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=133233#action_133233 ]
Paul Gier commented on MNG-3545:
--------------------------------
Yes,{{+}} or nothing for activate and {{-}} for deactivate, that is my understanding.
I'll test 2.1 also to make sure that the behaviour is the same.
> Option -P-profile overridden if profile is activebyDefault
> ----------------------------------------------------------
>
> Key: MNG-3545
> URL: http://jira.codehaus.org/browse/MNG-3545
> Project: Maven 2
> Issue Type: Bug
> Components: Profiles
> Affects Versions: 2.0.9
> Reporter: David Bernhard
> Assignee: Paul Gier
> Priority: Minor
> Fix For: 2.0.10
>
> Attachments: maven-profile-bug.zip, MNG-3545-profiles.patch
>
>
> In maven 2.0.9, deactivating a profile "foo" that is declared and marked activeByDefault in the local POM does not work, as in DefaultProfileManager.java:227 all activeByDefault profiles are added if no profile is explicitly given ("-Pbar").
> In the attached zip, run
> mvn -P-foo help:active-profiles
> and note that foo *is* active.
> The patch fixes these issues by checking all default-activated profiles against the exclusions list when they are added "by default".
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3545) Option -P-profile overridden if profile
is activebyDefault
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Fox updated MNG-3545:
---------------------------
Fix Version/s: 2.0.10
> Option -P-profile overridden if profile is activebyDefault
> ----------------------------------------------------------
>
> Key: MNG-3545
> URL: http://jira.codehaus.org/browse/MNG-3545
> Project: Maven 2
> Issue Type: Bug
> Components: Profiles
> Affects Versions: 2.0.9
> Reporter: David Bernhard
> Priority: Minor
> Fix For: 2.0.10
>
> Attachments: maven-profile-bug.zip, MNG-3545-profiles.patch
>
>
> In maven 2.0.9, deactivating a profile "foo" that is declared and marked activeByDefault in the local POM does not work, as in DefaultProfileManager.java:227 all activeByDefault profiles are added if no profile is explicitly given ("-Pbar").
> In the attached zip, run
> mvn -P-foo help:active-profiles
> and note that foo *is* active.
> The patch fixes these issues by checking all default-activated profiles against the exclusions list when they are added "by default".
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-3545) Option -P-profile overridden if
profile is activebyDefault
Posted by "Paul Benedict (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=133229#action_133229 ]
Paul Benedict commented on MNG-3545:
------------------------------------
I hope + (or nothing at all) means activate, and - means deactivate.
> Option -P-profile overridden if profile is activebyDefault
> ----------------------------------------------------------
>
> Key: MNG-3545
> URL: http://jira.codehaus.org/browse/MNG-3545
> Project: Maven 2
> Issue Type: Bug
> Components: Profiles
> Affects Versions: 2.0.9
> Reporter: David Bernhard
> Assignee: Paul Gier
> Priority: Minor
> Fix For: 2.0.10
>
> Attachments: maven-profile-bug.zip, MNG-3545-profiles.patch
>
>
> In maven 2.0.9, deactivating a profile "foo" that is declared and marked activeByDefault in the local POM does not work, as in DefaultProfileManager.java:227 all activeByDefault profiles are added if no profile is explicitly given ("-Pbar").
> In the attached zip, run
> mvn -P-foo help:active-profiles
> and note that foo *is* active.
> The patch fixes these issues by checking all default-activated profiles against the exclusions list when they are added "by default".
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3545) Option -P-profile overridden if profile
is activebyDefault
Posted by "David Bernhard (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Bernhard updated MNG-3545:
--------------------------------
Attachment: MNG-3545-profiles.patch
The patch file. The technique works for 2.0.9 too; in 2.1 use "-P+foo" to turn _off_ foo with this patch.
> Option -P-profile overridden if profile is activebyDefault
> ----------------------------------------------------------
>
> Key: MNG-3545
> URL: http://jira.codehaus.org/browse/MNG-3545
> Project: Maven 2
> Issue Type: Bug
> Components: Profiles
> Affects Versions: 2.0.9
> Reporter: David Bernhard
> Priority: Minor
> Attachments: maven-profile-bug.zip, MNG-3545-profiles.patch
>
>
> In maven 2.0.9, deactivating a profile "foo" that is declared and marked activeByDefault in the local POM does not work, as in DefaultProfileManager.java:227 all activeByDefault profiles are added if no profile is explicitly given ("-Pbar").
> In the attached zip, run
> mvn -P-foo help:active-profiles
> and note that foo *is* active.
> The patch fixes these issues by checking all default-activated profiles against the exclusions list when they are added "by default".
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MNG-3545) Option -P-profile overridden if profile
is activebyDefault
Posted by "Paul Gier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Gier closed MNG-3545.
--------------------------
Resolution: Fixed
Fix Version/s: 2.1-alpha-1
I added an integration test for this and it seems to be working correctly now.
> Option -P-profile overridden if profile is activebyDefault
> ----------------------------------------------------------
>
> Key: MNG-3545
> URL: http://jira.codehaus.org/browse/MNG-3545
> Project: Maven 2
> Issue Type: Bug
> Components: Profiles
> Affects Versions: 2.0.9
> Reporter: David Bernhard
> Assignee: Paul Gier
> Priority: Minor
> Fix For: 2.0.10, 2.1-alpha-1
>
> Attachments: maven-profile-bug.zip, MNG-3545-profiles.patch
>
>
> In maven 2.0.9, deactivating a profile "foo" that is declared and marked activeByDefault in the local POM does not work, as in DefaultProfileManager.java:227 all activeByDefault profiles are added if no profile is explicitly given ("-Pbar").
> In the attached zip, run
> mvn -P-foo help:active-profiles
> and note that foo *is* active.
> The patch fixes these issues by checking all default-activated profiles against the exclusions list when they are added "by default".
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Work started: (MNG-3545) Option -P-profile overridden if
profile is activebyDefault
Posted by "Paul Gier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on MNG-3545 started by Paul Gier.
> Option -P-profile overridden if profile is activebyDefault
> ----------------------------------------------------------
>
> Key: MNG-3545
> URL: http://jira.codehaus.org/browse/MNG-3545
> Project: Maven 2
> Issue Type: Bug
> Components: Profiles
> Affects Versions: 2.0.9
> Reporter: David Bernhard
> Assignee: Paul Gier
> Priority: Minor
> Fix For: 2.0.10
>
> Attachments: maven-profile-bug.zip, MNG-3545-profiles.patch
>
>
> In maven 2.0.9, deactivating a profile "foo" that is declared and marked activeByDefault in the local POM does not work, as in DefaultProfileManager.java:227 all activeByDefault profiles are added if no profile is explicitly given ("-Pbar").
> In the attached zip, run
> mvn -P-foo help:active-profiles
> and note that foo *is* active.
> The patch fixes these issues by checking all default-activated profiles against the exclusions list when they are added "by default".
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MNG-3545) Option -P-profile
overridden if profile is activebyDefault
Posted by "Paul Benedict (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=133229#action_133229 ]
paul4christ79 edited comment on MNG-3545 at 5/1/08 12:34 PM:
-------------------------------------------------------------
I hope + (or nothing at all) means activate, and - means deactivate. It's just natural to understand the minus sign as subtraction, in which you are taking away something that already exists.
was (Author: paul4christ79):
I hope + (or nothing at all) means activate, and - means deactivate.
> Option -P-profile overridden if profile is activebyDefault
> ----------------------------------------------------------
>
> Key: MNG-3545
> URL: http://jira.codehaus.org/browse/MNG-3545
> Project: Maven 2
> Issue Type: Bug
> Components: Profiles
> Affects Versions: 2.0.9
> Reporter: David Bernhard
> Assignee: Paul Gier
> Priority: Minor
> Fix For: 2.0.10
>
> Attachments: maven-profile-bug.zip, MNG-3545-profiles.patch
>
>
> In maven 2.0.9, deactivating a profile "foo" that is declared and marked activeByDefault in the local POM does not work, as in DefaultProfileManager.java:227 all activeByDefault profiles are added if no profile is explicitly given ("-Pbar").
> In the attached zip, run
> mvn -P-foo help:active-profiles
> and note that foo *is* active.
> The patch fixes these issues by checking all default-activated profiles against the exclusions list when they are added "by default".
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira