You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "umustafi (via GitHub)" <gi...@apache.org> on 2023/12/21 20:40:02 UTC
[PR] [GOBBLIN-1978] Initialize dag action store monitor metrics [gobblin]
umustafi opened a new pull request, #3851:
URL: https://github.com/apache/gobblin/pull/3851
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1978
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [GOBBLIN-1978] Initialize dag action store monitor metrics [gobblin]
Posted by "umustafi (via GitHub)" <gi...@apache.org>.
umustafi commented on code in PR #3851:
URL: https://github.com/apache/gobblin/pull/3851#discussion_r1435248873
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/DagActionStoreChangeMonitor.java:
##########
@@ -136,6 +142,23 @@ protected void initializeMonitor() {
}
}
+ /*
+ Override this method to do the same sequence as the parent class, except create metrics. Instead, we create metrics
+ earlier upon class initialization because they are used immediately as dag actions are loaded and processed from
+ the DagActionStore.
+ */
+ @Override
+ protected void startUp() {
Review Comment:
A lot of existing tests need to be refactored if I do this and may end up having some unintended consequences bc HighLevelConsumer is used in many places. I'd rather not invest the time updating tests and debugging changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [GOBBLIN-1978] Initialize dag action store monitor metrics [gobblin]
Posted by "arjun4084346 (via GitHub)" <gi...@apache.org>.
arjun4084346 merged PR #3851:
URL: https://github.com/apache/gobblin/pull/3851
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [GOBBLIN-1978] Initialize dag action store monitor metrics [gobblin]
Posted by "umustafi (via GitHub)" <gi...@apache.org>.
umustafi commented on PR #3851:
URL: https://github.com/apache/gobblin/pull/3851#issuecomment-1867065923
checks on my fork https://github.com/umustafi/gobblin/pull/15/checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [GOBBLIN-1978] Initialize dag action store monitor metrics [gobblin]
Posted by "arjun4084346 (via GitHub)" <gi...@apache.org>.
arjun4084346 commented on code in PR #3851:
URL: https://github.com/apache/gobblin/pull/3851#discussion_r1435221314
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/DagActionStoreChangeMonitor.java:
##########
@@ -136,6 +142,23 @@ protected void initializeMonitor() {
}
}
+ /*
+ Override this method to do the same sequence as the parent class, except create metrics. Instead, we create metrics
+ earlier upon class initialization because they are used immediately as dag actions are loaded and processed from
+ the DagActionStore.
+ */
+ @Override
+ protected void startUp() {
Review Comment:
Can we just move buildMetricsContextAndMetrics() to the constructor of HighLevelConsumer and avoid overriding startUp?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [GOBBLIN-1978] Initialize dag action store monitor metrics [gobblin]
Posted by "umustafi (via GitHub)" <gi...@apache.org>.
umustafi commented on PR #3851:
URL: https://github.com/apache/gobblin/pull/3851#issuecomment-1867927129
> Can we just move buildMetricsContextAndMetrics() to the constructor of HighLevelConsumer and avoid overriding startUp?
A lot of existing tests need to be refactored if I do this and may end up having some unintended consequences I don't want to cause right now. I want to verify if this is the only issue first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org