You are viewing a plain text version of this content. The canonical link for it is here.
Posted to ftpserver-dev@incubator.apache.org by "Clinton Foster (JIRA)" <ji...@apache.org> on 2006/11/28 23:17:21 UTC

[jira] Created: (FTPSERVER-53) Support specifying a range of passive ports

Support specifying a range of passive ports
-------------------------------------------

                 Key: FTPSERVER-53
                 URL: http://issues.apache.org/jira/browse/FTPSERVER-53
             Project: FtpServer
          Issue Type: Improvement
            Reporter: Clinton Foster


The config.data-connection.passive.ports configuration parameter allows specifying either 0 (any available port) or a comma-separated list of ports. But passive mode is increasingly becoming the standard these days, and it isn't practical to specify all the ports needed for a reasonable number of simultaneous passive connections in a comma-separated list. I believe most FTP server administrators expect to be able to specify a range of ports.

It would probably be sufficient to assume if the configuration string contains a dash, it specifies a range instead of a list. Even better would be to allow a comma-separated list of multiple ranges and/or individual ports, e.g. 1025-2025,5055-6000,2323.  But initially I think it would be sufficient to support only a single range. In other words, if the value contains a dash anywhere in the string, assume it is a range of ports. (If multiple ranges are needed, support for this could easily be added later without breaking existing configurations.)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (FTPSERVER-53) Support specifying a range of passive ports

Posted by "Clint Foster (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/FTPSERVER-53?page=comments#action_12461511 ] 
            
Clint Foster commented on FTPSERVER-53:
---------------------------------------

This looks very good. I am anxious to integrate it into our product once I
am back in the office next week!

Clint



> Support specifying a range of passive ports
> -------------------------------------------
>
>                 Key: FTPSERVER-53
>                 URL: http://issues.apache.org/jira/browse/FTPSERVER-53
>             Project: FtpServer
>          Issue Type: Improvement
>            Reporter: Clinton Foster
>         Assigned To: Niklas Gustavsson
>
> The config.data-connection.passive.ports configuration parameter allows specifying either 0 (any available port) or a comma-separated list of ports. But passive mode is increasingly becoming the standard these days, and it isn't practical to specify all the ports needed for a reasonable number of simultaneous passive connections in a comma-separated list. I believe most FTP server administrators expect to be able to specify a range of ports.
> It would probably be sufficient to assume if the configuration string contains a dash, it specifies a range instead of a list. Even better would be to allow a comma-separated list of multiple ranges and/or individual ports, e.g. 1025-2025,5055-6000,2323.  But initially I think it would be sufficient to support only a single range. In other words, if the value contains a dash anywhere in the string, assume it is a range of ports. (If multiple ranges are needed, support for this could easily be added later without breaking existing configurations.)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (FTPSERVER-53) Support specifying a range of passive ports

Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/FTPSERVER-53?page=comments#action_12461250 ] 
            
Niklas Gustavsson commented on FTPSERVER-53:
--------------------------------------------

commit -m "Refactored parsing and reservation of passive ports into its own class. This is the first step towards solving FTPSERVER-53" C:/home/niklas/workspaces/apache/ftpserver/core/src/java/org/apache/ftpserver/DefaultDataConnectionConfig.java C:/home/niklas/workspaces/apache/ftpserver/core/src/java/org/apache/ftpserver/DefaultListener.java C:/home/niklas/workspaces/apache/ftpserver/core/src/java/org/apache/ftpserver/Listener.java C:/home/niklas/workspaces/apache/ftpserver/core/src/java/org/apache/ftpserver/PassivePorts.java C:/home/niklas/workspaces/apache/ftpserver/core/src/java/org/apache/ftpserver/RequestHandler.java C:/home/niklas/workspaces/apache/ftpserver/core/src/test/org/apache/ftpserver/PassivePortsTest.java
    Sending        C:/home/niklas/workspaces/apache/ftpserver/core/src/java/org/apache/ftpserver/DefaultDataConnectionConfig.java
    Sending        C:/home/niklas/workspaces/apache/ftpserver/core/src/java/org/apache/ftpserver/DefaultListener.java
    Sending        C:/home/niklas/workspaces/apache/ftpserver/core/src/java/org/apache/ftpserver/Listener.java
    Adding         C:/home/niklas/workspaces/apache/ftpserver/core/src/java/org/apache/ftpserver/PassivePorts.java
    Sending        C:/home/niklas/workspaces/apache/ftpserver/core/src/java/org/apache/ftpserver/RequestHandler.java
    Adding         C:/home/niklas/workspaces/apache/ftpserver/core/src/test/org/apache/ftpserver/PassivePortsTest.java
    Transmitting file data ...
    Committed revision 490790.

> Support specifying a range of passive ports
> -------------------------------------------
>
>                 Key: FTPSERVER-53
>                 URL: http://issues.apache.org/jira/browse/FTPSERVER-53
>             Project: FtpServer
>          Issue Type: Improvement
>            Reporter: Clinton Foster
>
> The config.data-connection.passive.ports configuration parameter allows specifying either 0 (any available port) or a comma-separated list of ports. But passive mode is increasingly becoming the standard these days, and it isn't practical to specify all the ports needed for a reasonable number of simultaneous passive connections in a comma-separated list. I believe most FTP server administrators expect to be able to specify a range of ports.
> It would probably be sufficient to assume if the configuration string contains a dash, it specifies a range instead of a list. Even better would be to allow a comma-separated list of multiple ranges and/or individual ports, e.g. 1025-2025,5055-6000,2323.  But initially I think it would be sufficient to support only a single range. In other words, if the value contains a dash anywhere in the string, assume it is a range of ports. (If multiple ranges are needed, support for this could easily be added later without breaking existing configurations.)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (FTPSERVER-53) Support specifying a range of passive ports

Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/FTPSERVER-53?page=comments#action_12461485 ] 
            
Niklas Gustavsson commented on FTPSERVER-53:
--------------------------------------------

commit -m "Adding support for specifying passive port ranges. All combinations of single ports, multiple ports and ranges (both open ended and closed) are supported. The current implementation is somewhat naive and can be improved for better performance and memory usage in the future" C:/home/niklas/workspaces/apache/ftpserver/core/src/java/org/apache/ftpserver/PassivePorts.java C:/home/niklas/workspaces/apache/ftpserver/core/src/test/org/apache/ftpserver/PassivePortsTest.java
    Sending        C:/home/niklas/workspaces/apache/ftpserver/core/src/java/org/apache/ftpserver/PassivePorts.java
    Sending        C:/home/niklas/workspaces/apache/ftpserver/core/src/test/org/apache/ftpserver/PassivePortsTest.java
    Transmitting file data ...
    Committed revision 491204.

> Support specifying a range of passive ports
> -------------------------------------------
>
>                 Key: FTPSERVER-53
>                 URL: http://issues.apache.org/jira/browse/FTPSERVER-53
>             Project: FtpServer
>          Issue Type: Improvement
>            Reporter: Clinton Foster
>
> The config.data-connection.passive.ports configuration parameter allows specifying either 0 (any available port) or a comma-separated list of ports. But passive mode is increasingly becoming the standard these days, and it isn't practical to specify all the ports needed for a reasonable number of simultaneous passive connections in a comma-separated list. I believe most FTP server administrators expect to be able to specify a range of ports.
> It would probably be sufficient to assume if the configuration string contains a dash, it specifies a range instead of a list. Even better would be to allow a comma-separated list of multiple ranges and/or individual ports, e.g. 1025-2025,5055-6000,2323.  But initially I think it would be sufficient to support only a single range. In other words, if the value contains a dash anywhere in the string, assume it is a range of ports. (If multiple ranges are needed, support for this could easily be added later without breaking existing configurations.)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Closed: (FTPSERVER-53) Support specifying a range of passive ports

Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/FTPSERVER-53?page=all ]

Niklas Gustavsson closed FTPSERVER-53.
--------------------------------------

    Resolution: Fixed
      Assignee: Niklas Gustavsson

Fixed. The current implementation is pretty naive but does the job. It supports listing a port values (as before) as well as both closed and open ended ranges. So, for example:
1,2,3
1-3
-3
1,2,3-8

> Support specifying a range of passive ports
> -------------------------------------------
>
>                 Key: FTPSERVER-53
>                 URL: http://issues.apache.org/jira/browse/FTPSERVER-53
>             Project: FtpServer
>          Issue Type: Improvement
>            Reporter: Clinton Foster
>         Assigned To: Niklas Gustavsson
>
> The config.data-connection.passive.ports configuration parameter allows specifying either 0 (any available port) or a comma-separated list of ports. But passive mode is increasingly becoming the standard these days, and it isn't practical to specify all the ports needed for a reasonable number of simultaneous passive connections in a comma-separated list. I believe most FTP server administrators expect to be able to specify a range of ports.
> It would probably be sufficient to assume if the configuration string contains a dash, it specifies a range instead of a list. Even better would be to allow a comma-separated list of multiple ranges and/or individual ports, e.g. 1025-2025,5055-6000,2323.  But initially I think it would be sufficient to support only a single range. In other words, if the value contains a dash anywhere in the string, assume it is a range of ports. (If multiple ranges are needed, support for this could easily be added later without breaking existing configurations.)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (FTPSERVER-53) Support specifying a range of passive ports

Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/FTPSERVER-53?page=comments#action_12461516 ] 
            
Niklas Gustavsson commented on FTPSERVER-53:
--------------------------------------------

Great! If you need anything further, please let me know.

> Support specifying a range of passive ports
> -------------------------------------------
>
>                 Key: FTPSERVER-53
>                 URL: http://issues.apache.org/jira/browse/FTPSERVER-53
>             Project: FtpServer
>          Issue Type: Improvement
>            Reporter: Clinton Foster
>         Assigned To: Niklas Gustavsson
>
> The config.data-connection.passive.ports configuration parameter allows specifying either 0 (any available port) or a comma-separated list of ports. But passive mode is increasingly becoming the standard these days, and it isn't practical to specify all the ports needed for a reasonable number of simultaneous passive connections in a comma-separated list. I believe most FTP server administrators expect to be able to specify a range of ports.
> It would probably be sufficient to assume if the configuration string contains a dash, it specifies a range instead of a list. Even better would be to allow a comma-separated list of multiple ranges and/or individual ports, e.g. 1025-2025,5055-6000,2323.  But initially I think it would be sufficient to support only a single range. In other words, if the value contains a dash anywhere in the string, assume it is a range of ports. (If multiple ranges are needed, support for this could easily be added later without breaking existing configurations.)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira