[GitHub] [incubator-pinot] sunithabeeram commented on a change in pull request #3913: Adding the support for sampling logs

[GitBox <gi...@apache.org>]

sunithabeeram commented on a change in pull request #3913: Adding the support for sampling logs
URL: https://github.com/apache/incubator-pinot/pull/3913#discussion_r263214149
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/query/scheduler/QueryScheduler.java
 ##########
 @@ -48,9 +51,13 @@
  */
 public abstract class QueryScheduler {
   private static final Logger LOGGER = LoggerFactory.getLogger(QueryScheduler.class);
+
   private static final String INVALID_NUM_SCANNED = "-1";
   private static final String INVALID_SEGMENTS_COUNT = "-1";
+  private static final String QUERY_LOG_MAX_RATE_KEY = "query_log_max_rate";
 
 Review comment:
   Indicate timeunit. Should the key be "query.log.max.rate" (to conform with other keys we have)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org