You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by Jean-Baptiste Onofré <jb...@nanthrax.net> on 2022/03/07 17:24:51 UTC
[VOTE] Apache ActiveMQ 5.17.0 release
Hi guys,
*Finally*, after several weeks waiting, I'm pleased to submit Apache
ActiveMQ 5.17.0 release to your vote.
This release is an important milestone in ActiveMQ roadmap, including 200
issues, especially:
- support Spring 5.x
- support log4j 2.x (2.17.1)
- JDK 11+ support for both build and runtime
- remove of activemq-camel component (replaced by camel-activemq and
camel-jms components)
- remove leveldb
- tons of fixes and dependency updates
Please take a look on the Release Notes for details:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12346476
Maven Staging Repository:
https://repository.apache.org/content/repositories/orgapacheactivemq-1247/
Dist Staging Repository:
https://dist.apache.org/repos/dist/dev/activemq/activemq/5.17.0/
Git tag: activemq-5.17.0
Please vote to approve this release:
[ ] +1 Approve the release
[ ] -1 Don't approve the release (please provide specific comments)
This vote will be open for at least 72 hours.
Thanks !
Regards
JB
Re: [VOTE] Apache ActiveMQ 5.17.0 release
Posted by Christopher Shannon <ch...@gmail.com>.
+1, Everything looks good.
I went through all the test failures and there are no issues that require
cancelling the vote (just some problems with a couple tests themselves,
flaky tests, and one spec jar problem that is an optional jar that only
affects tests so that can be fixed in 5.17.1 or 5.18.0).
* Validated signatures and checksums
* Verified broken tests in CI were not an issue
* Check source licenses using apache rat
* Built from source and ran through more tests
* Ran through a custom test suite
* Ran a broker from the binary package
On Mon, Mar 7, 2022 at 7:34 PM Christopher Shannon <
christopher.l.shannon@gmail.com> wrote:
> I would hold off cancelling the vote just yet.
>
> I did some digging into some of the test failures and one was an issue
> with the test itself (DurableFiveBrokerNetworkBridgeTest) after refactoring
> that needs fixing so don't need to cancel for that :
> https://github.com/apache/activemq/pull/794
>
> I also looked at AMQ5212Test and that is only broken in main due to JMS
> 2.0 changes so it's not broken in 5.17.0.
>
> I will continue to look at the other failures in the morning. We only
> really need to cancel if there's a real regression. The fix for
> DurableFiveBrokerNetworkBridgeTest can be merged into 5.17.1 if there are
> no other issues.
>
> On Mon, Mar 7, 2022 at 3:43 PM Christopher Shannon <
> christopher.l.shannon@gmail.com> wrote:
>
>> JB,
>>
>> Looks like we will need to cancel the vote as there are some real test
>> failures on main branch in CI:
>> https://builds.apache.org/job/ActiveMQ/job/ActiveMQ/job/main/114/#showFailuresLink
>>
>> Unfortunately the quick test profile got activated on main but not
>> backported to 5.17.x by mistake so the tests didn't get run to catch the
>> issues.
>>
>> Once we sort the failures that are real (vs flaky tests) we can re-do the
>> release
>>
>> On Mon, Mar 7, 2022 at 12:25 PM Jean-Baptiste Onofré <jb...@nanthrax.net>
>> wrote:
>>
>>> Hi guys,
>>>
>>> *Finally*, after several weeks waiting, I'm pleased to submit Apache
>>> ActiveMQ 5.17.0 release to your vote.
>>>
>>> This release is an important milestone in ActiveMQ roadmap, including 200
>>> issues, especially:
>>> - support Spring 5.x
>>> - support log4j 2.x (2.17.1)
>>> - JDK 11+ support for both build and runtime
>>> - remove of activemq-camel component (replaced by camel-activemq and
>>> camel-jms components)
>>> - remove leveldb
>>> - tons of fixes and dependency updates
>>>
>>> Please take a look on the Release Notes for details:
>>>
>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12346476
>>>
>>> Maven Staging Repository:
>>>
>>> https://repository.apache.org/content/repositories/orgapacheactivemq-1247/
>>>
>>> Dist Staging Repository:
>>> https://dist.apache.org/repos/dist/dev/activemq/activemq/5.17.0/
>>>
>>> Git tag: activemq-5.17.0
>>>
>>> Please vote to approve this release:
>>> [ ] +1 Approve the release
>>> [ ] -1 Don't approve the release (please provide specific comments)
>>>
>>> This vote will be open for at least 72 hours.
>>>
>>> Thanks !
>>> Regards
>>> JB
>>>
>>
Re: [VOTE] Apache ActiveMQ 5.17.0 release
Posted by Christopher Shannon <ch...@gmail.com>.
I would hold off cancelling the vote just yet.
I did some digging into some of the test failures and one was an issue with
the test itself (DurableFiveBrokerNetworkBridgeTest) after refactoring that
needs fixing so don't need to cancel for that :
https://github.com/apache/activemq/pull/794
I also looked at AMQ5212Test and that is only broken in main due to JMS 2.0
changes so it's not broken in 5.17.0.
I will continue to look at the other failures in the morning. We only
really need to cancel if there's a real regression. The fix for
DurableFiveBrokerNetworkBridgeTest can be merged into 5.17.1 if there are
no other issues.
On Mon, Mar 7, 2022 at 3:43 PM Christopher Shannon <
christopher.l.shannon@gmail.com> wrote:
> JB,
>
> Looks like we will need to cancel the vote as there are some real test
> failures on main branch in CI:
> https://builds.apache.org/job/ActiveMQ/job/ActiveMQ/job/main/114/#showFailuresLink
>
> Unfortunately the quick test profile got activated on main but not
> backported to 5.17.x by mistake so the tests didn't get run to catch the
> issues.
>
> Once we sort the failures that are real (vs flaky tests) we can re-do the
> release
>
> On Mon, Mar 7, 2022 at 12:25 PM Jean-Baptiste Onofré <jb...@nanthrax.net>
> wrote:
>
>> Hi guys,
>>
>> *Finally*, after several weeks waiting, I'm pleased to submit Apache
>> ActiveMQ 5.17.0 release to your vote.
>>
>> This release is an important milestone in ActiveMQ roadmap, including 200
>> issues, especially:
>> - support Spring 5.x
>> - support log4j 2.x (2.17.1)
>> - JDK 11+ support for both build and runtime
>> - remove of activemq-camel component (replaced by camel-activemq and
>> camel-jms components)
>> - remove leveldb
>> - tons of fixes and dependency updates
>>
>> Please take a look on the Release Notes for details:
>>
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12346476
>>
>> Maven Staging Repository:
>> https://repository.apache.org/content/repositories/orgapacheactivemq-1247/
>>
>> Dist Staging Repository:
>> https://dist.apache.org/repos/dist/dev/activemq/activemq/5.17.0/
>>
>> Git tag: activemq-5.17.0
>>
>> Please vote to approve this release:
>> [ ] +1 Approve the release
>> [ ] -1 Don't approve the release (please provide specific comments)
>>
>> This vote will be open for at least 72 hours.
>>
>> Thanks !
>> Regards
>> JB
>>
>
Re: [VOTE] Apache ActiveMQ 5.17.0 release
Posted by Christopher Shannon <ch...@gmail.com>.
JB,
Looks like we will need to cancel the vote as there are some real test
failures on main branch in CI:
https://builds.apache.org/job/ActiveMQ/job/ActiveMQ/job/main/114/#showFailuresLink
Unfortunately the quick test profile got activated on main but not
backported to 5.17.x by mistake so the tests didn't get run to catch the
issues.
Once we sort the failures that are real (vs flaky tests) we can re-do the
release
On Mon, Mar 7, 2022 at 12:25 PM Jean-Baptiste Onofré <jb...@nanthrax.net>
wrote:
> Hi guys,
>
> *Finally*, after several weeks waiting, I'm pleased to submit Apache
> ActiveMQ 5.17.0 release to your vote.
>
> This release is an important milestone in ActiveMQ roadmap, including 200
> issues, especially:
> - support Spring 5.x
> - support log4j 2.x (2.17.1)
> - JDK 11+ support for both build and runtime
> - remove of activemq-camel component (replaced by camel-activemq and
> camel-jms components)
> - remove leveldb
> - tons of fixes and dependency updates
>
> Please take a look on the Release Notes for details:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12346476
>
> Maven Staging Repository:
> https://repository.apache.org/content/repositories/orgapacheactivemq-1247/
>
> Dist Staging Repository:
> https://dist.apache.org/repos/dist/dev/activemq/activemq/5.17.0/
>
> Git tag: activemq-5.17.0
>
> Please vote to approve this release:
> [ ] +1 Approve the release
> [ ] -1 Don't approve the release (please provide specific comments)
>
> This vote will be open for at least 72 hours.
>
> Thanks !
> Regards
> JB
>
[CANCEL][VOTE] Apache ActiveMQ 5.17.0 release
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Hi guys,
due to AMQ-8533, I cancel this vote to prepare a new take.
The new take will include geronimo jar update and fix for AMQ-8533.
I will submit the release to vote tomorrow morning (my time).
Regards
JB
On Mon, Mar 7, 2022 at 6:24 PM Jean-Baptiste Onofré <jb...@nanthrax.net> wrote:
> Hi guys,
>
> *Finally*, after several weeks waiting, I'm pleased to submit Apache
> ActiveMQ 5.17.0 release to your vote.
>
> This release is an important milestone in ActiveMQ roadmap, including 200
> issues, especially:
> - support Spring 5.x
> - support log4j 2.x (2.17.1)
> - JDK 11+ support for both build and runtime
> - remove of activemq-camel component (replaced by camel-activemq and
> camel-jms components)
> - remove leveldb
> - tons of fixes and dependency updates
>
> Please take a look on the Release Notes for details:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12346476
>
> Maven Staging Repository:
> https://repository.apache.org/content/repositories/orgapacheactivemq-1247/
>
> Dist Staging Repository:
> https://dist.apache.org/repos/dist/dev/activemq/activemq/5.17.0/
>
> Git tag: activemq-5.17.0
>
> Please vote to approve this release:
> [ ] +1 Approve the release
> [ ] -1 Don't approve the release (please provide specific comments)
>
> This vote will be open for at least 72 hours.
>
> Thanks !
> Regards
> JB
>
Re: [VOTE] Apache ActiveMQ 5.17.0 release
Posted by Guillaume Nodet <gn...@apache.org>.
+1
Le lun. 7 mars 2022 à 18:25, Jean-Baptiste Onofré <jb...@nanthrax.net> a
écrit :
> Hi guys,
>
> *Finally*, after several weeks waiting, I'm pleased to submit Apache
> ActiveMQ 5.17.0 release to your vote.
>
> This release is an important milestone in ActiveMQ roadmap, including 200
> issues, especially:
> - support Spring 5.x
> - support log4j 2.x (2.17.1)
> - JDK 11+ support for both build and runtime
> - remove of activemq-camel component (replaced by camel-activemq and
> camel-jms components)
> - remove leveldb
> - tons of fixes and dependency updates
>
> Please take a look on the Release Notes for details:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12346476
>
> Maven Staging Repository:
> https://repository.apache.org/content/repositories/orgapacheactivemq-1247/
>
> Dist Staging Repository:
> https://dist.apache.org/repos/dist/dev/activemq/activemq/5.17.0/
>
> Git tag: activemq-5.17.0
>
> Please vote to approve this release:
> [ ] +1 Approve the release
> [ ] -1 Don't approve the release (please provide specific comments)
>
> This vote will be open for at least 72 hours.
>
> Thanks !
> Regards
> JB
>
--
------------------------
Guillaume Nodet
Re: [VOTE] Apache ActiveMQ 5.17.0 release
Posted by Christopher Shannon <ch...@gmail.com>.
activemq-jms-pool also appears to be shaded. I didn't notice any other jars
but those 2 but we should double check them all i guess
On Wed, Mar 9, 2022 at 10:57 AM Jean-Baptiste Onofré <jb...@nanthrax.net>
wrote:
> Thanks for the update. Let me take a look to identify the change. I will
> then cancel the vote and fix Geronimo jar and ActiveMQ-pool artifact.
>
> Regards
> JB
>
> Le mer. 9 mars 2022 à 16:46, Christopher Shannon <
> christopher.l.shannon@gmail.com> a écrit :
>
> > Unfortunately I have to change my vote to -1.
> >
> > It looks like the activemq-pool jar is now shaded and pulling in a bunch
> of
> > other stuff. This caused my build to break as it pulled in the old
> > javax.annotation packages which broke due to:
> > https://issues.apache.org/jira/browse/AMQ-8530
> >
> > So I think we need to cancel the vote and fix the build so it's not
> shaded
> > (I assume it's an OSGi issue). We can also go ahead and merge in AMQ-8530
> > (and some other test fixes)
> >
> > On Tue, Mar 8, 2022 at 3:18 PM francois.papon <
> > francois.papon@openobject.fr>
> > wrote:
> >
> > > +1 (non-binding)Tested with some internal projects.Thanks
> > > JB!regardsFrançois
> > > -------- Message d'origine --------De : Jean-Baptiste Onofré <
> > > jb@nanthrax.net> Date : 07/03/2022 18:25 (GMT+01:00) À :
> > > dev@activemq.apache.org Objet : [VOTE] Apache ActiveMQ 5.17.0 release
> Hi
> > > guys,*Finally*, after several weeks waiting, I'm pleased to submit
> > > ApacheActiveMQ 5.17.0 release to your vote.This release is an important
> > > milestone in ActiveMQ roadmap, including 200issues, especially:-
> support
> > > Spring 5.x- support log4j 2.x (2.17.1)- JDK 11+ support for both build
> > and
> > > runtime- remove of activemq-camel component (replaced by camel-activemq
> > > andcamel-jms components)- remove leveldb- tons of fixes and dependency
> > > updatesPlease take a look on the Release Notes for details:
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12346476Maven
> > > Staging Repository:
> > >
> >
> https://repository.apache.org/content/repositories/orgapacheactivemq-1247/Dist
> > > Staging Repository:
> > > https://dist.apache.org/repos/dist/dev/activemq/activemq/5.17.0/Git
> tag:
> > > activemq-5.17.0Please vote to approve this release:[ ] +1 Approve the
> > > release[ ] -1 Don't approve the release (please provide specific
> > > comments)This vote will be open for at least 72 hours.Thanks !RegardsJB
> >
>
Re: [VOTE] Apache ActiveMQ 5.17.0 release
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Thanks for the update. Let me take a look to identify the change. I will
then cancel the vote and fix Geronimo jar and ActiveMQ-pool artifact.
Regards
JB
Le mer. 9 mars 2022 à 16:46, Christopher Shannon <
christopher.l.shannon@gmail.com> a écrit :
> Unfortunately I have to change my vote to -1.
>
> It looks like the activemq-pool jar is now shaded and pulling in a bunch of
> other stuff. This caused my build to break as it pulled in the old
> javax.annotation packages which broke due to:
> https://issues.apache.org/jira/browse/AMQ-8530
>
> So I think we need to cancel the vote and fix the build so it's not shaded
> (I assume it's an OSGi issue). We can also go ahead and merge in AMQ-8530
> (and some other test fixes)
>
> On Tue, Mar 8, 2022 at 3:18 PM francois.papon <
> francois.papon@openobject.fr>
> wrote:
>
> > +1 (non-binding)Tested with some internal projects.Thanks
> > JB!regardsFrançois
> > -------- Message d'origine --------De : Jean-Baptiste Onofré <
> > jb@nanthrax.net> Date : 07/03/2022 18:25 (GMT+01:00) À :
> > dev@activemq.apache.org Objet : [VOTE] Apache ActiveMQ 5.17.0 release Hi
> > guys,*Finally*, after several weeks waiting, I'm pleased to submit
> > ApacheActiveMQ 5.17.0 release to your vote.This release is an important
> > milestone in ActiveMQ roadmap, including 200issues, especially:- support
> > Spring 5.x- support log4j 2.x (2.17.1)- JDK 11+ support for both build
> and
> > runtime- remove of activemq-camel component (replaced by camel-activemq
> > andcamel-jms components)- remove leveldb- tons of fixes and dependency
> > updatesPlease take a look on the Release Notes for details:
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12346476Maven
> > Staging Repository:
> >
> https://repository.apache.org/content/repositories/orgapacheactivemq-1247/Dist
> > Staging Repository:
> > https://dist.apache.org/repos/dist/dev/activemq/activemq/5.17.0/Git tag:
> > activemq-5.17.0Please vote to approve this release:[ ] +1 Approve the
> > release[ ] -1 Don't approve the release (please provide specific
> > comments)This vote will be open for at least 72 hours.Thanks !RegardsJB
>
Re: [VOTE] Apache ActiveMQ 5.17.0 release
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
-1
due to the issue we found with Chris. I'm preparing a PR.
I gonna send another email to cancel this vote and prepare a new one.
Regards
JB
On Wed, Mar 9, 2022 at 8:17 PM Christopher Shannon <
christopher.l.shannon@gmail.com> wrote:
> JB narrowed the issue down to <Export-Package>*</Export-Package> as part of
> the bundle plugin inside of activemq-client, activemq-jms-pool,
> activemq-pool poms and is working on a PR now to fix it
>
> On Wed, Mar 9, 2022 at 12:56 PM Robbie Gemmell <ro...@gmail.com>
> wrote:
>
> > I would have voted positively had Chris not already found the issues
> > he did, which indeed seem like they need fixed.
> >
> > I checked things out as follows:
> > - Verified the signature + checksum files.
> > - Checked for LICENCE and NOTICE files present in the archives.
> > - Checked headers in the source archive with: mvn apache-rat:check
> > - Ran the source build, plus the AMQP integration tests, on JDK 11.
> > - Ran the Qpid JMS 1.5.0 HelloWorld against a broker started from the
> > tar.gz binary archive on JDK 11 and JDK 17.
> >
> > Robbie
> >
> > On Wed, 9 Mar 2022 at 15:46, Christopher Shannon
> > <ch...@gmail.com> wrote:
> > >
> > > Unfortunately I have to change my vote to -1.
> > >
> > > It looks like the activemq-pool jar is now shaded and pulling in a
> bunch
> > of
> > > other stuff. This caused my build to break as it pulled in the old
> > > javax.annotation packages which broke due to:
> > > https://issues.apache.org/jira/browse/AMQ-8530
> > >
> > > So I think we need to cancel the vote and fix the build so it's not
> > shaded
> > > (I assume it's an OSGi issue). We can also go ahead and merge in
> AMQ-8530
> > > (and some other test fixes)
> > >
> > > On Tue, Mar 8, 2022 at 3:18 PM francois.papon <
> > francois.papon@openobject.fr>
> > > wrote:
> > >
> > > > +1 (non-binding)Tested with some internal projects.Thanks
> > > > JB!regardsFrançois
> > > > -------- Message d'origine --------De : Jean-Baptiste Onofré <
> > > > jb@nanthrax.net> Date : 07/03/2022 18:25 (GMT+01:00) À :
> > > > dev@activemq.apache.org Objet : [VOTE] Apache ActiveMQ 5.17.0
> release
> > Hi
> > > > guys,*Finally*, after several weeks waiting, I'm pleased to submit
> > > > ApacheActiveMQ 5.17.0 release to your vote.This release is an
> important
> > > > milestone in ActiveMQ roadmap, including 200issues, especially:-
> > support
> > > > Spring 5.x- support log4j 2.x (2.17.1)- JDK 11+ support for both
> build
> > and
> > > > runtime- remove of activemq-camel component (replaced by
> camel-activemq
> > > > andcamel-jms components)- remove leveldb- tons of fixes and
> dependency
> > > > updatesPlease take a look on the Release Notes for details:
> > > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12346476Maven
> > > > Staging Repository:
> > > >
> >
> https://repository.apache.org/content/repositories/orgapacheactivemq-1247/Dist
> > > > Staging Repository:
> > > > https://dist.apache.org/repos/dist/dev/activemq/activemq/5.17.0/Git
> > tag:
> > > > activemq-5.17.0Please vote to approve this release:[ ] +1 Approve the
> > > > release[ ] -1 Don't approve the release (please provide specific
> > > > comments)This vote will be open for at least 72 hours.Thanks
> !RegardsJB
> >
>
Re: [VOTE] Apache ActiveMQ 5.17.0 release
Posted by Christopher Shannon <ch...@gmail.com>.
JB narrowed the issue down to <Export-Package>*</Export-Package> as part of
the bundle plugin inside of activemq-client, activemq-jms-pool,
activemq-pool poms and is working on a PR now to fix it
On Wed, Mar 9, 2022 at 12:56 PM Robbie Gemmell <ro...@gmail.com>
wrote:
> I would have voted positively had Chris not already found the issues
> he did, which indeed seem like they need fixed.
>
> I checked things out as follows:
> - Verified the signature + checksum files.
> - Checked for LICENCE and NOTICE files present in the archives.
> - Checked headers in the source archive with: mvn apache-rat:check
> - Ran the source build, plus the AMQP integration tests, on JDK 11.
> - Ran the Qpid JMS 1.5.0 HelloWorld against a broker started from the
> tar.gz binary archive on JDK 11 and JDK 17.
>
> Robbie
>
> On Wed, 9 Mar 2022 at 15:46, Christopher Shannon
> <ch...@gmail.com> wrote:
> >
> > Unfortunately I have to change my vote to -1.
> >
> > It looks like the activemq-pool jar is now shaded and pulling in a bunch
> of
> > other stuff. This caused my build to break as it pulled in the old
> > javax.annotation packages which broke due to:
> > https://issues.apache.org/jira/browse/AMQ-8530
> >
> > So I think we need to cancel the vote and fix the build so it's not
> shaded
> > (I assume it's an OSGi issue). We can also go ahead and merge in AMQ-8530
> > (and some other test fixes)
> >
> > On Tue, Mar 8, 2022 at 3:18 PM francois.papon <
> francois.papon@openobject.fr>
> > wrote:
> >
> > > +1 (non-binding)Tested with some internal projects.Thanks
> > > JB!regardsFrançois
> > > -------- Message d'origine --------De : Jean-Baptiste Onofré <
> > > jb@nanthrax.net> Date : 07/03/2022 18:25 (GMT+01:00) À :
> > > dev@activemq.apache.org Objet : [VOTE] Apache ActiveMQ 5.17.0 release
> Hi
> > > guys,*Finally*, after several weeks waiting, I'm pleased to submit
> > > ApacheActiveMQ 5.17.0 release to your vote.This release is an important
> > > milestone in ActiveMQ roadmap, including 200issues, especially:-
> support
> > > Spring 5.x- support log4j 2.x (2.17.1)- JDK 11+ support for both build
> and
> > > runtime- remove of activemq-camel component (replaced by camel-activemq
> > > andcamel-jms components)- remove leveldb- tons of fixes and dependency
> > > updatesPlease take a look on the Release Notes for details:
> > >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12346476Maven
> > > Staging Repository:
> > >
> https://repository.apache.org/content/repositories/orgapacheactivemq-1247/Dist
> > > Staging Repository:
> > > https://dist.apache.org/repos/dist/dev/activemq/activemq/5.17.0/Git
> tag:
> > > activemq-5.17.0Please vote to approve this release:[ ] +1 Approve the
> > > release[ ] -1 Don't approve the release (please provide specific
> > > comments)This vote will be open for at least 72 hours.Thanks !RegardsJB
>
Re: [VOTE] Apache ActiveMQ 5.17.0 release
Posted by Robbie Gemmell <ro...@gmail.com>.
I would have voted positively had Chris not already found the issues
he did, which indeed seem like they need fixed.
I checked things out as follows:
- Verified the signature + checksum files.
- Checked for LICENCE and NOTICE files present in the archives.
- Checked headers in the source archive with: mvn apache-rat:check
- Ran the source build, plus the AMQP integration tests, on JDK 11.
- Ran the Qpid JMS 1.5.0 HelloWorld against a broker started from the
tar.gz binary archive on JDK 11 and JDK 17.
Robbie
On Wed, 9 Mar 2022 at 15:46, Christopher Shannon
<ch...@gmail.com> wrote:
>
> Unfortunately I have to change my vote to -1.
>
> It looks like the activemq-pool jar is now shaded and pulling in a bunch of
> other stuff. This caused my build to break as it pulled in the old
> javax.annotation packages which broke due to:
> https://issues.apache.org/jira/browse/AMQ-8530
>
> So I think we need to cancel the vote and fix the build so it's not shaded
> (I assume it's an OSGi issue). We can also go ahead and merge in AMQ-8530
> (and some other test fixes)
>
> On Tue, Mar 8, 2022 at 3:18 PM francois.papon <fr...@openobject.fr>
> wrote:
>
> > +1 (non-binding)Tested with some internal projects.Thanks
> > JB!regardsFrançois
> > -------- Message d'origine --------De : Jean-Baptiste Onofré <
> > jb@nanthrax.net> Date : 07/03/2022 18:25 (GMT+01:00) À :
> > dev@activemq.apache.org Objet : [VOTE] Apache ActiveMQ 5.17.0 release Hi
> > guys,*Finally*, after several weeks waiting, I'm pleased to submit
> > ApacheActiveMQ 5.17.0 release to your vote.This release is an important
> > milestone in ActiveMQ roadmap, including 200issues, especially:- support
> > Spring 5.x- support log4j 2.x (2.17.1)- JDK 11+ support for both build and
> > runtime- remove of activemq-camel component (replaced by camel-activemq
> > andcamel-jms components)- remove leveldb- tons of fixes and dependency
> > updatesPlease take a look on the Release Notes for details:
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12346476Maven
> > Staging Repository:
> > https://repository.apache.org/content/repositories/orgapacheactivemq-1247/Dist
> > Staging Repository:
> > https://dist.apache.org/repos/dist/dev/activemq/activemq/5.17.0/Git tag:
> > activemq-5.17.0Please vote to approve this release:[ ] +1 Approve the
> > release[ ] -1 Don't approve the release (please provide specific
> > comments)This vote will be open for at least 72 hours.Thanks !RegardsJB
Re: [VOTE] Apache ActiveMQ 5.17.0 release
Posted by Christopher Shannon <ch...@gmail.com>.
Unfortunately I have to change my vote to -1.
It looks like the activemq-pool jar is now shaded and pulling in a bunch of
other stuff. This caused my build to break as it pulled in the old
javax.annotation packages which broke due to:
https://issues.apache.org/jira/browse/AMQ-8530
So I think we need to cancel the vote and fix the build so it's not shaded
(I assume it's an OSGi issue). We can also go ahead and merge in AMQ-8530
(and some other test fixes)
On Tue, Mar 8, 2022 at 3:18 PM francois.papon <fr...@openobject.fr>
wrote:
> +1 (non-binding)Tested with some internal projects.Thanks
> JB!regardsFrançois
> -------- Message d'origine --------De : Jean-Baptiste Onofré <
> jb@nanthrax.net> Date : 07/03/2022 18:25 (GMT+01:00) À :
> dev@activemq.apache.org Objet : [VOTE] Apache ActiveMQ 5.17.0 release Hi
> guys,*Finally*, after several weeks waiting, I'm pleased to submit
> ApacheActiveMQ 5.17.0 release to your vote.This release is an important
> milestone in ActiveMQ roadmap, including 200issues, especially:- support
> Spring 5.x- support log4j 2.x (2.17.1)- JDK 11+ support for both build and
> runtime- remove of activemq-camel component (replaced by camel-activemq
> andcamel-jms components)- remove leveldb- tons of fixes and dependency
> updatesPlease take a look on the Release Notes for details:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12346476Maven
> Staging Repository:
> https://repository.apache.org/content/repositories/orgapacheactivemq-1247/Dist
> Staging Repository:
> https://dist.apache.org/repos/dist/dev/activemq/activemq/5.17.0/Git tag:
> activemq-5.17.0Please vote to approve this release:[ ] +1 Approve the
> release[ ] -1 Don't approve the release (please provide specific
> comments)This vote will be open for at least 72 hours.Thanks !RegardsJB
RE: [VOTE] Apache ActiveMQ 5.17.0 release
Posted by "francois.papon" <fr...@openobject.fr>.
+1 (non-binding)Tested with some internal projects.Thanks JB!regardsFrançois
-------- Message d'origine --------De : Jean-Baptiste Onofré <jb...@nanthrax.net> Date : 07/03/2022 18:25 (GMT+01:00) À : dev@activemq.apache.org Objet : [VOTE] Apache ActiveMQ 5.17.0 release Hi guys,*Finally*, after several weeks waiting, I'm pleased to submit ApacheActiveMQ 5.17.0 release to your vote.This release is an important milestone in ActiveMQ roadmap, including 200issues, especially:- support Spring 5.x- support log4j 2.x (2.17.1)- JDK 11+ support for both build and runtime- remove of activemq-camel component (replaced by camel-activemq andcamel-jms components)- remove leveldb- tons of fixes and dependency updatesPlease take a look on the Release Notes for details:https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12346476Maven Staging Repository:https://repository.apache.org/content/repositories/orgapacheactivemq-1247/Dist Staging Repository:https://dist.apache.org/repos/dist/dev/activemq/activemq/5.17.0/Git tag: activemq-5.17.0Please vote to approve this release:[ ] +1 Approve the release[ ] -1 Don't approve the release (please provide specific comments)This vote will be open for at least 72 hours.Thanks !RegardsJB