You are viewing a plain text version of this content. The canonical link for it is here.
Posted to modperl@perl.apache.org by Torsten Förtsch <to...@gmx.net> on 2004/10/24 14:16:09 UTC

[mod_perl 1.99_17] make test fails

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

"make test" for 1.99_17 generates this error:

- ---------------------------------------------------------------------------------------
t/apr-ext/finfo.........................Insecure dependency in require while running with -T switch at /usr/src/packages/BUILD/mod_perl-1.99_17/blib/lib/Apache/TestConfig.pm line 2080.
BEGIN failed--compilation aborted at /usr/src/packages/BUILD/mod_perl-1.99_17/t/lib/TestAPRlib/finfo.pm line 20.
Compilation failed in require at t/apr-ext/finfo.t line 7.
BEGIN failed--compilation aborted at t/apr-ext/finfo.t line 7.
t/apr-ext/finfo.........................dubious                              
        Test returned status 2 (wstat 512, 0x200)
Scalar found where operator expected at (eval 177) line 1, near "'int'  $__val"
        (Missing operator before   $__val?)
t/apr-ext/pool..........................ok                                   
t/apr-ext/string........................ok                                   
t/apr-ext/table.........................ok                                   
t/apr-ext/threadmutex...................ok                                   
t/apr-ext/uri...........................ok                                   
t/apr-ext/util..........................Insecure dependency in require while running with -T switch at /usr/src/packages/BUILD/mod_perl-1.99_17/blib/lib/Apache/TestConfig.pm line 2080.
Compilation failed in require at t/apr-ext/util.t line 7.
BEGIN failed--compilation aborted at t/apr-ext/util.t line 7.
t/apr-ext/util..........................dubious                              
        Test returned status 2 (wstat 512, 0x200)
- ---------------------------------------------------------------------------------------


The problem is in Apache::TestConfig::custom_config_path:

        my $candidate = File::Spec->rel2abs(catfile $_, CUSTOM_CONFIG_FILE);
        next unless -e $candidate;
        return $custom_config_path = $candidate;

where $candidate is obviously insecure.

The attached patch fixed the problem for me.

Torsten

PS: in case it matters:
r2@opi:~/work/bahn> perl -V
Summary of my perl5 (revision 5.0 version 8 subversion 3) configuration:
  Platform:
    osname=linux, osvers=2.6.4, archname=i586-linux-thread-multi
    uname='linux d209 2.6.4 #1 smp thu mar 11 17:56:49 utc 2004 i686 i686 i386 gnulinux '
    config_args='-ds -e -Dprefix=/usr -Dvendorprefix=/usr -Dinstallusrbinperl -Dusethreads -Di_db -Di_dbm -Di_ndbm -Di_gdbm -Duseshrplib=true -Doptimize=-O2 -march=i586 -mcpu=i686 -fmessage-length=0 -Wall -Wall -pipe'
    hint=recommended, useposix=true, d_sigaction=define
    usethreads=define use5005threads=undef useithreads=define usemultiplicity=define
    useperlio=define d_sfio=undef uselargefiles=define usesocks=undef
    use64bitint=undef use64bitall=undef uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='cc', ccflags ='-D_REENTRANT -D_GNU_SOURCE -DTHREADS_HAVE_PIDS -fno-strict-aliasing -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
    optimize='-O2 -march=i586 -mcpu=i686 -fmessage-length=0 -Wall -Wall -pipe',
    cppflags='-D_REENTRANT -D_GNU_SOURCE -DTHREADS_HAVE_PIDS -fno-strict-aliasing'
    ccversion='', gccversion='3.3.3 (SuSE Linux)', gccosandvers=''
    intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12
    ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
    alignbytes=4, prototype=define
  Linker and Libraries:
    ld='cc', ldflags =''
    libpth=/lib /usr/lib /usr/local/lib
    libs=-lnsl -ldl -lm -lcrypt -lutil -lpthread -lc
    perllibs=-lnsl -ldl -lm -lcrypt -lutil -lpthread -lc
    libc=, so=so, useshrplib=true, libperl=libperl.so
    gnulibc_version='2.3.3'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-rdynamic -Wl,-rpath,/usr/lib/perl5/5.8.3/i586-linux-thread-multi/CORE'
    cccdlflags='-fPIC', lddlflags='-shared'


Characteristics of this binary (from libperl): 
  Compile-time options: MULTIPLICITY USE_ITHREADS USE_LARGE_FILES PERL_IMPLICIT_CONTEXT
  Built under linux
  Compiled at Apr  3 2004 00:52:08
  @INC:
    /usr/lib/perl5/5.8.3/i586-linux-thread-multi
    /usr/lib/perl5/5.8.3
    /usr/lib/perl5/site_perl/5.8.3/i586-linux-thread-multi
    /usr/lib/perl5/site_perl/5.8.3
    /usr/lib/perl5/site_perl
    /usr/lib/perl5/vendor_perl/5.8.3/i586-linux-thread-multi
    /usr/lib/perl5/vendor_perl/5.8.3
    /usr/lib/perl5/vendor_perl
    .
r2@opi:/usr/src/packages/BUILD> /usr/sbin/httpd2-prefork -V   
Server version: Apache/2.0.52
Server built:   Oct 20 2004 15:41:40
Server's Module Magic Number: 20020903:9
Architecture:   32-bit
Server compiled with....
 -D APACHE_MPM_DIR="server/mpm/prefork"
 -D APR_HAS_SENDFILE
 -D APR_HAS_MMAP
 -D APR_HAVE_IPV6 (IPv4-mapped addresses enabled)
 -D APR_USE_SYSVSEM_SERIALIZE
 -D APR_USE_PTHREAD_SERIALIZE
 -D SINGLE_LISTEN_UNSERIALIZED_ACCEPT
 -D APR_HAS_OTHER_CHILD
 -D AP_HAVE_RELIABLE_PIPED_LOGS
 -D HTTPD_ROOT="/srv/www"
 -D SUEXEC_BIN="/usr/sbin/suexec2"
 -D DEFAULT_PIDLOG="/var/run/httpd2.pid"
 -D DEFAULT_SCOREBOARD="logs/apache_runtime_status"
 -D DEFAULT_LOCKFILE="/var/run/accept.lock"
 -D DEFAULT_ERRORLOG="/var/log/apache2/error_log"
 -D AP_TYPES_CONFIG_FILE="/etc/apache2/mime.types"
 -D SERVER_CONFIG_FILE="/etc/apache2/httpd.conf"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFBe50QwicyCTir8T4RApxkAKCDCNJILjF0im5DDblX7CPTQelNKQCcDyfG
Qg/W77hT3elMx2uB3mWONFE=
=5JyF
-----END PGP SIGNATURE-----

Re: [mod_perl 1.99_17] make test fails

Posted by Stas Bekman <st...@stason.org>.
Torsten Förtsch wrote:

> "make test" for 1.99_17 generates this error:
> 
> - ---------------------------------------------------------------------------------------
> t/apr-ext/finfo.........................Insecure dependency in require while running with -T switch at /usr/src/packages/BUILD/mod_perl-1.99_17/blib/lib/Apache/TestConfig.pm line 2080.
> BEGIN failed--compilation aborted at /usr/src/packages/BUILD/mod_perl-1.99_17/t/lib/TestAPRlib/finfo.pm line 20.
> Compilation failed in require at t/apr-ext/finfo.t line 7.
> BEGIN failed--compilation aborted at t/apr-ext/finfo.t line 7.
[...]
> --- Apache-Test/lib/Apache/TestConfig.pm~	2004-10-22 22:11:51.000000000 +0200
> +++ Apache-Test/lib/Apache/TestConfig.pm	2004-10-24 13:52:59.639838096 +0200
> @@ -1817,6 +1817,7 @@
>      for (@inc) {
>          my $candidate = File::Spec->rel2abs(catfile $_, CUSTOM_CONFIG_FILE);
>          next unless -e $candidate;
> +	($candidate) = $candidate=~/^(.*)/;

thanks, Torsten, committed.

(I wonder why I've never hit this error before)

-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

-- 
Report problems: http://perl.apache.org/bugs/
Mail list info: http://perl.apache.org/maillist/modperl.html
List etiquette: http://perl.apache.org/maillist/email-etiquette.html