[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6389: libc/ipc: add ftok(3) support

[GitBox <gi...@apache.org>]

anchao commented on code in PR #6389:
URL: https://github.com/apache/incubator-nuttx/pull/6389#discussion_r893247614


##########
include/sys/types.h:
##########
@@ -158,7 +158,7 @@ typedef int          id_t;
  * semaphores. A key is simply an integer of type key_t
  */
 
-typedef int16_t      key_t;
+typedef long         key_t;

Review Comment:
   Done



##########
include/sys/ipc.h:
##########
@@ -35,10 +35,10 @@
 
 /* Mode bits:  The lower order 9-bit bits are the standard mode bits */
 
-#define IPC_MODE    0x01ff     /* Mode bit mask */
-#define IPC_CREAT   (1 << 10)  /* Create entry if key does not exist */
-#define IPC_EXCL    (1 << 11)  /* Fail if key exists */
-#define IPC_NOWAIT  (1 << 12)  /* Error if request must wait */
+#define IPC_MODE    0x01ff  /* Mode bit mask */
+#define IPC_CREAT   01000   /* Create key if key does not exist. */
+#define IPC_EXCL    02000   /* Fail if key exists.  */
+#define IPC_NOWAIT  04000   /* Return error on wait.  */

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org