You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2026/10/04 04:40:00 UTC

[jira] [Commented] (OFBIZ-13641) Do not evaluate the Ajax update area string of forms twice as an expression

    [ https://issues.apache.org/jira/browse/OFBIZ-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18123049#comment-18123049 ] 

ASF subversion and git services commented on OFBIZ-13641:
---------------------------------------------------------

Commit b81ce7a6ca22cc327196f36fc31d4f5450780252 in ofbiz-framework's branch refs/heads/trunk from Mridul Pathak
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b81ce7a6ca ]

Fixed: Do not evaluate the Ajax update area string of forms twice as an expression (OFBIZ-13641)

MacroCommonRenderer.createAjaxParamsFromUpdateAreas built the string of an update area from the area id, the target and the parameters, and then evaluated the whole string again as a FlexibleStringExpander. The target and the parameters were already evaluated, and the parameters URL encoded, so what comes from the request, such as the query string of a paginated form, was evaluated a second time.

Only the area id is still a raw value of the widget, so it is now evaluated on its own, and the evaluation of the whole string is removed.


> Do not evaluate the Ajax update area string of forms twice as an expression
> ---------------------------------------------------------------------------
>
>                 Key: OFBIZ-13641
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-13641
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework/widget
>    Affects Versions: Upcoming Branch, 24.09.07
>            Reporter: Mridul Pathak
>            Assignee: Mridul Pathak
>            Priority: Minor
>
> MacroCommonRenderer.createAjaxParamsFromUpdateAreas builds the CSV string for the update areas from the area id, the target (already evaluated by UpdateArea.getAreaTarget) and the parameters (already evaluated and URL encoded), and then evaluates the whole string again as a FlexibleStringExpander. This was added in OFBIZ-5227 when the string held the raw values of the XML. Only the area id is still a raw XML attribute, so values that come from the request and are already evaluated are evaluated a second time.
> h3. Plan
> * Evaluate the area id on its own and remove the evaluation of the whole string.
> * Backport to release24.09.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)