[GitHub] [commons-io] adamretter commented on a change in pull request #108: Refactor ByteArrayOutputStream into synchronized and non-synchronized versions

[GitBox <gi...@apache.org>]

adamretter commented on a change in pull request #108: Refactor ByteArrayOutputStream into synchronized and non-synchronized versions
URL: https://github.com/apache/commons-io/pull/108#discussion_r402980055
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -226,6 +230,11 @@ file comparators, endian transformation classes, and much more.
   </contributors>
 
   <dependencies>
+    <dependency>
+      <groupId>com.google.code.findbugs</groupId>
+      <artifactId>jsr305</artifactId>
 
 Review comment:
   Well yes it is to bring in the annotation... but these annotations can also be used by various tools like FindBugs and others to detect issues.
   
   I think it adds value, and jsr305 is tiny (19KB). I can remove it if people prefer? It also adds useful annotations like `@Nullable` and `@NotNull` for similar purposes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services