You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/06/24 12:35:18 UTC
[GitHub] [accumulo] brianloss opened a new issue #1643: Rename master references in public API
brianloss opened a new issue #1643:
URL: https://github.com/apache/accumulo/issues/1643
Once a new name is selected, we'll need to rename master references in the public API. Per [semver](https://semver.org/), the existing references will need to be deprecated for at least a release, and then the deprecated methods can be removed in a major release. Identify all public API references to master. At least the following exist:
- [Instance.getMasterLocations](https://github.com/apache/accumulo/blob/master/core/src/main/java/org/apache/accumulo/core/client/Instance.java#L48)
- [ZooKeeperInstance.getMasterLocations](https://github.com/apache/accumulo/blob/master/core/src/main/java/org/apache/accumulo/core/client/ZooKeeperInstance.java#L137)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii closed issue #1643: Rename master references in public API
Posted by GitBox <gi...@apache.org>.
ctubbsii closed issue #1643:
URL: https://github.com/apache/accumulo/issues/1643
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii closed issue #1643: Rename master references in public API
Posted by GitBox <gi...@apache.org>.
ctubbsii closed issue #1643:
URL: https://github.com/apache/accumulo/issues/1643
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on issue #1643: Rename master references in public API
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on issue #1643:
URL: https://github.com/apache/accumulo/issues/1643#issuecomment-690379138
@jkosh44 The main issue here is to address the user-facing public APIs, because require thoughtful consideration with a plan, and affect our versioning, and are not simple renames. Those should go through a deprecation cycle (with replacements), and be dropped on the next major version.
Take a look at our public API definition at https://accumulo.apache.org/api/ for details on what is considered public API.
There are (at least) two separate, but related, steps that can be done also, but may be less risky, or at least, can be worked independently:
1. User-facing non-API things like documentation, configuration properties, and configuration files, and the monitor
2. Everything else that is internal-only, including things like `MasterClient`, field names (with careful consideration of serialization), and test cases, can probably be changed at any time, because they have no impact on the end user.
These tasks should be performed separately, and be made incrementally so as to reduce the risk of mistakes, and to not overwhelm reviewers (because the changes will be large).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii closed issue #1643: Rename master references in public API
Posted by GitBox <gi...@apache.org>.
ctubbsii closed issue #1643:
URL: https://github.com/apache/accumulo/issues/1643
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on issue #1643: Rename master references in public API
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on issue #1643:
URL: https://github.com/apache/accumulo/issues/1643#issuecomment-690841290
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] jkosh44 commented on issue #1643: Rename master references in public API
Posted by GitBox <gi...@apache.org>.
jkosh44 commented on issue #1643:
URL: https://github.com/apache/accumulo/issues/1643#issuecomment-690382313
Ok, thanks for the clarification
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on issue #1643: Rename master references in public API
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on issue #1643:
URL: https://github.com/apache/accumulo/issues/1643#issuecomment-670340826
The name agreed to in a vote on the mailing list was 'manager'.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on issue #1643: Rename master references in public API
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on issue #1643:
URL: https://github.com/apache/accumulo/issues/1643#issuecomment-690841290
This is partially done. The final removal will need to occur in a 3.0.0 release, because of the API breakages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] jkosh44 commented on issue #1643: Rename master references in public API
Posted by GitBox <gi...@apache.org>.
jkosh44 commented on issue #1643:
URL: https://github.com/apache/accumulo/issues/1643#issuecomment-690360318
I have a couple questions on this.
- Do we just want to change the method names or all references?
- What about variable names, enum values, and constants?
- Do we just care about public API methods are do we also want to change internal methods?
- What about class names? For example `MasterClient`. One solution could be to refactor this to `ManagerClient`, then have a subclass called `MasterClient` that just delegates all methods to `ManagerClient`.
- It looks like there are some files called master or that have the word master in it (https://github.com/apache/accumulo/blob/main/minicluster/src/main/java/org/apache/accumulo/cluster/standalone/StandaloneClusterControl.java#L56 for example). How should those be treated? It seems like renaming the file could break existing instances.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on issue #1643: Rename master references in public API
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on issue #1643:
URL: https://github.com/apache/accumulo/issues/1643#issuecomment-690379493
For this issue, I would focus *only* on public API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org