You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/09/01 08:16:14 UTC
[GitHub] [doris] weizuo93 commented on a diff in pull request #12257: [fix](memory): fix coredump when list poinster is null
weizuo93 commented on code in PR #12257:
URL: https://github.com/apache/doris/pull/12257#discussion_r960354265
##########
be/src/runtime/free_pool.hpp:
##########
@@ -128,9 +128,14 @@ class FreePool {
#ifndef NDEBUG
check_valid_allocation(list);
#endif
- // Add node to front of list.
- node->next = list->next;
- list->next = node;
+ if (nullptr == list) {
Review Comment:
Why is `list` nullptr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org