[GitHub] [zookeeper] eolivelli commented on a change in pull request #858: ZOOKEEPER-3321: Add metrics for Leader

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #858: ZOOKEEPER-3321: Add metrics for Leader
URL: https://github.com/apache/zookeeper/pull/858#discussion_r266520216
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Leader.java
 ##########
 @@ -101,6 +101,14 @@ public String toString() {
 
     private final LearnerSnapshotThrottler learnerSnapshotThrottler;
 
+    // log ack latency if zxid is a multiple of ackLoggingFrequency. If <=0, disable logging.
+    protected static final String ACK_LOGGING_FREQUENCY = "zookeeper.leader.ackLoggingFrequency";
+    private static final int ackLoggingFrequency;
+    static {
+        ackLoggingFrequency = Integer.getInteger(ACK_LOGGING_FREQUENCY, 1000);
 
 Review comment:
   not for this patch
   @anmolnar  @phunt we should introduce a common facility to get system properties and log them

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services