You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/01/02 03:04:23 UTC

[GitHub] [incubator-shardingsphere] tuohai666 commented on a change in pull request #3829: Fix Postgres execute error sql no response (#3129)

tuohai666 commented on a change in pull request #3829: Fix Postgres execute error sql no response (#3129)
URL: https://github.com/apache/incubator-shardingsphere/pull/3829#discussion_r362362141
 
 

 ##########
 File path: sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/execute/MySQLComStmtExecuteExecutor.java
 ##########
 @@ -60,6 +60,8 @@
     
     private volatile boolean isQuery;
     
+    private volatile boolean hasError;
 
 Review comment:
   Can you go through MySQL's exception mechanism and try to abstract PostgreSQL's the same way?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services